Skip to content

Commit 9301703

Browse files
authoredJan 31, 2023
fix(es): Remove useless message (#6882)
1 parent 1bf2b2d commit 9301703

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed
 

‎crates/swc/src/lib.rs

+1-3
Original file line numberDiff line numberDiff line change
@@ -414,9 +414,7 @@ impl Compiler {
414414
})?;
415415

416416
if error {
417-
return Err(anyhow::anyhow!("Syntax Error").context(
418-
"error was recoverable, but proceeding would result in wrong codegen",
419-
));
417+
return Err(anyhow::anyhow!("Syntax Error"));
420418
}
421419

422420
Ok(program)

1 commit comments

Comments
 (1)

github-actions[bot] commented on Jan 31, 2023

@github-actions[bot]

Benchmark

Benchmark suite Current: 9301703 Previous: d808864 Ratio
es/full/bugs-1 293266 ns/iter (± 8256) 302348 ns/iter (± 6918) 0.97
es/full/minify/libraries/antd 1470273277 ns/iter (± 28495673) 1839220346 ns/iter (± 17284173) 0.80
es/full/minify/libraries/d3 276921744 ns/iter (± 4732211) 365345779 ns/iter (± 7837626) 0.76
es/full/minify/libraries/echarts 1108111945 ns/iter (± 12708085) 1491165382 ns/iter (± 44447281) 0.74
es/full/minify/libraries/jquery 85154143 ns/iter (± 601999) 95150182 ns/iter (± 569949) 0.89
es/full/minify/libraries/lodash 101748798 ns/iter (± 673236) 113814622 ns/iter (± 1686929) 0.89
es/full/minify/libraries/moment 50320845 ns/iter (± 245100) 56692855 ns/iter (± 530539) 0.89
es/full/minify/libraries/react 18521611 ns/iter (± 73341) 20152570 ns/iter (± 210566) 0.92
es/full/minify/libraries/terser 233943210 ns/iter (± 3003974) 279160025 ns/iter (± 2371785) 0.84
es/full/minify/libraries/three 399774935 ns/iter (± 4702194) 512160319 ns/iter (± 6812667) 0.78
es/full/minify/libraries/typescript 2841171503 ns/iter (± 13751400) 3439812470 ns/iter (± 34257338) 0.83
es/full/minify/libraries/victory 591697321 ns/iter (± 9501648) 766177919 ns/iter (± 13281325) 0.77
es/full/minify/libraries/vue 122968171 ns/iter (± 1012193) 140277605 ns/iter (± 1497259) 0.88
es/full/codegen/es3 24955 ns/iter (± 250) 26739 ns/iter (± 85) 0.93
es/full/codegen/es5 25325 ns/iter (± 206) 26752 ns/iter (± 56) 0.95
es/full/codegen/es2015 25690 ns/iter (± 457) 26711 ns/iter (± 67) 0.96
es/full/codegen/es2016 24994 ns/iter (± 195) 26733 ns/iter (± 72) 0.93
es/full/codegen/es2017 24905 ns/iter (± 222) 26761 ns/iter (± 73) 0.93
es/full/codegen/es2018 24976 ns/iter (± 129) 26802 ns/iter (± 48) 0.93
es/full/codegen/es2019 24941 ns/iter (± 316) 26806 ns/iter (± 60) 0.93
es/full/codegen/es2020 24902 ns/iter (± 138) 26741 ns/iter (± 67) 0.93
es/full/all/es3 168231002 ns/iter (± 3246421) 171069943 ns/iter (± 3607648) 0.98
es/full/all/es5 162484857 ns/iter (± 2860239) 160889771 ns/iter (± 2776839) 1.01
es/full/all/es2015 119545956 ns/iter (± 702584) 126594700 ns/iter (± 1383421) 0.94
es/full/all/es2016 118917492 ns/iter (± 1172000) 123879993 ns/iter (± 2067575) 0.96
es/full/all/es2017 118771467 ns/iter (± 608416) 123506227 ns/iter (± 810647) 0.96
es/full/all/es2018 117035829 ns/iter (± 777488) 120360681 ns/iter (± 934568) 0.97
es/full/all/es2019 115619766 ns/iter (± 778154) 119809025 ns/iter (± 659314) 0.97
es/full/all/es2020 110721147 ns/iter (± 856395) 114930016 ns/iter (± 570283) 0.96
es/full/parser 506336 ns/iter (± 5934) 545340 ns/iter (± 8461) 0.93
es/full/base/fixer 20562 ns/iter (± 111) 21791 ns/iter (± 30) 0.94
es/full/base/resolver_and_hygiene 74951 ns/iter (± 470) 79883 ns/iter (± 155) 0.94
serialization of ast node 117 ns/iter (± 0) 128 ns/iter (± 0) 0.91
serialization of serde 121 ns/iter (± 0) 143 ns/iter (± 0) 0.85
css/minify/libraries/bootstrap 26523448 ns/iter (± 269389) 28681458 ns/iter (± 288678) 0.92
css/visitor/compare/clone 1990952 ns/iter (± 24653) 2115814 ns/iter (± 21658) 0.94
css/visitor/compare/visit_mut_span 2142975 ns/iter (± 23597) 2306346 ns/iter (± 6566) 0.93
css/visitor/compare/visit_mut_span_panic 2206566 ns/iter (± 11382) 2368916 ns/iter (± 9088) 0.93
css/visitor/compare/fold_span 2872778 ns/iter (± 17435) 3080248 ns/iter (± 25074) 0.93
css/visitor/compare/fold_span_panic 3004107 ns/iter (± 14029) 3267650 ns/iter (± 55338) 0.92
css/lexer/bootstrap_5_1_3 4910259 ns/iter (± 24390) 5220782 ns/iter (± 11060) 0.94
css/lexer/foundation_6_7_4 4134992 ns/iter (± 24421) 4380623 ns/iter (± 1321) 0.94
css/lexer/tailwind_3_1_1 815208 ns/iter (± 12427) 833381 ns/iter (± 406) 0.98
css/parser/bootstrap_5_1_3 20504074 ns/iter (± 113974) 22359455 ns/iter (± 133920) 0.92
css/parser/foundation_6_7_4 16416344 ns/iter (± 149023) 17882653 ns/iter (± 77281) 0.92
css/parser/tailwind_3_1_1 3136629 ns/iter (± 26241) 3331746 ns/iter (± 4997) 0.94
es/codegen/colors 325093 ns/iter (± 183834) 321623 ns/iter (± 181597) 1.01
es/codegen/large 1179697 ns/iter (± 594768) 1228217 ns/iter (± 639114) 0.96
es/codegen/with-parser/colors 45663 ns/iter (± 325) 48249 ns/iter (± 334) 0.95
es/codegen/with-parser/large 508255 ns/iter (± 3718) 534237 ns/iter (± 1710) 0.95
es/minify/libraries/antd 1254676418 ns/iter (± 25470109) 1669568267 ns/iter (± 28870930) 0.75
es/minify/libraries/d3 238575434 ns/iter (± 3695128) 296273856 ns/iter (± 9357110) 0.81
es/minify/libraries/echarts 955828810 ns/iter (± 13784652) 1226252937 ns/iter (± 7526363) 0.78
es/minify/libraries/jquery 74321683 ns/iter (± 625301) 84579720 ns/iter (± 1890277) 0.88
es/minify/libraries/lodash 91253300 ns/iter (± 405495) 102303045 ns/iter (± 1513198) 0.89
es/minify/libraries/moment 43941735 ns/iter (± 196280) 47729114 ns/iter (± 586289) 0.92
es/minify/libraries/react 16440945 ns/iter (± 132160) 17951283 ns/iter (± 286399) 0.92
es/minify/libraries/terser 194220653 ns/iter (± 1813016) 250253702 ns/iter (± 5927344) 0.78
es/minify/libraries/three 326343764 ns/iter (± 4718469) 445599495 ns/iter (± 7925622) 0.73
es/minify/libraries/typescript 2431495419 ns/iter (± 26257625) 3054094863 ns/iter (± 33993066) 0.80
es/minify/libraries/victory 492814934 ns/iter (± 9710885) 682082393 ns/iter (± 20871786) 0.72
es/minify/libraries/vue 109298221 ns/iter (± 368707) 126589907 ns/iter (± 2878542) 0.86
es/visitor/compare/clone 2296110 ns/iter (± 34077) 2419711 ns/iter (± 12743) 0.95
es/visitor/compare/visit_mut_span 2653858 ns/iter (± 20921) 2833892 ns/iter (± 16413) 0.94
es/visitor/compare/visit_mut_span_panic 2679216 ns/iter (± 7878) 2911525 ns/iter (± 23347) 0.92
es/visitor/compare/fold_span 3735774 ns/iter (± 26055) 4063717 ns/iter (± 94887) 0.92
es/visitor/compare/fold_span_panic 3889654 ns/iter (± 21787) 4207318 ns/iter (± 57678) 0.92
es/lexer/colors 16931 ns/iter (± 281) 17275 ns/iter (± 28) 0.98
es/lexer/angular 7879774 ns/iter (± 51444) 8301647 ns/iter (± 10575) 0.95
es/lexer/backbone 1035074 ns/iter (± 7476) 1086035 ns/iter (± 1699) 0.95
es/lexer/jquery 5738852 ns/iter (± 45848) 6037166 ns/iter (± 3202) 0.95
es/lexer/jquery mobile 8852055 ns/iter (± 147523) 9262743 ns/iter (± 9934) 0.96
es/lexer/mootools 4483291 ns/iter (± 51884) 4721274 ns/iter (± 9206) 0.95
es/lexer/underscore 864599 ns/iter (± 4580) 904984 ns/iter (± 326) 0.96
es/lexer/three 26592254 ns/iter (± 147210) 28128659 ns/iter (± 34722) 0.95
es/lexer/yui 4906361 ns/iter (± 57230) 5078917 ns/iter (± 6560) 0.97
es/parser/colors 30247 ns/iter (± 213) 30966 ns/iter (± 132) 0.98
es/parser/angular 14991831 ns/iter (± 92124) 17098982 ns/iter (± 462668) 0.88
es/parser/backbone 2193035 ns/iter (± 15764) 2340462 ns/iter (± 14720) 0.94
es/parser/jquery 11773229 ns/iter (± 109606) 13230750 ns/iter (± 259635) 0.89
es/parser/jquery mobile 18419545 ns/iter (± 162049) 21625220 ns/iter (± 726970) 0.85
es/parser/mootools 9019357 ns/iter (± 93591) 9866679 ns/iter (± 63985) 0.91
es/parser/underscore 1850926 ns/iter (± 22788) 1981942 ns/iter (± 12377) 0.93
es/parser/three 51192611 ns/iter (± 957795) 63150170 ns/iter (± 163132) 0.81
es/parser/yui 9034701 ns/iter (± 94924) 9946494 ns/iter (± 101790) 0.91
es/preset-env/usage/builtin_type 143157 ns/iter (± 32701) 139667 ns/iter (± 30541) 1.02
es/preset-env/usage/property 20052 ns/iter (± 431) 21555 ns/iter (± 103) 0.93
es/resolver/typescript 105181108 ns/iter (± 831724) 127350791 ns/iter (± 3797113) 0.83
es/fixer/typescript 80017946 ns/iter (± 1551800) 102961304 ns/iter (± 1795336) 0.78
es/hygiene/typescript 167910501 ns/iter (± 2642390) 221371397 ns/iter (± 3479976) 0.76
es/resolver_with_hygiene/typescript 293175046 ns/iter (± 1994561) 367164160 ns/iter (± 2662890) 0.80
es/visitor/base-perf/module_clone 72032 ns/iter (± 1885) 75674 ns/iter (± 1576) 0.95
es/visitor/base-perf/fold_empty 81277 ns/iter (± 1398) 86089 ns/iter (± 1329) 0.94
es/visitor/base-perf/fold_noop_impl_all 82295 ns/iter (± 1669) 85988 ns/iter (± 1050) 0.96
es/visitor/base-perf/fold_noop_impl_vec 81441 ns/iter (± 1359) 86120 ns/iter (± 1968) 0.95
es/visitor/base-perf/boxing_boxed_clone 53 ns/iter (± 0) 56 ns/iter (± 0) 0.95
es/visitor/base-perf/boxing_unboxed_clone 56 ns/iter (± 0) 59 ns/iter (± 0) 0.95
es/visitor/base-perf/boxing_boxed 99 ns/iter (± 0) 105 ns/iter (± 0) 0.94
es/visitor/base-perf/boxing_unboxed 98 ns/iter (± 0) 103 ns/iter (± 0) 0.95
es/visitor/base-perf/visit_contains_this 3367 ns/iter (± 64) 3375 ns/iter (± 67) 1.00
es/base/parallel/resolver/typescript 5048464215 ns/iter (± 334897742) 5630145772 ns/iter (± 517716494) 0.90
es/base/parallel/hygiene/typescript 2096829892 ns/iter (± 32104289) 2431425921 ns/iter (± 36064271) 0.86
misc/visitors/time-complexity/time 5 97 ns/iter (± 1) 102 ns/iter (± 0) 0.95
misc/visitors/time-complexity/time 10 304 ns/iter (± 4) 320 ns/iter (± 0) 0.95
misc/visitors/time-complexity/time 15 639 ns/iter (± 19) 661 ns/iter (± 12) 0.97
misc/visitors/time-complexity/time 20 1197 ns/iter (± 15) 1254 ns/iter (± 3) 0.95
misc/visitors/time-complexity/time 40 6276 ns/iter (± 50) 6635 ns/iter (± 5) 0.95
misc/visitors/time-complexity/time 60 16228 ns/iter (± 108) 17071 ns/iter (± 44) 0.95
es/full-target/es2016 179583 ns/iter (± 1216) 189311 ns/iter (± 259) 0.95
es/full-target/es2017 173127 ns/iter (± 474) 184821 ns/iter (± 823) 0.94
es/full-target/es2018 162952 ns/iter (± 760) 174176 ns/iter (± 496) 0.94
es2020_nullish_coalescing 63414 ns/iter (± 644) 67624 ns/iter (± 95) 0.94
es2020_optional_chaining 90322 ns/iter (± 580) 96694 ns/iter (± 6112) 0.93
es2022_class_properties 89078 ns/iter (± 1069) 95042 ns/iter (± 159) 0.94
es2018_object_rest_spread 67650 ns/iter (± 450) 72250 ns/iter (± 210) 0.94
es2019_optional_catch_binding 58755 ns/iter (± 1093) 61909 ns/iter (± 105) 0.95
es2017_async_to_generator 61594 ns/iter (± 268) 62335 ns/iter (± 122) 0.99
es2016_exponentiation 64497 ns/iter (± 341) 65535 ns/iter (± 120) 0.98
es2015_arrow 69729 ns/iter (± 405) 70985 ns/iter (± 301) 0.98
es2015_block_scoped_fn 63196 ns/iter (± 378) 66905 ns/iter (± 175) 0.94
es2015_block_scoping 148022 ns/iter (± 8263) 156186 ns/iter (± 9273) 0.95
es2015_classes 110650 ns/iter (± 661) 118193 ns/iter (± 405) 0.94
es2015_computed_props 58050 ns/iter (± 367) 61808 ns/iter (± 96) 0.94
es2015_destructuring 109623 ns/iter (± 792) 116421 ns/iter (± 268) 0.94
es2015_duplicate_keys 60684 ns/iter (± 325) 64474 ns/iter (± 203) 0.94
es2015_parameters 77729 ns/iter (± 1318) 80425 ns/iter (± 193) 0.97
es2015_fn_name 62719 ns/iter (± 466) 67401 ns/iter (± 647) 0.93
es2015_for_of 60876 ns/iter (± 331) 64926 ns/iter (± 125) 0.94
es2015_instanceof 60195 ns/iter (± 537) 63940 ns/iter (± 46) 0.94
es2015_shorthand_property 58178 ns/iter (± 447) 61356 ns/iter (± 71) 0.95
es2015_spread 57760 ns/iter (± 219) 61845 ns/iter (± 96) 0.93
es2015_sticky_regex 59211 ns/iter (± 353) 63006 ns/iter (± 101) 0.94
es2015_typeof_symbol 59295 ns/iter (± 407) 63094 ns/iter (± 116) 0.94
es/transform/baseline/base 49324 ns/iter (± 357) 52412 ns/iter (± 80) 0.94
es/transform/baseline/common_reserved_word 59451 ns/iter (± 473) 63372 ns/iter (± 152) 0.94
es/transform/baseline/common_typescript 136335 ns/iter (± 2483) 169464 ns/iter (± 319) 0.80
es/target/es3 161931 ns/iter (± 872) 170554 ns/iter (± 630) 0.95
es/target/es2015 595817 ns/iter (± 4450) 635540 ns/iter (± 1319) 0.94
es/target/es2016 61674 ns/iter (± 257) 65600 ns/iter (± 133) 0.94
es/target/es2017 58892 ns/iter (± 302) 62371 ns/iter (± 94) 0.94
es/target/es2018 77426 ns/iter (± 479) 82535 ns/iter (± 126) 0.94
es/target/es2020 126415 ns/iter (± 1384) 134458 ns/iter (± 212) 0.94
babelify-only 649615 ns/iter (± 3404) 672356 ns/iter (± 1420) 0.97
parse_and_babelify_angular 41685148 ns/iter (± 977878) 48187699 ns/iter (± 834245) 0.87
parse_and_babelify_backbone 5154679 ns/iter (± 39019) 5718104 ns/iter (± 70607) 0.90
parse_and_babelify_jquery 30312087 ns/iter (± 257966) 35247742 ns/iter (± 416534) 0.86
parse_and_babelify_jquery_mobile 50150919 ns/iter (± 453193) 61896718 ns/iter (± 817264) 0.81
parse_and_babelify_mootools 30269901 ns/iter (± 229493) 37003230 ns/iter (± 523291) 0.82
parse_and_babelify_underscore 4240916 ns/iter (± 39323) 4542351 ns/iter (± 40073) 0.93
parse_and_babelify_yui 29289373 ns/iter (± 418024) 36640913 ns/iter (± 1238100) 0.80
html/minify/document/css_spec 39481710 ns/iter (± 437825) 44291128 ns/iter (± 361843) 0.89
html/minify/document/github 16678226 ns/iter (± 96807) 17792379 ns/iter (± 80588) 0.94
html/minify/document/stackoverflow 14857403 ns/iter (± 101879) 15917002 ns/iter (± 48302) 0.93
html/minify/document_fragment/css_spec 37470764 ns/iter (± 682645) 42674394 ns/iter (± 611665) 0.88
html/minify/document_fragment/github 15976284 ns/iter (± 139247) 16978188 ns/iter (± 60014) 0.94
html/minify/document_fragment/stackoverflow 14429945 ns/iter (± 38799) 15526874 ns/iter (± 64857) 0.93
html/document/visitor/compare/clone 327993 ns/iter (± 3434) 344076 ns/iter (± 1974) 0.95
html/document/visitor/compare/visit_mut_span 348550 ns/iter (± 2566) 369169 ns/iter (± 1960) 0.94
html/document/visitor/compare/visit_mut_span_panic 355510 ns/iter (± 1682) 377626 ns/iter (± 2220) 0.94
html/document/visitor/compare/fold_span 389256 ns/iter (± 2866) 406351 ns/iter (± 1815) 0.96
html/document/visitor/compare/fold_span_panic 440612 ns/iter (± 5221) 467779 ns/iter (± 1656) 0.94
html/document_fragment/visitor/compare/clone 325928 ns/iter (± 2579) 341415 ns/iter (± 2181) 0.95
html/document_fragment/visitor/compare/visit_mut_span 349962 ns/iter (± 4673) 370967 ns/iter (± 1757) 0.94
html/document_fragment/visitor/compare/visit_mut_span_panic 359524 ns/iter (± 1988) 377739 ns/iter (± 1722) 0.95
html/document_fragment/visitor/compare/fold_span 399564 ns/iter (± 2683) 407904 ns/iter (± 2083) 0.98
html/document_fragment/visitor/compare/fold_span_panic 437122 ns/iter (± 2977) 463249 ns/iter (± 1492) 0.94
html/lexer/css_2021_spec 15062865 ns/iter (± 210951) 15487346 ns/iter (± 22731) 0.97
html/lexer/github_com_17_05_2022 5717223 ns/iter (± 74587) 6015239 ns/iter (± 7744) 0.95
html/lexer/stackoverflow_com_17_05_2022 5588805 ns/iter (± 52895) 5608953 ns/iter (± 3784) 1.00
html/parser/parser_document/css_2021_spec 25224905 ns/iter (± 311204) 26718359 ns/iter (± 225984) 0.94
html/parser/parser_document/github_com_17_05_2022 8412039 ns/iter (± 96220) 8820373 ns/iter (± 13362) 0.95
html/parser/parser_document/stackoverflow_com_17_05_2022 7524806 ns/iter (± 32520) 7753536 ns/iter (± 6810) 0.97
html/parser/parser_document_fragment/css_2021_spec 25096199 ns/iter (± 462398) 26779203 ns/iter (± 224597) 0.94
html/parser/parser_document_fragment/github_com_17_05_2022 8646918 ns/iter (± 103493) 8880090 ns/iter (± 429397) 0.97
html/parser/parser_document_fragment/stackoverflow_com_17_05_2022 7394451 ns/iter (± 126917) 7732930 ns/iter (± 7629) 0.96

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.