Skip to content

Commit

Permalink
fix(bindings): Don't require unnecessary package (#6902)
Browse files Browse the repository at this point in the history
  • Loading branch information
AsPulse committed Feb 5, 2023
1 parent c223113 commit 964dfba
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions node-swc/src/binding.js
Expand Up @@ -102,15 +102,6 @@ switch (platform) {
}
break
case 'darwin':
localFileExisted = existsSync(join(__dirname, 'swc.darwin-universal.node'))
try {
if (localFileExisted) {
nativeBinding = require('./swc.darwin-universal.node')
} else {
nativeBinding = require('@swc/core-darwin-universal')
}
break
} catch {}
switch (arch) {
case 'x64':
localFileExisted = existsSync(join(__dirname, 'swc.darwin-x64.node'))
Expand Down

1 comment on commit 964dfba

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 964dfba Previous: 861d87c Ratio
es/full/bugs-1 308355 ns/iter (± 8960) 305294 ns/iter (± 14327) 1.01
es/full/minify/libraries/antd 1689702319 ns/iter (± 25098751) 1672102871 ns/iter (± 41533214) 1.01
es/full/minify/libraries/d3 292472908 ns/iter (± 6927954) 297534413 ns/iter (± 12411344) 0.98
es/full/minify/libraries/echarts 1279177507 ns/iter (± 15176225) 1278716669 ns/iter (± 38813575) 1.00
es/full/minify/libraries/jquery 90092868 ns/iter (± 391843) 90084734 ns/iter (± 1519705) 1.00
es/full/minify/libraries/lodash 106033333 ns/iter (± 554219) 106272548 ns/iter (± 1499115) 1.00
es/full/minify/libraries/moment 52671311 ns/iter (± 453950) 52653995 ns/iter (± 720111) 1.00
es/full/minify/libraries/react 19063414 ns/iter (± 229306) 18944406 ns/iter (± 199220) 1.01
es/full/minify/libraries/terser 248038178 ns/iter (± 2669174) 247971774 ns/iter (± 4467829) 1.00
es/full/minify/libraries/three 450875226 ns/iter (± 6626652) 438700015 ns/iter (± 9565343) 1.03
es/full/minify/libraries/typescript 3198913127 ns/iter (± 24196575) 3294384297 ns/iter (± 50601127) 0.97
es/full/minify/libraries/victory 671724300 ns/iter (± 12400795) 688385101 ns/iter (± 28418946) 0.98
es/full/minify/libraries/vue 131596426 ns/iter (± 838995) 130558804 ns/iter (± 4246498) 1.01
es/full/codegen/es3 27363 ns/iter (± 58) 25387 ns/iter (± 338) 1.08
es/full/codegen/es5 27351 ns/iter (± 136) 25587 ns/iter (± 267) 1.07
es/full/codegen/es2015 27342 ns/iter (± 92) 25592 ns/iter (± 256) 1.07
es/full/codegen/es2016 27373 ns/iter (± 38) 25394 ns/iter (± 391) 1.08
es/full/codegen/es2017 27386 ns/iter (± 58) 25438 ns/iter (± 295) 1.08
es/full/codegen/es2018 27412 ns/iter (± 33) 25665 ns/iter (± 271) 1.07
es/full/codegen/es2019 27342 ns/iter (± 88) 25344 ns/iter (± 257) 1.08
es/full/codegen/es2020 27452 ns/iter (± 57) 25726 ns/iter (± 355) 1.07
es/full/all/es3 169707394 ns/iter (± 2685196) 173557301 ns/iter (± 3874743) 0.98
es/full/all/es5 161548358 ns/iter (± 3543630) 164448464 ns/iter (± 2734122) 0.98
es/full/all/es2015 123329433 ns/iter (± 2016676) 126554106 ns/iter (± 2570925) 0.97
es/full/all/es2016 122479689 ns/iter (± 1366717) 121286515 ns/iter (± 1588623) 1.01
es/full/all/es2017 122194500 ns/iter (± 1426222) 122397455 ns/iter (± 2889402) 1.00
es/full/all/es2018 119659717 ns/iter (± 1129749) 119095203 ns/iter (± 8258203) 1.00
es/full/all/es2019 118670032 ns/iter (± 1335757) 119102318 ns/iter (± 1317137) 1.00
es/full/all/es2020 114515771 ns/iter (± 1063568) 115334244 ns/iter (± 1175799) 0.99
es/full/parser 537954 ns/iter (± 8725) 506479 ns/iter (± 8038) 1.06
es/full/base/fixer 22260 ns/iter (± 30) 21689 ns/iter (± 358) 1.03
es/full/base/resolver_and_hygiene 81923 ns/iter (± 203) 79180 ns/iter (± 530) 1.03
serialization of ast node 123 ns/iter (± 0) 120 ns/iter (± 1) 1.02
serialization of serde 128 ns/iter (± 0) 126 ns/iter (± 1) 1.02
css/minify/libraries/bootstrap 27841640 ns/iter (± 94939) 26934820 ns/iter (± 486441) 1.03
css/visitor/compare/clone 2054002 ns/iter (± 28981) 2025170 ns/iter (± 37818) 1.01
css/visitor/compare/visit_mut_span 2275403 ns/iter (± 2765) 2228127 ns/iter (± 20882) 1.02
css/visitor/compare/visit_mut_span_panic 2349296 ns/iter (± 4382) 2268264 ns/iter (± 22137) 1.04
css/visitor/compare/fold_span 3053423 ns/iter (± 17119) 2997378 ns/iter (± 17230) 1.02
css/visitor/compare/fold_span_panic 3183563 ns/iter (± 18085) 3100346 ns/iter (± 35224) 1.03
css/lexer/bootstrap_5_1_3 5180992 ns/iter (± 9444) 5084822 ns/iter (± 67418) 1.02
css/lexer/foundation_6_7_4 4356737 ns/iter (± 4567) 4197887 ns/iter (± 56645) 1.04
css/lexer/tailwind_3_1_1 830684 ns/iter (± 1368) 810165 ns/iter (± 8193) 1.03
css/parser/bootstrap_5_1_3 21646783 ns/iter (± 36807) 21435748 ns/iter (± 402231) 1.01
css/parser/foundation_6_7_4 17289750 ns/iter (± 11128) 17460049 ns/iter (± 336109) 0.99
css/parser/tailwind_3_1_1 3297235 ns/iter (± 4381) 3242323 ns/iter (± 47806) 1.02
es/codegen/colors 331487 ns/iter (± 187975) 329806 ns/iter (± 181757) 1.01
es/codegen/large 1229720 ns/iter (± 632488) 1191185 ns/iter (± 608162) 1.03
es/codegen/with-parser/colors 48088 ns/iter (± 437) 47502 ns/iter (± 664) 1.01
es/codegen/with-parser/large 533616 ns/iter (± 1225) 529077 ns/iter (± 5952) 1.01
es/minify/libraries/antd 1468761204 ns/iter (± 27205943) 1469660236 ns/iter (± 23558695) 1.00
es/minify/libraries/d3 254234431 ns/iter (± 3019081) 245609158 ns/iter (± 3359068) 1.04
es/minify/libraries/echarts 1089018001 ns/iter (± 19758369) 1058802832 ns/iter (± 19770548) 1.03
es/minify/libraries/jquery 77852392 ns/iter (± 613558) 76634577 ns/iter (± 961943) 1.02
es/minify/libraries/lodash 94462267 ns/iter (± 715274) 93919519 ns/iter (± 2981552) 1.01
es/minify/libraries/moment 45950338 ns/iter (± 492956) 44507278 ns/iter (± 507888) 1.03
es/minify/libraries/react 16858849 ns/iter (± 138119) 16911862 ns/iter (± 163055) 1.00
es/minify/libraries/terser 208996160 ns/iter (± 1992209) 203803629 ns/iter (± 5225782) 1.03
es/minify/libraries/three 370223032 ns/iter (± 9560085) 347581502 ns/iter (± 13127418) 1.07
es/minify/libraries/typescript 2757586652 ns/iter (± 37716099) 2680942583 ns/iter (± 34677155) 1.03
es/minify/libraries/victory 570390727 ns/iter (± 8690164) 530398427 ns/iter (± 17047190) 1.08
es/minify/libraries/vue 116399739 ns/iter (± 807691) 112345487 ns/iter (± 1581696) 1.04
es/visitor/compare/clone 2422743 ns/iter (± 19393) 2321600 ns/iter (± 49925) 1.04
es/visitor/compare/visit_mut_span 2784788 ns/iter (± 5343) 2739097 ns/iter (± 31788) 1.02
es/visitor/compare/visit_mut_span_panic 2826171 ns/iter (± 7358) 2749532 ns/iter (± 21705) 1.03
es/visitor/compare/fold_span 3964177 ns/iter (± 9885) 3887149 ns/iter (± 24054) 1.02
es/visitor/compare/fold_span_panic 4072387 ns/iter (± 7009) 3932051 ns/iter (± 44548) 1.04
es/lexer/colors 17318 ns/iter (± 12) 16895 ns/iter (± 191) 1.03
es/lexer/angular 8256323 ns/iter (± 16707) 8022293 ns/iter (± 73519) 1.03
es/lexer/backbone 1081371 ns/iter (± 2443) 1042470 ns/iter (± 5671) 1.04
es/lexer/jquery 5981882 ns/iter (± 6717) 5762516 ns/iter (± 21386) 1.04
es/lexer/jquery mobile 9210715 ns/iter (± 7352) 8905806 ns/iter (± 72796) 1.03
es/lexer/mootools 4687579 ns/iter (± 3410) 4591726 ns/iter (± 63175) 1.02
es/lexer/underscore 902677 ns/iter (± 574) 871984 ns/iter (± 6808) 1.04
es/lexer/three 27915878 ns/iter (± 23724) 26981108 ns/iter (± 141881) 1.03
es/lexer/yui 5078760 ns/iter (± 6611) 4857036 ns/iter (± 31178) 1.05
es/parser/colors 31007 ns/iter (± 148) 30331 ns/iter (± 407) 1.02
es/parser/angular 15869601 ns/iter (± 115194) 15314604 ns/iter (± 287899) 1.04
es/parser/backbone 2315506 ns/iter (± 18851) 2271937 ns/iter (± 22013) 1.02
es/parser/jquery 12476288 ns/iter (± 77328) 12095509 ns/iter (± 139639) 1.03
es/parser/jquery mobile 19605331 ns/iter (± 346967) 19025224 ns/iter (± 434721) 1.03
es/parser/mootools 9553925 ns/iter (± 23234) 9188849 ns/iter (± 66999) 1.04
es/parser/underscore 1949411 ns/iter (± 11783) 1902608 ns/iter (± 23214) 1.02
es/parser/three 57367869 ns/iter (± 788922) 54235411 ns/iter (± 1170798) 1.06
es/parser/yui 9618576 ns/iter (± 63492) 9369399 ns/iter (± 99691) 1.03
es/preset-env/usage/builtin_type 138004 ns/iter (± 30614) 137262 ns/iter (± 29784) 1.01
es/preset-env/usage/property 20787 ns/iter (± 110) 20440 ns/iter (± 160) 1.02
es/resolver/typescript 127526156 ns/iter (± 4654518) 114658805 ns/iter (± 2111970) 1.11
es/fixer/typescript 96198265 ns/iter (± 2258609) 89944871 ns/iter (± 1320580) 1.07
es/hygiene/typescript 203461579 ns/iter (± 2341014) 189712819 ns/iter (± 3250324) 1.07
es/resolver_with_hygiene/typescript 341354457 ns/iter (± 1620149) 314796153 ns/iter (± 1892978) 1.08
es/visitor/base-perf/module_clone 75208 ns/iter (± 1444) 73960 ns/iter (± 1464) 1.02
es/visitor/base-perf/fold_empty 85477 ns/iter (± 1099) 82344 ns/iter (± 1711) 1.04
es/visitor/base-perf/fold_noop_impl_all 86631 ns/iter (± 2476) 83221 ns/iter (± 1118) 1.04
es/visitor/base-perf/fold_noop_impl_vec 85887 ns/iter (± 1884) 82936 ns/iter (± 996) 1.04
es/visitor/base-perf/boxing_boxed_clone 81 ns/iter (± 3) 54 ns/iter (± 0) 1.50
es/visitor/base-perf/boxing_unboxed_clone 59 ns/iter (± 0) 57 ns/iter (± 0) 1.04
es/visitor/base-perf/boxing_boxed 105 ns/iter (± 0) 100 ns/iter (± 0) 1.05
es/visitor/base-perf/boxing_unboxed 104 ns/iter (± 0) 101 ns/iter (± 1) 1.03
es/visitor/base-perf/visit_contains_this 3485 ns/iter (± 80) 3416 ns/iter (± 108) 1.02
es/base/parallel/resolver/typescript 5224127626 ns/iter (± 387727239) 5292934283 ns/iter (± 566461797) 0.99
es/base/parallel/hygiene/typescript 2406707823 ns/iter (± 40095249) 2466840938 ns/iter (± 30105969) 0.98
misc/visitors/time-complexity/time 5 101 ns/iter (± 0) 100 ns/iter (± 1) 1.01
misc/visitors/time-complexity/time 10 328 ns/iter (± 11) 316 ns/iter (± 3) 1.04
misc/visitors/time-complexity/time 15 653 ns/iter (± 0) 638 ns/iter (± 6) 1.02
misc/visitors/time-complexity/time 20 1209 ns/iter (± 1) 1204 ns/iter (± 9) 1.00
misc/visitors/time-complexity/time 40 6583 ns/iter (± 7) 6510 ns/iter (± 60) 1.01
misc/visitors/time-complexity/time 60 17064 ns/iter (± 45) 16803 ns/iter (± 182) 1.02
es/full-target/es2016 188522 ns/iter (± 490) 185681 ns/iter (± 2764) 1.02
es/full-target/es2017 183208 ns/iter (± 629) 178824 ns/iter (± 1889) 1.02
es/full-target/es2018 172976 ns/iter (± 508) 168552 ns/iter (± 2258) 1.03
es2020_nullish_coalescing 66680 ns/iter (± 102) 64893 ns/iter (± 563) 1.03
es2020_optional_chaining 95925 ns/iter (± 255) 93459 ns/iter (± 1023) 1.03
es2022_class_properties 94034 ns/iter (± 264) 91681 ns/iter (± 1172) 1.03
es2018_object_rest_spread 71151 ns/iter (± 162) 70323 ns/iter (± 424) 1.01
es2019_optional_catch_binding 60909 ns/iter (± 160) 60455 ns/iter (± 394) 1.01
es2017_async_to_generator 61460 ns/iter (± 110) 60982 ns/iter (± 763) 1.01
es2016_exponentiation 64794 ns/iter (± 139) 63542 ns/iter (± 904) 1.02
es2015_arrow 69956 ns/iter (± 246) 68769 ns/iter (± 751) 1.02
es2015_block_scoped_fn 66126 ns/iter (± 165) 65401 ns/iter (± 770) 1.01
es2015_block_scoping 154923 ns/iter (± 9091) 137352 ns/iter (± 7823) 1.13
es2015_classes 117051 ns/iter (± 582) 114605 ns/iter (± 797) 1.02
es2015_computed_props 61085 ns/iter (± 87) 59809 ns/iter (± 777) 1.02
es2015_destructuring 115934 ns/iter (± 307) 114114 ns/iter (± 1388) 1.02
es2015_duplicate_keys 63574 ns/iter (± 87) 63246 ns/iter (± 556) 1.01
es2015_parameters 79014 ns/iter (± 181) 76933 ns/iter (± 684) 1.03
es2015_fn_name 66737 ns/iter (± 407) 64133 ns/iter (± 1362) 1.04
es2015_for_of 64041 ns/iter (± 77) 63610 ns/iter (± 261) 1.01
es2015_instanceof 63005 ns/iter (± 128) 61024 ns/iter (± 537) 1.03
es2015_shorthand_property 60982 ns/iter (± 108) 60240 ns/iter (± 405) 1.01
es2015_spread 60613 ns/iter (± 149) 59785 ns/iter (± 720) 1.01
es2015_sticky_regex 61856 ns/iter (± 138) 60280 ns/iter (± 527) 1.03
es2015_typeof_symbol 62117 ns/iter (± 76) 61718 ns/iter (± 591) 1.01
es/transform/baseline/base 51674 ns/iter (± 105) 50742 ns/iter (± 780) 1.02
es/transform/baseline/common_reserved_word 62460 ns/iter (± 62) 60974 ns/iter (± 675) 1.02
es/transform/baseline/common_typescript 150294 ns/iter (± 11080) 146320 ns/iter (± 4399) 1.03
es/target/es3 169588 ns/iter (± 403) 166752 ns/iter (± 1486) 1.02
es/target/es2015 627872 ns/iter (± 1367) 606850 ns/iter (± 4508) 1.03
es/target/es2016 65116 ns/iter (± 156) 63566 ns/iter (± 878) 1.02
es/target/es2017 61547 ns/iter (± 142) 60983 ns/iter (± 517) 1.01
es/target/es2018 81400 ns/iter (± 145) 78906 ns/iter (± 810) 1.03
es/target/es2020 133273 ns/iter (± 251) 129185 ns/iter (± 1090) 1.03
babelify-only 667634 ns/iter (± 2151) 668732 ns/iter (± 5944) 1.00
parse_and_babelify_angular 42866050 ns/iter (± 718283) 44269976 ns/iter (± 876050) 0.97
parse_and_babelify_backbone 5377794 ns/iter (± 29382) 5479843 ns/iter (± 163345) 0.98
parse_and_babelify_jquery 32335485 ns/iter (± 418328) 32648529 ns/iter (± 705485) 0.99
parse_and_babelify_jquery_mobile 56026309 ns/iter (± 893172) 56821381 ns/iter (± 1253676) 0.99
parse_and_babelify_mootools 33338465 ns/iter (± 167468) 33384434 ns/iter (± 1067324) 1.00
parse_and_babelify_underscore 4369637 ns/iter (± 21741) 4382868 ns/iter (± 49531) 1.00
parse_and_babelify_yui 32385932 ns/iter (± 394315) 33177181 ns/iter (± 523564) 0.98
html/minify/document/css_spec 41400161 ns/iter (± 325872) 41737632 ns/iter (± 688160) 0.99
html/minify/document/github 17549855 ns/iter (± 36764) 17562150 ns/iter (± 147799) 1.00
html/minify/document/stackoverflow 15664986 ns/iter (± 12630) 15689473 ns/iter (± 197257) 1.00
html/minify/document_fragment/css_spec 39826789 ns/iter (± 353545) 40342430 ns/iter (± 393025) 0.99
html/minify/document_fragment/github 16761363 ns/iter (± 25070) 16891905 ns/iter (± 164388) 0.99
html/minify/document_fragment/stackoverflow 15362507 ns/iter (± 34037) 15210636 ns/iter (± 122039) 1.01
html/document/visitor/compare/clone 344338 ns/iter (± 1710) 329569 ns/iter (± 4565) 1.04
html/document/visitor/compare/visit_mut_span 364044 ns/iter (± 1243) 359185 ns/iter (± 5455) 1.01
html/document/visitor/compare/visit_mut_span_panic 374667 ns/iter (± 2146) 376137 ns/iter (± 2207) 1.00
html/document/visitor/compare/fold_span 402769 ns/iter (± 2252) 406073 ns/iter (± 2358) 0.99
html/document/visitor/compare/fold_span_panic 458974 ns/iter (± 1721) 458582 ns/iter (± 2024) 1.00
html/document_fragment/visitor/compare/clone 337015 ns/iter (± 2600) 337113 ns/iter (± 2860) 1.00
html/document_fragment/visitor/compare/visit_mut_span 370300 ns/iter (± 1629) 361684 ns/iter (± 3938) 1.02
html/document_fragment/visitor/compare/visit_mut_span_panic 373925 ns/iter (± 1526) 374706 ns/iter (± 2344) 1.00
html/document_fragment/visitor/compare/fold_span 404701 ns/iter (± 1826) 401352 ns/iter (± 1408) 1.01
html/document_fragment/visitor/compare/fold_span_panic 456100 ns/iter (± 2023) 455177 ns/iter (± 2426) 1.00
html/lexer/css_2021_spec 15522367 ns/iter (± 14053) 17157902 ns/iter (± 88814) 0.90
html/lexer/github_com_17_05_2022 6017588 ns/iter (± 7041) 6397472 ns/iter (± 31849) 0.94
html/lexer/stackoverflow_com_17_05_2022 5626799 ns/iter (± 7415) 6217816 ns/iter (± 41561) 0.90
html/parser/parser_document/css_2021_spec 25541570 ns/iter (± 310657) 25164979 ns/iter (± 248910) 1.01
html/parser/parser_document/github_com_17_05_2022 8750819 ns/iter (± 20475) 8627467 ns/iter (± 66076) 1.01
html/parser/parser_document/stackoverflow_com_17_05_2022 7710530 ns/iter (± 7222) 7585276 ns/iter (± 85724) 1.02
html/parser/parser_document_fragment/css_2021_spec 25595666 ns/iter (± 388670) 24905274 ns/iter (± 519619) 1.03
html/parser/parser_document_fragment/github_com_17_05_2022 8800014 ns/iter (± 11027) 8695037 ns/iter (± 63676) 1.01
html/parser/parser_document_fragment/stackoverflow_com_17_05_2022 7733914 ns/iter (± 15155) 7689856 ns/iter (± 51745) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.