Skip to content

Commit

Permalink
refactor(common): Derive ByteCheck for ArcString (#7380)
Browse files Browse the repository at this point in the history
  • Loading branch information
@kwonoj
kwonoj committed May 12, 2023
1 parent 7655aaa commit 9b3a41c
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions crates/swc_common/src/syntax_pos.rs
View file
Expand Up @@ -836,6 +836,8 @@ impl Sub<BytePos> for NonNarrowChar {
#[doc(hidden)]
#[cfg(feature = "rkyv-impl")]
#[derive(Debug, Clone, Copy)]
#[cfg_attr(feature = "rkyv-impl", derive(rkyv::bytecheck::CheckBytes))]
#[cfg_attr(feature = "rkyv-impl", repr(C))]
pub struct EncodeArcString;

#[cfg(feature = "rkyv-impl")]
Expand Down

1 comment on commit 9b3a41c

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 9b3a41c Previous: 166e77c Ratio
es/full/bugs-1 247365 ns/iter (± 3498) 303305 ns/iter (± 6908) 0.82
es/full/minify/libraries/antd 1188870710 ns/iter (± 13300142) 1586682378 ns/iter (± 55947733) 0.75
es/full/minify/libraries/d3 235675961 ns/iter (± 1729352) 286347207 ns/iter (± 9005415) 0.82
es/full/minify/libraries/echarts 939152531 ns/iter (± 5212308) 1186847859 ns/iter (± 18483369) 0.79
es/full/minify/libraries/jquery 76916355 ns/iter (± 111604) 89556271 ns/iter (± 1174004) 0.86
es/full/minify/libraries/lodash 86228799 ns/iter (± 235761) 104091589 ns/iter (± 1715105) 0.83
es/full/minify/libraries/moment 44860960 ns/iter (± 268699) 51863425 ns/iter (± 536014) 0.86
es/full/minify/libraries/react 16312118 ns/iter (± 13797) 19036973 ns/iter (± 118470) 0.86
es/full/minify/libraries/terser 197506737 ns/iter (± 710219) 238121440 ns/iter (± 2877586) 0.83
es/full/minify/libraries/three 338944195 ns/iter (± 1373729) 421317471 ns/iter (± 10367885) 0.80
es/full/minify/libraries/typescript 2385634286 ns/iter (± 10178795) 3005773480 ns/iter (± 79249719) 0.79
es/full/minify/libraries/victory 495670709 ns/iter (± 1675318) 620321532 ns/iter (± 10670271) 0.80
es/full/minify/libraries/vue 106999657 ns/iter (± 195390) 126954422 ns/iter (± 1403118) 0.84
es/full/codegen/es3 32629 ns/iter (± 46) 33539 ns/iter (± 139) 0.97
es/full/codegen/es5 32732 ns/iter (± 209) 33940 ns/iter (± 76) 0.96
es/full/codegen/es2015 32632 ns/iter (± 60) 33816 ns/iter (± 310) 0.96
es/full/codegen/es2016 32603 ns/iter (± 32) 33629 ns/iter (± 146) 0.97
es/full/codegen/es2017 32660 ns/iter (± 66) 33589 ns/iter (± 328) 0.97
es/full/codegen/es2018 32669 ns/iter (± 90) 33317 ns/iter (± 346) 0.98
es/full/codegen/es2019 32761 ns/iter (± 68) 33579 ns/iter (± 217) 0.98
es/full/codegen/es2020 32614 ns/iter (± 144) 33126 ns/iter (± 183) 0.98
es/full/all/es3 157444104 ns/iter (± 717969) 179931877 ns/iter (± 3037303) 0.88
es/full/all/es5 150184208 ns/iter (± 413623) 171667196 ns/iter (± 2444735) 0.87
es/full/all/es2015 111034240 ns/iter (± 532218) 136733674 ns/iter (± 1657707) 0.81
es/full/all/es2016 110297663 ns/iter (± 460375) 132730568 ns/iter (± 1297677) 0.83
es/full/all/es2017 109946577 ns/iter (± 562489) 131401718 ns/iter (± 2435220) 0.84
es/full/all/es2018 107645800 ns/iter (± 374501) 127602154 ns/iter (± 1541245) 0.84
es/full/all/es2019 106992099 ns/iter (± 562066) 125265551 ns/iter (± 1738782) 0.85
es/full/all/es2020 101889782 ns/iter (± 408400) 118225992 ns/iter (± 780719) 0.86
es/full/parser 458276 ns/iter (± 4688) 510282 ns/iter (± 6625) 0.90
es/full/base/fixer 16958 ns/iter (± 57) 22485 ns/iter (± 178) 0.75
es/full/base/resolver_and_hygiene 74187 ns/iter (± 155) 84852 ns/iter (± 596) 0.87
serialization of serde 113 ns/iter (± 0) 121 ns/iter (± 0) 0.93
css/minify/libraries/bootstrap 23323692 ns/iter (± 21970) 27630054 ns/iter (± 375850) 0.84
css/visitor/compare/clone 1650011 ns/iter (± 8411) 2039909 ns/iter (± 13062) 0.81
css/visitor/compare/visit_mut_span 1770561 ns/iter (± 4013) 2275220 ns/iter (± 17716) 0.78
css/visitor/compare/visit_mut_span_panic 1848886 ns/iter (± 3412) 2349923 ns/iter (± 28490) 0.79
css/visitor/compare/fold_span 2535793 ns/iter (± 8360) 3047107 ns/iter (± 23168) 0.83
css/visitor/compare/fold_span_panic 2717945 ns/iter (± 6794) 3166441 ns/iter (± 33077) 0.86
css/lexer/bootstrap_5_1_3 4538416 ns/iter (± 2966) 5144047 ns/iter (± 51286) 0.88
css/lexer/foundation_6_7_4 3907275 ns/iter (± 1736) 4408607 ns/iter (± 10901) 0.89
css/lexer/tailwind_3_1_1 738080 ns/iter (± 456) 821845 ns/iter (± 8571) 0.90
css/parser/bootstrap_5_1_3 18757783 ns/iter (± 6780) 20398801 ns/iter (± 151028) 0.92
css/parser/foundation_6_7_4 15029483 ns/iter (± 14552) 16263339 ns/iter (± 134943) 0.92
css/parser/tailwind_3_1_1 2878924 ns/iter (± 3005) 3202092 ns/iter (± 6097) 0.90
es/codegen/colors 329925 ns/iter (± 187193) 328268 ns/iter (± 185711) 1.01
es/codegen/large 1344746 ns/iter (± 715634) 1212064 ns/iter (± 628256) 1.11
es/codegen/with-parser/colors 41835 ns/iter (± 404) 47646 ns/iter (± 311) 0.88
es/codegen/with-parser/large 476278 ns/iter (± 478) 514834 ns/iter (± 5103) 0.93
es/minify/libraries/antd 1038959041 ns/iter (± 8873610) 1497495824 ns/iter (± 24696091) 0.69
es/minify/libraries/d3 210085727 ns/iter (± 361398) 255329486 ns/iter (± 6804814) 0.82
es/minify/libraries/echarts 818520590 ns/iter (± 1926497) 1009252555 ns/iter (± 16854751) 0.81
es/minify/libraries/jquery 68433688 ns/iter (± 227838) 80701664 ns/iter (± 1251678) 0.85
es/minify/libraries/lodash 78848672 ns/iter (± 175447) 96106199 ns/iter (± 943886) 0.82
es/minify/libraries/moment 39831620 ns/iter (± 88582) 48369417 ns/iter (± 2127885) 0.82
es/minify/libraries/react 14804869 ns/iter (± 66690) 17083324 ns/iter (± 84393) 0.87
es/minify/libraries/terser 172074132 ns/iter (± 239718) 203294071 ns/iter (± 1925213) 0.85
es/minify/libraries/three 286664866 ns/iter (± 384669) 347679837 ns/iter (± 9976430) 0.82
es/minify/libraries/typescript 2062178200 ns/iter (± 7537404) 2623143219 ns/iter (± 47067436) 0.79
es/minify/libraries/victory 421805032 ns/iter (± 1064791) 588197364 ns/iter (± 15554864) 0.72
es/minify/libraries/vue 97043675 ns/iter (± 148989) 115913276 ns/iter (± 1130704) 0.84
es/visitor/compare/clone 1999276 ns/iter (± 4559) 2339140 ns/iter (± 11605) 0.85
es/visitor/compare/visit_mut_span 2324793 ns/iter (± 2684) 2716747 ns/iter (± 6385) 0.86
es/visitor/compare/visit_mut_span_panic 2373246 ns/iter (± 4905) 2722080 ns/iter (± 23048) 0.87
es/visitor/compare/fold_span 3413871 ns/iter (± 8305) 3742015 ns/iter (± 32148) 0.91
es/visitor/compare/fold_span_panic 3550782 ns/iter (± 8897) 3915362 ns/iter (± 20566) 0.91
es/lexer/colors 11953 ns/iter (± 80) 13067 ns/iter (± 40) 0.91
es/lexer/angular 5668190 ns/iter (± 8027) 6347266 ns/iter (± 6620) 0.89
es/lexer/backbone 727578 ns/iter (± 766) 780525 ns/iter (± 752) 0.93
es/lexer/jquery 4168106 ns/iter (± 3197) 4392754 ns/iter (± 7436) 0.95
es/lexer/jquery mobile 6394159 ns/iter (± 6551) 6827687 ns/iter (± 24472) 0.94
es/lexer/mootools 3292420 ns/iter (± 1876) 3399234 ns/iter (± 29554) 0.97
es/lexer/underscore 602619 ns/iter (± 1755) 638895 ns/iter (± 3297) 0.94
es/lexer/three 19697114 ns/iter (± 64989) 20587228 ns/iter (± 145833) 0.96
es/lexer/yui 3617350 ns/iter (± 4909) 3852552 ns/iter (± 1795) 0.94
es/parser/colors 25841 ns/iter (± 42) 28835 ns/iter (± 297) 0.90
es/parser/angular 12975683 ns/iter (± 48615) 14863636 ns/iter (± 201359) 0.87
es/parser/backbone 1924310 ns/iter (± 6364) 2136987 ns/iter (± 13131) 0.90
es/parser/jquery 10489231 ns/iter (± 63368) 11534935 ns/iter (± 65202) 0.91
es/parser/jquery mobile 16210437 ns/iter (± 43597) 18210594 ns/iter (± 428231) 0.89
es/parser/mootools 8072597 ns/iter (± 21858) 8851244 ns/iter (± 58533) 0.91
es/parser/underscore 1658649 ns/iter (± 9365) 1796995 ns/iter (± 6035) 0.92
es/parser/three 44952327 ns/iter (± 109843) 50992946 ns/iter (± 763544) 0.88
es/parser/yui 8078266 ns/iter (± 22236) 8905501 ns/iter (± 57482) 0.91
es/preset-env/usage/builtin_type 147508 ns/iter (± 40353) 145297 ns/iter (± 35297) 1.02
es/preset-env/usage/property 15349 ns/iter (± 59) 19948 ns/iter (± 339) 0.77
es/resolver/typescript 88346513 ns/iter (± 946876) 114539292 ns/iter (± 1509782) 0.77
es/fixer/typescript 63963510 ns/iter (± 662449) 85776000 ns/iter (± 2641783) 0.75
es/hygiene/typescript 129753651 ns/iter (± 724339) 180704009 ns/iter (± 1517344) 0.72
es/resolver_with_hygiene/typescript 232273234 ns/iter (± 312424) 307117897 ns/iter (± 2459675) 0.76
es/visitor/base-perf/module_clone 58688 ns/iter (± 272) 80360 ns/iter (± 922) 0.73
es/visitor/base-perf/fold_empty 62648 ns/iter (± 347) 88525 ns/iter (± 953) 0.71
es/visitor/base-perf/fold_noop_impl_all 62199 ns/iter (± 266) 89566 ns/iter (± 603) 0.69
es/visitor/base-perf/fold_noop_impl_vec 62273 ns/iter (± 602) 90589 ns/iter (± 406) 0.69
es/visitor/base-perf/boxing_boxed_clone 54 ns/iter (± 0) 55 ns/iter (± 0) 0.98
es/visitor/base-perf/boxing_unboxed_clone 37 ns/iter (± 0) 42 ns/iter (± 0) 0.88
es/visitor/base-perf/boxing_boxed 108 ns/iter (± 0) 101 ns/iter (± 0) 1.07
es/visitor/base-perf/boxing_unboxed 76 ns/iter (± 0) 78 ns/iter (± 0) 0.97
es/visitor/base-perf/visit_empty 0 ns/iter (± 0)
es/visitor/base-perf/visit_contains_this 2659 ns/iter (± 24) 3559 ns/iter (± 57) 0.75
es/base/parallel/resolver/typescript 3890319278 ns/iter (± 244320255) 6132004707 ns/iter (± 458834506) 0.63
es/base/parallel/hygiene/typescript 1418290551 ns/iter (± 16522168) 2176531139 ns/iter (± 62829229) 0.65
misc/visitors/time-complexity/time 5 98 ns/iter (± 2) 100 ns/iter (± 0) 0.98
misc/visitors/time-complexity/time 10 257 ns/iter (± 0) 326 ns/iter (± 4) 0.79
misc/visitors/time-complexity/time 15 507 ns/iter (± 8) 641 ns/iter (± 2) 0.79
misc/visitors/time-complexity/time 20 1089 ns/iter (± 8) 1189 ns/iter (± 4) 0.92
misc/visitors/time-complexity/time 40 3779 ns/iter (± 15) 6533 ns/iter (± 22) 0.58
misc/visitors/time-complexity/time 60 8380 ns/iter (± 455) 16600 ns/iter (± 232) 0.50
es/full-target/es2016 224008 ns/iter (± 430) 250779 ns/iter (± 2803) 0.89
es/full-target/es2017 213469 ns/iter (± 419) 241550 ns/iter (± 902) 0.88
es/full-target/es2018 203253 ns/iter (± 555) 230826 ns/iter (± 2249) 0.88
es2020_nullish_coalescing 68922 ns/iter (± 271) 90463 ns/iter (± 656) 0.76
es2020_optional_chaining 96655 ns/iter (± 251) 119930 ns/iter (± 533) 0.81
es2022_class_properties 115306 ns/iter (± 306) 147122 ns/iter (± 2549) 0.78
es2018_object_rest_spread 73728 ns/iter (± 253) 93518 ns/iter (± 1316) 0.79
es2019_optional_catch_binding 63080 ns/iter (± 159) 83007 ns/iter (± 493) 0.76
es2017_async_to_generator 61761 ns/iter (± 259) 82987 ns/iter (± 851) 0.74
es2016_exponentiation 66621 ns/iter (± 353) 87396 ns/iter (± 442) 0.76
es2015_arrow 70256 ns/iter (± 179) 92038 ns/iter (± 1044) 0.76
es2015_block_scoped_fn 66426 ns/iter (± 216) 88847 ns/iter (± 923) 0.75
es2015_block_scoping 118794 ns/iter (± 524) 164020 ns/iter (± 937) 0.72

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.