Skip to content

Commit 9ceb57b

Browse files
authoredOct 23, 2023
fix(es/compat): Don't add pure annotations to dummy spans (#8172)
**Related issue:** - Closes #8155. - Closes #8173.
1 parent 7747dbd commit 9ceb57b

File tree

41 files changed

+1960
-25
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+1960
-25
lines changed
 

‎crates/jsdoc/tests/fixture.rs

+2
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,8 @@ impl Comments for SwcComments {
141141
}
142142

143143
fn add_pure_comment(&self, pos: BytePos) {
144+
assert_ne!(pos, BytePos(0), "cannot add pure comment to zero position");
145+
144146
let mut leading = self.leading.entry(pos).or_default();
145147
let pure_comment = Comment {
146148
kind: CommentKind::Block,
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
{
2+
"jsc": {
3+
"parser": {
4+
"syntax": "typescript",
5+
"decorators": true,
6+
"tsx": false
7+
},
8+
"transform": {
9+
"legacyDecorator": true
10+
},
11+
"target": "es5",
12+
// "loose": false,
13+
"minify": {
14+
"compress": false,
15+
"mangle": false
16+
},
17+
"loose": false
18+
},
19+
"module": {
20+
"type": "es6"
21+
},
22+
"minify": false,
23+
"isModule": true
24+
}

1 commit comments

Comments
 (1)

github-actions[bot] commented on Oct 23, 2023

@github-actions[bot]

Benchmark

Benchmark suite Current: 9ceb57b Previous: c26a225 Ratio
es/full/bugs-1 297970 ns/iter (± 7243) 297591 ns/iter (± 15876) 1.00
es/full/minify/libraries/antd 1427398240 ns/iter (± 16026126) 1418868535 ns/iter (± 19210989) 1.01
es/full/minify/libraries/d3 296284197 ns/iter (± 5188108) 293681257 ns/iter (± 947857) 1.01
es/full/minify/libraries/echarts 1142581354 ns/iter (± 18205769) 1125468958 ns/iter (± 9821259) 1.02
es/full/minify/libraries/jquery 89644058 ns/iter (± 238689) 89100441 ns/iter (± 364942) 1.01
es/full/minify/libraries/lodash 105349051 ns/iter (± 923866) 105560679 ns/iter (± 366341) 1.00
es/full/minify/libraries/moment 52882032 ns/iter (± 278327) 52471867 ns/iter (± 79387) 1.01
es/full/minify/libraries/react 19108447 ns/iter (± 639183) 18905262 ns/iter (± 187544) 1.01
es/full/minify/libraries/terser 233008526 ns/iter (± 1725639) 233453084 ns/iter (± 2025616) 1.00
es/full/minify/libraries/three 419360918 ns/iter (± 8984638) 414839760 ns/iter (± 2630087) 1.01
es/full/minify/libraries/typescript 2839524316 ns/iter (± 9903501) 2813695612 ns/iter (± 10647686) 1.01
es/full/minify/libraries/victory 627274999 ns/iter (± 11036912) 609167287 ns/iter (± 11730707) 1.03
es/full/minify/libraries/vue 127432693 ns/iter (± 243308) 127190271 ns/iter (± 496240) 1.00
es/full/codegen/es3 35188 ns/iter (± 409) 33369 ns/iter (± 75) 1.05
es/full/codegen/es5 35176 ns/iter (± 120) 33389 ns/iter (± 281) 1.05
es/full/codegen/es2015 35176 ns/iter (± 66) 33319 ns/iter (± 90) 1.06
es/full/codegen/es2016 35165 ns/iter (± 74) 33329 ns/iter (± 102) 1.06
es/full/codegen/es2017 35137 ns/iter (± 35) 33341 ns/iter (± 113) 1.05
es/full/codegen/es2018 35141 ns/iter (± 57) 33447 ns/iter (± 128) 1.05
es/full/codegen/es2019 35278 ns/iter (± 67) 33332 ns/iter (± 53) 1.06
es/full/codegen/es2020 35276 ns/iter (± 53) 33385 ns/iter (± 89) 1.06
es/full/all/es3 179778422 ns/iter (± 1090071) 176851152 ns/iter (± 1655263) 1.02
es/full/all/es5 172410368 ns/iter (± 1024060) 170574306 ns/iter (± 1166089) 1.01
es/full/all/es2015 130018732 ns/iter (± 1057600) 129207422 ns/iter (± 1533857) 1.01
es/full/all/es2016 128708929 ns/iter (± 1945213) 128333484 ns/iter (± 923435) 1.00
es/full/all/es2017 128164224 ns/iter (± 540931) 127794822 ns/iter (± 1129992) 1.00
es/full/all/es2018 126167606 ns/iter (± 835959) 125382985 ns/iter (± 698973) 1.01
es/full/all/es2019 125274437 ns/iter (± 803543) 125013938 ns/iter (± 1202019) 1.00
es/full/all/es2020 120825084 ns/iter (± 1319743) 121063117 ns/iter (± 1272673) 1.00
es/full/parser 558546 ns/iter (± 3304) 562074 ns/iter (± 3452) 0.99
es/full/base/fixer 19117 ns/iter (± 95) 17785 ns/iter (± 49) 1.07
es/full/base/resolver_and_hygiene 86604 ns/iter (± 129) 82619 ns/iter (± 623) 1.05

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.