Skip to content

Commit

Permalink
fix(bindings/node): Fix loading of spack.config.js (#7105)
Browse files Browse the repository at this point in the history
  • Loading branch information
3axap4eHko committed Mar 21, 2023
1 parent cda09e4 commit a4d1af1
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions node-swc/src/spack.ts
Expand Up @@ -4,12 +4,15 @@ import { Options } from "./types";

export type BundleInput = BundleOptions | BundleOptions[];

export const isLocalFile = /^\.{0,2}\//; // starts with '/' './' '../'

export async function compileBundleOptions(config: BundleInput | string | undefined): Promise<BundleInput> {
const f = config === undefined ? '.' : config;

try {
const file = typeof f === 'string' ? f : path.resolve('spack.config.js');
let configFromFile: BundleInput = require(file);
const filepath = typeof f === 'string' ? f : 'spack.config.js';
const fileModule = isLocalFile.test(filepath) ? path.resolve(filepath) : filepath;
let configFromFile: BundleInput = require(fileModule);
if ((configFromFile as any).default) {
configFromFile = (configFromFile as any).default;
}
Expand Down

1 comment on commit a4d1af1

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: a4d1af1 Previous: dd2b16d Ratio
es/full/bugs-1 303470 ns/iter (± 7193) 307443 ns/iter (± 9786) 0.99
es/full/minify/libraries/antd 1651678293 ns/iter (± 17708860) 1470866369 ns/iter (± 34652128) 1.12
es/full/minify/libraries/d3 304455719 ns/iter (± 5566221) 280955770 ns/iter (± 7674975) 1.08
es/full/minify/libraries/echarts 1276663756 ns/iter (± 23267189) 1111736266 ns/iter (± 13839452) 1.15
es/full/minify/libraries/jquery 91174928 ns/iter (± 2275961) 87055975 ns/iter (± 1011821) 1.05
es/full/minify/libraries/lodash 107189564 ns/iter (± 2280617) 101903413 ns/iter (± 1231863) 1.05
es/full/minify/libraries/moment 53170144 ns/iter (± 562227) 50230504 ns/iter (± 707496) 1.06
es/full/minify/libraries/react 19208651 ns/iter (± 165308) 18610099 ns/iter (± 190542) 1.03
es/full/minify/libraries/terser 248685741 ns/iter (± 4189138) 224776982 ns/iter (± 2991839) 1.11
es/full/minify/libraries/three 453847624 ns/iter (± 6749987) 395822085 ns/iter (± 5321112) 1.15
es/full/minify/libraries/typescript 3100016773 ns/iter (± 23163296) 2770098842 ns/iter (± 21798900) 1.12
es/full/minify/libraries/victory 681186427 ns/iter (± 18649532) 611103211 ns/iter (± 17388349) 1.11
es/full/minify/libraries/vue 130921131 ns/iter (± 1286261) 124318873 ns/iter (± 1424274) 1.05
es/full/codegen/es3 26327 ns/iter (± 53) 25566 ns/iter (± 207) 1.03
es/full/codegen/es5 26360 ns/iter (± 43) 26149 ns/iter (± 176) 1.01
es/full/codegen/es2015 26416 ns/iter (± 63) 25583 ns/iter (± 261) 1.03
es/full/codegen/es2016 26396 ns/iter (± 57) 25676 ns/iter (± 385) 1.03
es/full/codegen/es2017 26409 ns/iter (± 44) 25682 ns/iter (± 259) 1.03
es/full/codegen/es2018 26390 ns/iter (± 35) 25635 ns/iter (± 171) 1.03
es/full/codegen/es2019 26373 ns/iter (± 52) 25591 ns/iter (± 135) 1.03
es/full/codegen/es2020 26393 ns/iter (± 38) 25641 ns/iter (± 175) 1.03
es/full/all/es3 183354316 ns/iter (± 2415405) 180441450 ns/iter (± 2469833) 1.02
es/full/all/es5 175157074 ns/iter (± 1811542) 174753228 ns/iter (± 2559745) 1.00
es/full/all/es2015 139314325 ns/iter (± 1613877) 133867566 ns/iter (± 2749651) 1.04
es/full/all/es2016 135515728 ns/iter (± 2010467) 133030145 ns/iter (± 2537175) 1.02
es/full/all/es2017 135935049 ns/iter (± 1791912) 134304745 ns/iter (± 3005816) 1.01
es/full/all/es2018 130764930 ns/iter (± 2087137) 125950646 ns/iter (± 3092607) 1.04
es/full/all/es2019 129194438 ns/iter (± 1087271) 122134194 ns/iter (± 2282188) 1.06
es/full/all/es2020 121040090 ns/iter (± 1432201) 118978986 ns/iter (± 1702152) 1.02
es/full/parser 540517 ns/iter (± 9713) 515538 ns/iter (± 7660) 1.05
es/full/base/fixer 22591 ns/iter (± 44) 21531 ns/iter (± 220) 1.05
es/full/base/resolver_and_hygiene 85473 ns/iter (± 119) 79779 ns/iter (± 673) 1.07
serialization of ast node 124 ns/iter (± 0) 120 ns/iter (± 1) 1.03
serialization of serde 126 ns/iter (± 0) 124 ns/iter (± 1) 1.02
css/minify/libraries/bootstrap 28804225 ns/iter (± 87483) 27594109 ns/iter (± 307542) 1.04
css/visitor/compare/clone 2101206 ns/iter (± 12009) 2001729 ns/iter (± 20679) 1.05
css/visitor/compare/visit_mut_span 2292566 ns/iter (± 3754) 2205407 ns/iter (± 13840) 1.04
css/visitor/compare/visit_mut_span_panic 2302371 ns/iter (± 2175) 2217063 ns/iter (± 16415) 1.04
css/visitor/compare/fold_span 3040279 ns/iter (± 16611) 2950862 ns/iter (± 26321) 1.03
css/visitor/compare/fold_span_panic 3204036 ns/iter (± 23862) 3069367 ns/iter (± 28015) 1.04
css/lexer/bootstrap_5_1_3 5131055 ns/iter (± 11448) 4979093 ns/iter (± 47933) 1.03
css/lexer/foundation_6_7_4 4320450 ns/iter (± 14963) 4139596 ns/iter (± 25602) 1.04
css/lexer/tailwind_3_1_1 821026 ns/iter (± 492) 800122 ns/iter (± 11085) 1.03
css/parser/bootstrap_5_1_3 21843531 ns/iter (± 115526) 21080609 ns/iter (± 232506) 1.04
css/parser/foundation_6_7_4 17412023 ns/iter (± 22693) 16689904 ns/iter (± 88218) 1.04
css/parser/tailwind_3_1_1 3348339 ns/iter (± 6056) 3216620 ns/iter (± 26357) 1.04
es/codegen/colors 329658 ns/iter (± 183715) 332878 ns/iter (± 193569) 0.99
es/codegen/large 1193593 ns/iter (± 604405) 1114341 ns/iter (± 575434) 1.07
es/codegen/with-parser/colors 47532 ns/iter (± 437) 45735 ns/iter (± 289) 1.04
es/codegen/with-parser/large 521742 ns/iter (± 1152) 504029 ns/iter (± 5403) 1.04
es/minify/libraries/antd 1426137462 ns/iter (± 24055059) 1253417187 ns/iter (± 18862187) 1.14
es/minify/libraries/d3 260591790 ns/iter (± 3304212) 234298829 ns/iter (± 5591657) 1.11
es/minify/libraries/echarts 1092178823 ns/iter (± 16396280) 945961403 ns/iter (± 12085903) 1.15
es/minify/libraries/jquery 78867356 ns/iter (± 637884) 75242470 ns/iter (± 621896) 1.05
es/minify/libraries/lodash 94413206 ns/iter (± 845936) 91401052 ns/iter (± 1800885) 1.03
es/minify/libraries/moment 45723214 ns/iter (± 435743) 43871197 ns/iter (± 262775) 1.04
es/minify/libraries/react 16917448 ns/iter (± 190000) 16665802 ns/iter (± 149064) 1.02
es/minify/libraries/terser 208926719 ns/iter (± 1130193) 194484379 ns/iter (± 2296032) 1.07
es/minify/libraries/three 368643411 ns/iter (± 7785964) 333764172 ns/iter (± 4117807) 1.10
es/minify/libraries/typescript 2634168675 ns/iter (± 19754652) 2351844901 ns/iter (± 45649297) 1.12
es/minify/libraries/victory 576422673 ns/iter (± 12893103) 505203583 ns/iter (± 18092027) 1.14
es/minify/libraries/vue 117490176 ns/iter (± 694122) 111268375 ns/iter (± 1775000) 1.06
es/visitor/compare/clone 2345776 ns/iter (± 14710) 2255418 ns/iter (± 37485) 1.04
es/visitor/compare/visit_mut_span 2744266 ns/iter (± 3773) 2631125 ns/iter (± 15280) 1.04
es/visitor/compare/visit_mut_span_panic 2780619 ns/iter (± 9398) 2659346 ns/iter (± 38927) 1.05
es/visitor/compare/fold_span 3816961 ns/iter (± 5322) 3695253 ns/iter (± 37490) 1.03
es/visitor/compare/fold_span_panic 3995145 ns/iter (± 6340) 3781202 ns/iter (± 20117) 1.06
es/lexer/colors 15261 ns/iter (± 17) 14889 ns/iter (± 186) 1.02
es/lexer/angular 7364338 ns/iter (± 4944) 7251572 ns/iter (± 66156) 1.02
es/lexer/backbone 979975 ns/iter (± 1196) 962310 ns/iter (± 8885) 1.02
es/lexer/jquery 5531690 ns/iter (± 8120) 5435026 ns/iter (± 50799) 1.02
es/lexer/jquery mobile 8467388 ns/iter (± 6607) 8282827 ns/iter (± 46601) 1.02
es/lexer/mootools 4369780 ns/iter (± 6518) 4382019 ns/iter (± 49418) 1.00
es/lexer/underscore 824950 ns/iter (± 422) 821983 ns/iter (± 9627) 1.00
es/lexer/three 25924683 ns/iter (± 25646) 25284724 ns/iter (± 288588) 1.03
es/lexer/yui 4626997 ns/iter (± 2680) 4547454 ns/iter (± 33988) 1.02
es/parser/colors 29984 ns/iter (± 31) 29093 ns/iter (± 171) 1.03
es/parser/angular 15488282 ns/iter (± 141098) 14700180 ns/iter (± 86064) 1.05
es/parser/backbone 2224081 ns/iter (± 12734) 2164461 ns/iter (± 20285) 1.03
es/parser/jquery 12098025 ns/iter (± 110914) 11749718 ns/iter (± 125061) 1.03
es/parser/jquery mobile 19268258 ns/iter (± 182229) 18296237 ns/iter (± 177457) 1.05
es/parser/mootools 9204671 ns/iter (± 25894) 9014547 ns/iter (± 56477) 1.02
es/parser/underscore 1881896 ns/iter (± 10391) 1838704 ns/iter (± 11715) 1.02
es/parser/three 56580771 ns/iter (± 856708) 53122825 ns/iter (± 1503004) 1.07
es/parser/yui 9388140 ns/iter (± 82584) 9009097 ns/iter (± 143037) 1.04
es/preset-env/usage/builtin_type 139378 ns/iter (± 32587) 138664 ns/iter (± 32694) 1.01
es/preset-env/usage/property 21271 ns/iter (± 82) 20359 ns/iter (± 149) 1.04
es/resolver/typescript 122735175 ns/iter (± 2436488) 106839042 ns/iter (± 3311653) 1.15
es/fixer/typescript 88136132 ns/iter (± 1623675) 74070635 ns/iter (± 1373314) 1.19
es/hygiene/typescript 180775018 ns/iter (± 1790740) 164611794 ns/iter (± 1752878) 1.10
es/resolver_with_hygiene/typescript 327949430 ns/iter (± 3727742) 305017625 ns/iter (± 1544994) 1.08
es/visitor/base-perf/module_clone 79142 ns/iter (± 1234) 79231 ns/iter (± 1827) 1.00
es/visitor/base-perf/fold_empty 90654 ns/iter (± 1048) 88017 ns/iter (± 1108) 1.03
es/visitor/base-perf/fold_noop_impl_all 90560 ns/iter (± 1368) 89208 ns/iter (± 1636) 1.02
es/visitor/base-perf/fold_noop_impl_vec 91501 ns/iter (± 1398) 90042 ns/iter (± 1325) 1.02
es/visitor/base-perf/boxing_boxed_clone 57 ns/iter (± 0) 56 ns/iter (± 0) 1.02
es/visitor/base-perf/boxing_unboxed_clone 54 ns/iter (± 0) 53 ns/iter (± 0) 1.02
es/visitor/base-perf/boxing_boxed 103 ns/iter (± 0) 100 ns/iter (± 1) 1.03
es/visitor/base-perf/boxing_unboxed 106 ns/iter (± 0) 101 ns/iter (± 0) 1.05
es/visitor/base-perf/visit_contains_this 3481 ns/iter (± 55) 3413 ns/iter (± 55) 1.02
es/base/parallel/resolver/typescript 6289909444 ns/iter (± 231840345) 6461201986 ns/iter (± 390871325) 0.97
es/base/parallel/hygiene/typescript 2155693156 ns/iter (± 22523292) 1958361121 ns/iter (± 35037924) 1.10
misc/visitors/time-complexity/time 5 100 ns/iter (± 0) 94 ns/iter (± 0) 1.06
misc/visitors/time-complexity/time 10 365 ns/iter (± 8) 310 ns/iter (± 2) 1.18
misc/visitors/time-complexity/time 15 694 ns/iter (± 0) 644 ns/iter (± 4) 1.08
misc/visitors/time-complexity/time 20 1281 ns/iter (± 1) 1229 ns/iter (± 27) 1.04
misc/visitors/time-complexity/time 40 6773 ns/iter (± 4) 6554 ns/iter (± 82) 1.03
misc/visitors/time-complexity/time 60 17300 ns/iter (± 45) 16677 ns/iter (± 174) 1.04
es/full-target/es2016 250388 ns/iter (± 494) 243645 ns/iter (± 1406) 1.03
es/full-target/es2017 242846 ns/iter (± 323) 236767 ns/iter (± 2682) 1.03
es/full-target/es2018 231904 ns/iter (± 380) 221063 ns/iter (± 1532) 1.05
es2020_nullish_coalescing 92124 ns/iter (± 239) 87476 ns/iter (± 537) 1.05
es2020_optional_chaining 124895 ns/iter (± 518) 119729 ns/iter (± 1324) 1.04
es2022_class_properties 147585 ns/iter (± 313) 141873 ns/iter (± 1693) 1.04
es2018_object_rest_spread 95578 ns/iter (± 240) 92191 ns/iter (± 806) 1.04
es2019_optional_catch_binding 85158 ns/iter (± 150) 81093 ns/iter (± 453) 1.05
es2017_async_to_generator 85793 ns/iter (± 204) 81827 ns/iter (± 678) 1.05
es2016_exponentiation 87724 ns/iter (± 245) 85497 ns/iter (± 708) 1.03
es2015_arrow 91786 ns/iter (± 228) 89875 ns/iter (± 647) 1.02
es2015_block_scoped_fn 90202 ns/iter (± 308) 87573 ns/iter (± 722) 1.03
es2015_block_scoping 165246 ns/iter (± 295) 163899 ns/iter (± 1536) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.