feat(plugin/runner): Update wasmer to v4 (#7576)

Author: kwonoj

Cargo.lock

@@ -40,13 +40,14 @@ swc_ecma_transforms = { optional = true, version = "0.220.18", path = "../swc_ec
 swc_ecma_visit      = { optional = true, version = "0.92.5", path = "../swc_ecma_visit" }
 
 # Optional deps for the wasm binding macro
-anyhow = { optional = true, version = "1.0.71" }
+anyhow                   = { optional = true, version = "1.0.71" }
 console_error_panic_hook = { optional = true, version = "0.1.7" }
-js-sys = { optional = true, version = "0.3.59" }
-once_cell = { optional = true, version = "1.18.0" }
-serde = { optional = true, version = "1", features = ["derive"] }
-serde-wasm-bindgen = { optional = true, version = "0.4.5" }
-wasm-bindgen = { optional = true, version = "0.2.87", features = [
+js-sys                   = { optional = true, version = "0.3.59" }
+once_cell                = { optional = true, version = "1.18.0" }
+serde                    = { optional = true, version = "1", features = ["derive"] }
+serde-wasm-bindgen       = { optional = true, version = "0.4.5" }
+# https://github.com/wasmerio/wasmer/blob/77898a7767eb7057834fdc1a80b239e6b68cf44e/lib/wasix/Cargo.toml#L92
+wasm-bindgen = { optional = true, version = "=0.2.84", features = [
   "enable-interning",
 ] }
-wasm-bindgen-futures = { optional = true, version = "0.4.37" }
+wasm-bindgen-futures = { optional = true, version = "=0.4.34" }

crates/binding_macros/Cargo.toml

@@ -51,14 +51,15 @@ rkyv-impl = ["__rkyv", "swc_common/plugin-rt", "swc_plugin_proxy/plugin-rt"]
 [dependencies]
 anyhow       = "1.0.71"
 enumset      = "1.1.2"
+futures      = { version = "0.3" }
 once_cell    = "1.18.0"
 parking_lot  = "0.12.1"
 serde        = { version = "1.0.126", features = ["derive"] }
 serde_json   = "1.0.64"
 tokio        = { version = "1", default-features = false, optional = true }
 tracing      = "0.1.37"
-wasmer       = { version = "3.3.0", default-features = false }
-wasmer-wasix = { version = "0.4.0", default-features = false }
+wasmer       = { version = "4.0.0", default-features = false }
+wasmer-wasix = { version = "0.9.0", default-features = false }
 
 swc_common = { version = "0.31.16", path = "../swc_common", features = [
   "concurrent",
@@ -68,8 +69,8 @@ swc_ecma_ast = { version = "0.106.6", path = "../swc_ecma_ast", optional = true
 swc_plugin_proxy = { version = "0.35.5", path = "../swc_plugin_proxy" }
 
 [target.'cfg(not(target_arch = "wasm32"))'.dependencies]
-wasmer-cache              = { version = "3.3.0", optional = true }
-wasmer-compiler-cranelift = { version = "3.3.0", default-features = false }
+wasmer-cache              = { version = "4.0.0", optional = true }
+wasmer-compiler-cranelift = { version = "4.0.0", default-features = false }
 
 [dev-dependencies]
 criterion = "0.5"

crates/swc_plugin_runner/Cargo.toml

@@ -31,7 +31,7 @@ use crate::plugin_module_bytes::{
 /// however it is not gauranteed to be compatible across wasmer's
 /// internal changes.
 /// https://github.com/wasmerio/wasmer/issues/2781
-const MODULE_SERIALIZATION_VERSION: &str = "v6";
+const MODULE_SERIALIZATION_VERSION: &str = "v7";
 
 #[derive(Default)]
 pub struct PluginModuleCacheInner {

crates/swc_plugin_runner/src/cache.rs

@@ -27,7 +27,7 @@ pub fn create_plugin_transform_executor(
     metadata_context: &Arc<TransformPluginMetadataContext>,
     plugin_module: Box<dyn PluginModuleBytes>,
     plugin_config: Option<serde_json::Value>,
-    runtime: Option<Arc<dyn wasmer_wasix::WasiRuntime + Send + Sync>>,
+    runtime: Option<Arc<dyn wasmer_wasix::Runtime + Send + Sync>>,
 ) -> TransformExecutor {
     TransformExecutor::new(
         plugin_module,

crates/swc_plugin_runner/src/lib.rs

@@ -14,9 +14,8 @@ use swc_common::{
     SourceMap,
 };
 use wasmer::{AsStoreMut, FunctionEnv, Instance, Store, TypedFunction};
-use wasmer_wasix::{default_fs_backing, is_wasi_module, WasiEnv, WasiFunctionEnv, WasiRuntime};
+use wasmer_wasix::{default_fs_backing, is_wasi_module, Runtime, WasiEnv, WasiFunctionEnv};
 
-use crate::plugin_module_bytes::PluginModuleBytes;
 #[cfg(feature = "__rkyv")]
 use crate::{
     host_environment::BaseHostEnvironment,
@@ -28,6 +27,7 @@ use crate::{
     },
     memory_interop::write_into_memory_view,
 };
+use crate::{plugin_module_bytes::PluginModuleBytes, wasix_runtime::build_wasi_runtime};
 
 /// An internal state to the plugin transform.
 struct PluginTransformState {
@@ -173,7 +173,7 @@ pub struct TransformExecutor {
     metadata_context: Arc<TransformPluginMetadataContext>,
     plugin_config: Option<serde_json::Value>,
     module_bytes: Box<dyn PluginModuleBytes>,
-    runtime: Option<Arc<dyn WasiRuntime + Send + Sync>>,
+    runtime: Option<Arc<dyn Runtime + Send + Sync>>,
 }
 
 #[cfg(feature = "__rkyv")]
@@ -188,8 +188,17 @@ impl TransformExecutor {
         unresolved_mark: &swc_common::Mark,
         metadata_context: &Arc<TransformPluginMetadataContext>,
         plugin_config: Option<serde_json::Value>,
-        runtime: Option<Arc<dyn WasiRuntime + Send + Sync>>,
+        runtime: Option<Arc<dyn Runtime + Send + Sync>>,
     ) -> Self {
+        let runtime = if runtime.is_some() {
+            runtime
+        } else {
+            // https://github.com/wasmerio/wasmer/issues/4029
+            // prevent to wasienvbuilder invoke default PluggableRuntime::new which causes
+            // unexpected failure
+            build_wasi_runtime(None)
+        };
+
         Self {
             source_map: source_map.clone(),
             unresolved_mark: *unresolved_mark,
@@ -259,11 +268,12 @@ impl TransformExecutor {
         // TODO: wasm host native runtime throws 'Memory should be set on `WasiEnv`
         // first'
         let (instance, wasi_env) = if is_wasi_module(&module) {
-            let mut builder = WasiEnv::builder(self.module_bytes.get_module_name());
-
-            if let Some(runtime) = &self.runtime {
-                builder.set_runtime(runtime.clone());
-            }
+            let builder = WasiEnv::builder(self.module_bytes.get_module_name());
+            let builder = if let Some(runtime) = &self.runtime {
+                builder.runtime(runtime.clone())
+            } else {
+                builder
+            };
 
             // Implicitly enable filesystem access for the wasi plugin to cwd.
             //

crates/swc_plugin_runner/src/transform_executor.rs

@@ -1,6 +1,19 @@
 use std::{path::PathBuf, sync::Arc};
 
-use wasmer_wasix::WasiRuntime;
+use wasmer_wasix::Runtime;
+
+#[derive(Debug)]
+struct StubHttpClient;
+
+impl wasmer_wasix::http::HttpClient for StubHttpClient {
+    fn request(
+        &self,
+        _request: wasmer_wasix::http::HttpRequest,
+    ) -> futures::future::BoxFuture<'_, Result<wasmer_wasix::http::HttpResponse, anyhow::Error>>
+    {
+        unimplemented!()
+    }
+}
 
 /// Construct a runtime for the wasix engine depends on the compilation
 /// features.
@@ -9,36 +22,33 @@ use wasmer_wasix::WasiRuntime;
 /// makes wasix initialization fails due to conflicting runtime. When specified,
 /// instead of using default runtime it'll try to use shared one.
 pub fn build_wasi_runtime(
-    fs_cache_path: Option<PathBuf>,
-) -> Option<Arc<dyn WasiRuntime + Send + Sync>> {
-    #[cfg(not(feature = "plugin_transform_host_native_shared_runtime"))]
-    return None;
-
-    #[cfg(feature = "plugin_transform_host_native_shared_runtime")]
-    {
-        use wasmer_wasix::{
-            runners::Runner, runtime::task_manager::tokio::TokioTaskManager, PluggableRuntime,
-        };
-
-        let tasks = TokioTaskManager::new(tokio::runtime::Handle::current());
-        let mut rt = PluggableRuntime::new(Arc::new(tasks));
-
-        /* [TODO]: wasmer@4
-        #[cfg(all(not(target_arch = "wasm32"), feature = "filesystem_cache"))]
-        let cache = if let Some(fs_cache_path) = fs_cache_path {
-            SharedCache::default().with_fallback(wasmer_cache::FileSystemCache::new(fs_cache_path))
-        } else {
-            SharedCache::default().with_fallback(wasmer_wasix::runtime::module_cache::in_memory())
-        };
-
-        #[cfg(not(feature = "filesystem_cache"))]
-        let cache = SharedCache::default().with_fallback(in_memory());
-         */
-
-        rt.set_engine(Some(wasmer::Engine::default()));
-        //[TODO]: wasmer@4
-        //rt.set_module_cache(cache);
-
-        return Some(Arc::new(rt));
-    }
+    _fs_cache_path: Option<PathBuf>,
+) -> Option<Arc<dyn Runtime + Send + Sync>> {
+    use wasmer_wasix::{
+        runtime::{
+            module_cache::{ModuleCache, SharedCache},
+            package_loader::BuiltinPackageLoader,
+            resolver::MultiSource,
+            task_manager::tokio::TokioTaskManager,
+        },
+        virtual_net, PluggableRuntime,
+    };
+
+    let cache =
+        SharedCache::default().with_fallback(wasmer_wasix::runtime::module_cache::in_memory());
+
+    let dummy_loader = BuiltinPackageLoader::new_with_client(".", Arc::new(StubHttpClient));
+
+    let rt = PluggableRuntime {
+        rt: Arc::new(TokioTaskManager::shared()),
+        networking: Arc::new(virtual_net::UnsupportedVirtualNetworking::default()),
+        engine: Some(wasmer::Engine::default()),
+        tty: None,
+        source: Arc::new(MultiSource::new()),
+        module_cache: Arc::new(cache),
+        http_client: None,
+        package_loader: Arc::new(dummy_loader),
+    };
+
+    Some(Arc::new(rt))
 }