Skip to content

Commit b46a724

Browse files
nissy-devnissy-dev
authoredMar 6, 2023
fix(es/preset-env): Move findLast and findLastIndex to finished proposals (#7012)
·
v1.11.16swc_core@v0.106.1
1 parent 1a368de commit b46a724

File tree

4 files changed

+26
-1
lines changed

4 files changed

+26
-1
lines changed
 

‎crates/swc_ecma_preset_env/src/corejs3/data.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -413,7 +413,8 @@ pub static INSTANCE_PROPERTIES: DataMap<&[&str]> = data_map!(Map {
413413
finally: PROMISE_FINALLY,
414414
find: FIND,
415415
findIndex: ["es.array.find-index"],
416-
findLast: "esnext.array.find-last",
416+
findLast: ["es.array.find-last"],
417+
findLastIndex: ["es.array.find-last-index"],
417418
fixed: ["es.string.fixed"],
418419
flags: ["es.regexp.flags"],
419420
flat: ["es.array.flat", "es.array.unscopables.flat"],

‎crates/swc_ecma_preset_env/tests/fixtures/corejs3/usage-array-find-last/input.mjs

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
const array = [1, 2, 3];
2+
array.findLastIndex();
3+
array.findLast();

‎crates/swc_ecma_preset_env/tests/fixtures/corejs3/usage-array-find-last/options.json

+12
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
{
2+
"presets": [
3+
[
4+
"../../../../lib",
5+
{
6+
"useBuiltIns": "usage",
7+
"corejs": "3.29",
8+
"modules": false
9+
}
10+
]
11+
]
12+
}

‎crates/swc_ecma_preset_env/tests/fixtures/corejs3/usage-array-find-last/output.mjs

+9
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
import "core-js/modules/es.array.find-last-index.js";
2+
import "core-js/modules/es.array.find-last.js";
3+
var array = [
4+
1,
5+
2,
6+
3
7+
];
8+
array.findLastIndex();
9+
array.findLast();

1 commit comments

Comments
 (1)

github-actions[bot] commented on Mar 6, 2023

@github-actions[bot]
github-actions[bot]
on Mar 6, 2023

Benchmark

Benchmark suite Current: b46a724 Previous: 6d6731f Ratio
es/full/bugs-1 301969 ns/iter (± 12506) 304418 ns/iter (± 7378) 0.99
es/full/minify/libraries/antd 1751798235 ns/iter (± 27423284) 1747197057 ns/iter (± 32263671) 1.00
es/full/minify/libraries/d3 313781442 ns/iter (± 7251243) 314834917 ns/iter (± 5076739) 1.00
es/full/minify/libraries/echarts 1343273400 ns/iter (± 17174041) 1354771688 ns/iter (± 7850503) 0.99
es/full/minify/libraries/jquery 94171134 ns/iter (± 857791) 95098714 ns/iter (± 973487) 0.99
es/full/minify/libraries/lodash 108475327 ns/iter (± 1225203) 110468220 ns/iter (± 941969) 0.98
es/full/minify/libraries/moment 54227541 ns/iter (± 532585) 54757764 ns/iter (± 541589) 0.99
es/full/minify/libraries/react 19576127 ns/iter (± 205698) 19592137 ns/iter (± 177123) 1.00
es/full/minify/libraries/terser 257971818 ns/iter (± 4913641) 261399139 ns/iter (± 2935726) 0.99
es/full/minify/libraries/three 468794776 ns/iter (± 9074154) 474656301 ns/iter (± 4142104) 0.99
es/full/minify/libraries/typescript 3273840701 ns/iter (± 17171922) 3323016146 ns/iter (± 14481646) 0.99
es/full/minify/libraries/victory 715907598 ns/iter (± 15540915) 742816486 ns/iter (± 10181749) 0.96
es/full/minify/libraries/vue 134690067 ns/iter (± 1580974) 137743074 ns/iter (± 2649707) 0.98
es/full/codegen/es3 25968 ns/iter (± 42) 26146 ns/iter (± 52) 0.99
es/full/codegen/es5 25926 ns/iter (± 37) 26185 ns/iter (± 68) 0.99
es/full/codegen/es2015 26010 ns/iter (± 40) 26106 ns/iter (± 98) 1.00
es/full/codegen/es2016 25957 ns/iter (± 47) 26156 ns/iter (± 56) 0.99
es/full/codegen/es2017 25932 ns/iter (± 40) 26205 ns/iter (± 68) 0.99
es/full/codegen/es2018 25979 ns/iter (± 49) 26164 ns/iter (± 36) 0.99
es/full/codegen/es2019 25923 ns/iter (± 65) 26132 ns/iter (± 41) 0.99
es/full/codegen/es2020 26000 ns/iter (± 64) 26129 ns/iter (± 40) 1.00
es/full/all/es3 172889002 ns/iter (± 2697826) 171198541 ns/iter (± 1248447) 1.01
es/full/all/es5 165816529 ns/iter (± 3393576) 161330344 ns/iter (± 3657111) 1.03
es/full/all/es2015 130257684 ns/iter (± 1324826) 127105282 ns/iter (± 1405831) 1.02
es/full/all/es2016 126256182 ns/iter (± 1409777) 126171192 ns/iter (± 1037373) 1.00
es/full/all/es2017 125588113 ns/iter (± 1874463) 123827422 ns/iter (± 1178280) 1.01
es/full/all/es2018 121612520 ns/iter (± 1200872) 120701975 ns/iter (± 1171523) 1.01
es/full/all/es2019 120867126 ns/iter (± 474262) 120021587 ns/iter (± 736750) 1.01
es/full/all/es2020 115738719 ns/iter (± 1058748) 115346362 ns/iter (± 937819) 1.00
es/full/parser 549494 ns/iter (± 9269) 549478 ns/iter (± 9162) 1.00
es/full/base/fixer 22174 ns/iter (± 30) 21776 ns/iter (± 57) 1.02
es/full/base/resolver_and_hygiene 82033 ns/iter (± 119) 81446 ns/iter (± 81) 1.01
serialization of ast node 145 ns/iter (± 0) 145 ns/iter (± 0) 1
serialization of serde 134 ns/iter (± 0) 134 ns/iter (± 0) 1
css/minify/libraries/bootstrap 28270713 ns/iter (± 100080) 28326934 ns/iter (± 90048) 1.00
css/visitor/compare/clone 2076503 ns/iter (± 6708) 2061513 ns/iter (± 16482) 1.01
css/visitor/compare/visit_mut_span 2257719 ns/iter (± 5225) 2261599 ns/iter (± 8633) 1.00
css/visitor/compare/visit_mut_span_panic 2306138 ns/iter (± 5252) 2293227 ns/iter (± 3232) 1.01
css/visitor/compare/fold_span 3065510 ns/iter (± 17273) 3009373 ns/iter (± 22216) 1.02
css/visitor/compare/fold_span_panic 3169703 ns/iter (± 17924) 3159189 ns/iter (± 22246) 1.00
css/lexer/bootstrap_5_1_3 5200382 ns/iter (± 4729) 5264355 ns/iter (± 5495) 0.99
css/lexer/foundation_6_7_4 4378127 ns/iter (± 3130) 4434456 ns/iter (± 3846) 0.99
css/lexer/tailwind_3_1_1 832817 ns/iter (± 388) 843556 ns/iter (± 1386) 0.99
css/parser/bootstrap_5_1_3 21699439 ns/iter (± 71074) 21761183 ns/iter (± 57226) 1.00
css/parser/foundation_6_7_4 17317450 ns/iter (± 47883) 17469114 ns/iter (± 95643) 0.99
css/parser/tailwind_3_1_1 3321186 ns/iter (± 3494) 3323210 ns/iter (± 3537) 1.00
es/codegen/colors 327608 ns/iter (± 184706) 331856 ns/iter (± 185164) 0.99
es/codegen/large 1237281 ns/iter (± 639656) 1308533 ns/iter (± 658337) 0.95
es/codegen/with-parser/colors 47537 ns/iter (± 322) 47520 ns/iter (± 67) 1.00
es/codegen/with-parser/large 523945 ns/iter (± 1842) 525467 ns/iter (± 1825) 1.00
es/minify/libraries/antd 1529707732 ns/iter (± 17580393) 1536571916 ns/iter (± 14375462) 1.00
es/minify/libraries/d3 264494012 ns/iter (± 8042598) 268595945 ns/iter (± 5520095) 0.98
es/minify/libraries/echarts 1172131191 ns/iter (± 9081575) 1177397482 ns/iter (± 12370033) 1.00
es/minify/libraries/jquery 81395953 ns/iter (± 917524) 80823288 ns/iter (± 468480) 1.01
es/minify/libraries/lodash 96915309 ns/iter (± 1088833) 96808661 ns/iter (± 831416) 1.00
es/minify/libraries/moment 47228591 ns/iter (± 553359) 47063208 ns/iter (± 226803) 1.00
es/minify/libraries/react 17420447 ns/iter (± 121832) 17333312 ns/iter (± 139256) 1.01
es/minify/libraries/terser 223056445 ns/iter (± 3429455) 220577429 ns/iter (± 2643944) 1.01
es/minify/libraries/three 394298362 ns/iter (± 5811758) 395364420 ns/iter (± 9369158) 1.00
es/minify/libraries/typescript 2797524692 ns/iter (± 20328220) 2826194106 ns/iter (± 8400564) 0.99
es/minify/libraries/victory 611440182 ns/iter (± 7778733) 613390893 ns/iter (± 11872450) 1.00
es/minify/libraries/vue 120578796 ns/iter (± 1235553) 120107882 ns/iter (± 960371) 1.00
es/visitor/compare/clone 2393573 ns/iter (± 18023) 2417937 ns/iter (± 20840) 0.99
es/visitor/compare/visit_mut_span 2745443 ns/iter (± 5191) 2819052 ns/iter (± 5475) 0.97
es/visitor/compare/visit_mut_span_panic 2845713 ns/iter (± 5390) 2860712 ns/iter (± 5993) 0.99
es/visitor/compare/fold_span 3895450 ns/iter (± 13702) 3995515 ns/iter (± 9596) 0.97
es/visitor/compare/fold_span_panic 4062295 ns/iter (± 14958) 4141738 ns/iter (± 6736) 0.98
es/lexer/colors 16397 ns/iter (± 17) 16208 ns/iter (± 63) 1.01
es/lexer/angular 7852002 ns/iter (± 4679) 7781078 ns/iter (± 17966) 1.01
es/lexer/backbone 1014643 ns/iter (± 4156) 1002644 ns/iter (± 650) 1.01
es/lexer/jquery 5631955 ns/iter (± 5400) 5570695 ns/iter (± 3649) 1.01
es/lexer/jquery mobile 8651792 ns/iter (± 9776) 8551298 ns/iter (± 2673) 1.01
es/lexer/mootools 4437116 ns/iter (± 4443) 4384256 ns/iter (± 3291) 1.01
es/lexer/underscore 844841 ns/iter (± 914) 837592 ns/iter (± 454) 1.01
es/lexer/three 26275599 ns/iter (± 35692) 25978667 ns/iter (± 14670) 1.01
es/lexer/yui 4837696 ns/iter (± 7311) 4782757 ns/iter (± 4006) 1.01
es/parser/colors 30627 ns/iter (± 59) 30862 ns/iter (± 101) 0.99
es/parser/angular 15810238 ns/iter (± 132985) 16084485 ns/iter (± 222667) 0.98
es/parser/backbone 2290466 ns/iter (± 12530) 2330801 ns/iter (± 11080) 0.98
es/parser/jquery 12372636 ns/iter (± 153009) 12557067 ns/iter (± 103834) 0.99
es/parser/jquery mobile 19775335 ns/iter (± 314485) 19886076 ns/iter (± 249940) 0.99
es/parser/mootools 9460962 ns/iter (± 30855) 9691892 ns/iter (± 24345) 0.98
es/parser/underscore 1950515 ns/iter (± 13230) 1977040 ns/iter (± 13464) 0.99
es/parser/three 59299201 ns/iter (± 336700) 60331025 ns/iter (± 443528) 0.98
es/parser/yui 9579154 ns/iter (± 68454) 9633110 ns/iter (± 108943) 0.99
es/preset-env/usage/builtin_type 138738 ns/iter (± 30681) 142258 ns/iter (± 32445) 0.98
es/preset-env/usage/property 21488 ns/iter (± 69) 21211 ns/iter (± 83) 1.01
es/resolver/typescript 123410776 ns/iter (± 2112328) 126572488 ns/iter (± 4843967) 0.98
es/fixer/typescript 95167706 ns/iter (± 907840) 96375162 ns/iter (± 2295650) 0.99
es/hygiene/typescript 206372064 ns/iter (± 1689490) 208093336 ns/iter (± 1236934) 0.99
es/resolver_with_hygiene/typescript 343731229 ns/iter (± 6063836) 346846759 ns/iter (± 1441860) 0.99
es/visitor/base-perf/module_clone 75834 ns/iter (± 1833) 76089 ns/iter (± 2115) 1.00
es/visitor/base-perf/fold_empty 85852 ns/iter (± 1480) 86305 ns/iter (± 2087) 0.99
es/visitor/base-perf/fold_noop_impl_all 85756 ns/iter (± 1594) 85500 ns/iter (± 1800) 1.00
es/visitor/base-perf/fold_noop_impl_vec 85900 ns/iter (± 1568) 86506 ns/iter (± 961) 0.99
es/visitor/base-perf/boxing_boxed_clone 56 ns/iter (± 0) 56 ns/iter (± 0) 1
es/visitor/base-perf/boxing_unboxed_clone 59 ns/iter (± 0) 59 ns/iter (± 0) 1
es/visitor/base-perf/boxing_boxed 103 ns/iter (± 0) 103 ns/iter (± 0) 1
es/visitor/base-perf/boxing_unboxed 102 ns/iter (± 0) 102 ns/iter (± 0) 1
es/visitor/base-perf/visit_contains_this 3500 ns/iter (± 45) 3590 ns/iter (± 87) 0.97
es/base/parallel/resolver/typescript 5277963096 ns/iter (± 507182374) 5263036066 ns/iter (± 472878250) 1.00
es/base/parallel/hygiene/typescript 2393923370 ns/iter (± 34931043) 2409428991 ns/iter (± 32048466) 0.99
misc/visitors/time-complexity/time 5 102 ns/iter (± 0) 98 ns/iter (± 0) 1.04
misc/visitors/time-complexity/time 10 334 ns/iter (± 0) 311 ns/iter (± 0) 1.07
misc/visitors/time-complexity/time 15 677 ns/iter (± 33) 657 ns/iter (± 0) 1.03
misc/visitors/time-complexity/time 20 1207 ns/iter (± 1) 1211 ns/iter (± 3) 1.00
misc/visitors/time-complexity/time 40 6750 ns/iter (± 42) 6598 ns/iter (± 6) 1.02
misc/visitors/time-complexity/time 60 17266 ns/iter (± 18) 16930 ns/iter (± 56) 1.02
es/full-target/es2016 187379 ns/iter (± 675) 188535 ns/iter (± 724) 0.99
es/full-target/es2017 182531 ns/iter (± 1037) 183020 ns/iter (± 718) 1.00
es/full-target/es2018 171386 ns/iter (± 814) 172949 ns/iter (± 694) 0.99
es2020_nullish_coalescing 66766 ns/iter (± 1972) 66558 ns/iter (± 102) 1.00
es2020_optional_chaining 95549 ns/iter (± 3330) 96611 ns/iter (± 7895) 0.99
es2022_class_properties 93265 ns/iter (± 179) 93608 ns/iter (± 177) 1.00
es2018_object_rest_spread 71481 ns/iter (± 92) 71245 ns/iter (± 128) 1.00
es2019_optional_catch_binding 61170 ns/iter (± 155) 61212 ns/iter (± 224) 1.00
es2017_async_to_generator 61452 ns/iter (± 86) 61386 ns/iter (± 145) 1.00
es2016_exponentiation 65241 ns/iter (± 130) 64443 ns/iter (± 181) 1.01
es2015_arrow 70424 ns/iter (± 239) 70386 ns/iter (± 161) 1.00
es2015_block_scoped_fn 66661 ns/iter (± 251) 66078 ns/iter (± 134) 1.01
es2015_block_scoping 155260 ns/iter (± 8971) 141272 ns/iter (± 8685) 1.10
es2015_classes 118315 ns/iter (± 382) 116524 ns/iter (± 586) 1.02
es2015_computed_props 61134 ns/iter (± 97) 60920 ns/iter (± 162) 1.00
es2015_destructuring 116959 ns/iter (± 2892) 116100 ns/iter (± 313) 1.01
es2015_duplicate_keys 63275 ns/iter (± 96) 63574 ns/iter (± 102) 1.00
es2015_parameters 79736 ns/iter (± 136) 79869 ns/iter (± 127) 1.00
es2015_fn_name 66449 ns/iter (± 549) 66629 ns/iter (± 580) 1.00
es2015_for_of 64060 ns/iter (± 82) 63987 ns/iter (± 130) 1.00
es2015_instanceof 63243 ns/iter (± 79) 63336 ns/iter (± 136) 1.00
es2015_shorthand_property 61145 ns/iter (± 114) 60795 ns/iter (± 102) 1.01
es2015_spread 60988 ns/iter (± 123) 60503 ns/iter (± 157) 1.01
es2015_sticky_regex 62310 ns/iter (± 76) 61882 ns/iter (± 71) 1.01
es2015_typeof_symbol 62163 ns/iter (± 156) 62258 ns/iter (± 74) 1.00
es/transform/baseline/base 51514 ns/iter (± 79) 51529 ns/iter (± 149) 1.00
es/transform/baseline/common_reserved_word 62367 ns/iter (± 94) 62358 ns/iter (± 109) 1.00
es/transform/baseline/common_typescript 142570 ns/iter (± 4936) 144222 ns/iter (± 3015) 0.99
es/target/es3 169998 ns/iter (± 291) 169874 ns/iter (± 216) 1.00
es/target/es2015 633478 ns/iter (± 1322) 632049 ns/iter (± 1465) 1.00
es/target/es2016 65008 ns/iter (± 116) 64714 ns/iter (± 136) 1.00
es/target/es2017 61478 ns/iter (± 119) 61444 ns/iter (± 139) 1.00
es/target/es2018 81448 ns/iter (± 147) 81613 ns/iter (± 81) 1.00
es/target/es2020 132781 ns/iter (± 371) 132635 ns/iter (± 143) 1.00
babelify-only 672047 ns/iter (± 668) 672811 ns/iter (± 1172) 1.00
parse_and_babelify_angular 44925710 ns/iter (± 1125470) 44918833 ns/iter (± 862500) 1.00
parse_and_babelify_backbone 5491925 ns/iter (± 49949) 5496207 ns/iter (± 51546) 1.00
parse_and_babelify_jquery 33364116 ns/iter (± 390820) 33695225 ns/iter (± 831652) 0.99
parse_and_babelify_jquery_mobile 57143567 ns/iter (± 597913) 56920689 ns/iter (± 1082815) 1.00
parse_and_babelify_mootools 34900978 ns/iter (± 744851) 35086494 ns/iter (± 572209) 0.99
parse_and_babelify_underscore 4353258 ns/iter (± 27862) 4398235 ns/iter (± 32551) 0.99
parse_and_babelify_yui 33270099 ns/iter (± 657602) 35850881 ns/iter (± 1537820) 0.93
html/minify/document/css_spec 42333837 ns/iter (± 275803) 42998184 ns/iter (± 359936) 0.98
html/minify/document/github 17653095 ns/iter (± 77116) 17586882 ns/iter (± 122385) 1.00
html/minify/document/stackoverflow 15740290 ns/iter (± 37108) 15780617 ns/iter (± 39180) 1.00
html/minify/document_fragment/css_spec 40942842 ns/iter (± 366766) 40584962 ns/iter (± 260052) 1.01
html/minify/document_fragment/github 16913571 ns/iter (± 80607) 16776541 ns/iter (± 19821) 1.01
html/minify/document_fragment/stackoverflow 15346747 ns/iter (± 64081) 15280852 ns/iter (± 45901) 1.00
html/document/visitor/compare/clone 334340 ns/iter (± 1972) 341676 ns/iter (± 1709) 0.98
html/document/visitor/compare/visit_mut_span 361875 ns/iter (± 2001) 368111 ns/iter (± 2863) 0.98
html/document/visitor/compare/visit_mut_span_panic 369209 ns/iter (± 1682) 378910 ns/iter (± 1024) 0.97
html/document/visitor/compare/fold_span 400115 ns/iter (± 1819) 399853 ns/iter (± 2775) 1.00
html/document/visitor/compare/fold_span_panic 462808 ns/iter (± 1480) 454766 ns/iter (± 1605) 1.02
html/document_fragment/visitor/compare/clone 340485 ns/iter (± 1388) 335587 ns/iter (± 1987) 1.01
html/document_fragment/visitor/compare/visit_mut_span 368441 ns/iter (± 1618) 365096 ns/iter (± 2370) 1.01
html/document_fragment/visitor/compare/visit_mut_span_panic 379710 ns/iter (± 1568) 375596 ns/iter (± 2113) 1.01
html/document_fragment/visitor/compare/fold_span 400024 ns/iter (± 2509) 400083 ns/iter (± 2595) 1.00
html/document_fragment/visitor/compare/fold_span_panic 462412 ns/iter (± 1484) 456441 ns/iter (± 2058) 1.01
html/lexer/css_2021_spec 15613095 ns/iter (± 13951) 15554131 ns/iter (± 17360) 1.00
html/lexer/github_com_17_05_2022 6046104 ns/iter (± 3620) 6028677 ns/iter (± 7502) 1.00
html/lexer/stackoverflow_com_17_05_2022 5664583 ns/iter (± 8492) 5643649 ns/iter (± 8259) 1.00
html/parser/parser_document/css_2021_spec 25934370 ns/iter (± 228497) 26072198 ns/iter (± 304247) 0.99
html/parser/parser_document/github_com_17_05_2022 8765127 ns/iter (± 4967) 8785277 ns/iter (± 20885) 1.00
html/parser/parser_document/stackoverflow_com_17_05_2022 7762357 ns/iter (± 5988) 7720553 ns/iter (± 12297) 1.01
html/parser/parser_document_fragment/css_2021_spec 26042159 ns/iter (± 215662) 26055470 ns/iter (± 245446) 1.00
html/parser/parser_document_fragment/github_com_17_05_2022 8762878 ns/iter (± 16592) 8796020 ns/iter (± 13245) 1.00
html/parser/parser_document_fragment/stackoverflow_com_17_05_2022 7726509 ns/iter (± 11529) 7728314 ns/iter (± 14485) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.