fix(es/minifier): Don't create invalid property names (#7010)

Author: magic-akari

crates/swc_ecma_minifier/src/compress/optimize/arguments.rs

@@ -3,7 +3,7 @@ use std::iter::repeat_with;
 use swc_atoms::js_word;
 use swc_common::{util::take::Take, DUMMY_SP};
 use swc_ecma_ast::*;
-use swc_ecma_utils::{find_pat_ids, private_ident};
+use swc_ecma_utils::{find_pat_ids, is_valid_prop_ident, private_ident};
 use swc_ecma_visit::{noop_visit_mut_type, VisitMut, VisitMutWith};
 
 use super::Optimizer;
@@ -29,6 +29,10 @@ where
                             return;
                         }
 
+                        if !is_valid_prop_ident(&s.value) {
+                            return;
+                        }
+
                         self.changed = true;
                         report_change!("arguments: Optimizing computed access to arguments");
                         *prop = MemberProp::Ident(Ident {
@@ -47,6 +51,10 @@ where
                             return;
                         }
 
+                        if !is_valid_prop_ident(&s.value) {
+                            return;
+                        }
+
                         self.changed = true;
                         report_change!("arguments: Optimizing computed access to arguments");
                         *prop = SuperProp::Ident(Ident {

crates/swc_ecma_minifier/tests/fixture/issues/7009/config.json

@@ -0,0 +1,46 @@
+{
+    "arguments": true,
+    "arrows": true,
+    "booleans": true,
+    "booleans_as_integers": false,
+    "collapse_vars": true,
+    "comparisons": true,
+    "computed_props": true,
+    "conditionals": true,
+    "dead_code": true,
+    "directives": true,
+    "drop_console": false,
+    "drop_debugger": true,
+    "evaluate": true,
+    "expression": false,
+    "hoist_funs": false,
+    "hoist_props": true,
+    "hoist_vars": false,
+    "if_return": true,
+    "join_vars": true,
+    "keep_classnames": false,
+    "keep_fargs": true,
+    "keep_fnames": false,
+    "keep_infinity": false,
+    "loops": true,
+    "negate_iife": true,
+    "properties": true,
+    "reduce_funcs": false,
+    "reduce_vars": false,
+    "side_effects": true,
+    "switches": true,
+    "typeofs": true,
+    "unsafe": false,
+    "unsafe_arrows": false,
+    "unsafe_comps": false,
+    "unsafe_Function": false,
+    "unsafe_math": false,
+    "unsafe_symbols": false,
+    "unsafe_methods": false,
+    "unsafe_proto": false,
+    "unsafe_regexp": false,
+    "unsafe_undefined": false,
+    "unused": true,
+    "const_to_let": true,
+    "pristine_globals": true
+}

crates/swc_ecma_minifier/tests/fixture/issues/7009/input.js

@@ -0,0 +1,20 @@
+export const example1 = (param) =>
+  param => param["There is something wrong!"];
+
+export const example2 = (param) =>
+  param => param["123 is fine"];
+
+export const example3 = (param) =>
+  param => param["! That is fine !"];
+
+export const example4 = (param) =>
+  param => param[" space in start works fine"];
+
+export const example5 = (param) =>
+  param => param[123];
+
+export class Foo extends Bar {
+  foo() {
+    super["a space b"]();
+  }
+}

crates/swc_ecma_minifier/tests/fixture/issues/7009/output.js

@@ -0,0 +1,10 @@
+export const example1 = (param)=>(param)=>param["There is something wrong!"];
+export const example2 = (param)=>(param)=>param["123 is fine"];
+export const example3 = (param)=>(param)=>param["! That is fine !"];
+export const example4 = (param)=>(param)=>param[" space in start works fine"];
+export const example5 = (param)=>(param)=>param[123];
+export class Foo extends Bar {
+    foo() {
+        super["a space b"]();
+    }
+}