Skip to content

Commit

Permalink
fix(es): Fix a crash related to an empty source map (#7229)
Browse files Browse the repository at this point in the history
  • Loading branch information
@chenyukang
chenyukang committed Apr 10, 2023
1 parent ab9e793 commit c665918
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions crates/swc/src/lib.rs
View file
Expand Up @@ -545,7 +545,7 @@ impl Compiler {

let (code, map) = match source_map {
SourceMapsConfig::Bool(v) => {
if v {
if v && !src_map_buf.is_empty() {
let mut buf = vec![];

self.cm
Expand All @@ -570,7 +570,6 @@ impl Compiler {
}
SourceMapsConfig::Str(_) => {
let mut src = src;

let mut buf = vec![];

self.cm
Expand Down

2 comments on commit c665918

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: c665918 Previous: b1c40a4 Ratio
es/full/bugs-1 302145 ns/iter (± 16577) 308538 ns/iter (± 4780) 0.98
es/full/minify/libraries/antd 1592472124 ns/iter (± 31502249) 1648368101 ns/iter (± 20502270) 0.97
es/full/minify/libraries/d3 292157209 ns/iter (± 5562411) 330578293 ns/iter (± 7643284) 0.88
es/full/minify/libraries/echarts 1206121141 ns/iter (± 11522412) 1251016186 ns/iter (± 14093336) 0.96
es/full/minify/libraries/jquery 89105314 ns/iter (± 906653) 94549341 ns/iter (± 1116141) 0.94
es/full/minify/libraries/lodash 103588871 ns/iter (± 1045686) 109615130 ns/iter (± 1151120) 0.95
es/full/minify/libraries/moment 51607467 ns/iter (± 456727) 53718087 ns/iter (± 467859) 0.96
es/full/minify/libraries/react 18802019 ns/iter (± 171858) 19635656 ns/iter (± 262388) 0.96
es/full/minify/libraries/terser 247816483 ns/iter (± 10251748) 263147508 ns/iter (± 4561482) 0.94
es/full/minify/libraries/three 440508851 ns/iter (± 6967671) 460222672 ns/iter (± 6161320) 0.96
es/full/minify/libraries/typescript 3020447589 ns/iter (± 63806282) 3021573539 ns/iter (± 14193176) 1.00
es/full/minify/libraries/victory 639841330 ns/iter (± 16813881) 710872683 ns/iter (± 14428315) 0.90
es/full/minify/libraries/vue 127599772 ns/iter (± 938005) 137526822 ns/iter (± 1799953) 0.93
es/full/codegen/es3 28481 ns/iter (± 191) 28743 ns/iter (± 71) 0.99
es/full/codegen/es5 28881 ns/iter (± 143) 28816 ns/iter (± 96) 1.00
es/full/codegen/es2015 28527 ns/iter (± 153) 28817 ns/iter (± 59) 0.99
es/full/codegen/es2016 28434 ns/iter (± 210) 28785 ns/iter (± 59) 0.99
es/full/codegen/es2017 28364 ns/iter (± 130) 28819 ns/iter (± 43) 0.98
es/full/codegen/es2018 28369 ns/iter (± 113) 28807 ns/iter (± 41) 0.98
es/full/codegen/es2019 28426 ns/iter (± 159) 28807 ns/iter (± 47) 0.99
es/full/codegen/es2020 28466 ns/iter (± 155) 28839 ns/iter (± 32) 0.99
es/full/all/es3 178296542 ns/iter (± 2342481) 185897198 ns/iter (± 2819061) 0.96
es/full/all/es5 173520028 ns/iter (± 1778519) 177105767 ns/iter (± 3166912) 0.98
es/full/all/es2015 130758308 ns/iter (± 1174019) 134911114 ns/iter (± 2346283) 0.97
es/full/all/es2016 130028866 ns/iter (± 2250490) 134913557 ns/iter (± 2651418) 0.96
es/full/all/es2017 127178227 ns/iter (± 1059894) 134449392 ns/iter (± 2831098) 0.95
es/full/all/es2018 123214631 ns/iter (± 1416576) 129250611 ns/iter (± 2061280) 0.95
es/full/all/es2019 121844239 ns/iter (± 1623698) 129230932 ns/iter (± 2326184) 0.94
es/full/all/es2020 116265068 ns/iter (± 847500) 120049142 ns/iter (± 1605438) 0.97
es/full/parser 504795 ns/iter (± 9039) 514403 ns/iter (± 8516) 0.98
es/full/base/fixer 22442 ns/iter (± 192) 22821 ns/iter (± 38) 0.98
es/full/base/resolver_and_hygiene 83308 ns/iter (± 390) 84351 ns/iter (± 91) 0.99
serialization of serde 124 ns/iter (± 0) 120 ns/iter (± 0) 1.03
css/minify/libraries/bootstrap 26956226 ns/iter (± 232196) 28591001 ns/iter (± 129624) 0.94
css/visitor/compare/clone 2128992 ns/iter (± 17869) 2151908 ns/iter (± 9756) 0.99
css/visitor/compare/visit_mut_span 2288385 ns/iter (± 8880) 2343682 ns/iter (± 20201) 0.98
css/visitor/compare/visit_mut_span_panic 2354891 ns/iter (± 9190) 2400290 ns/iter (± 15737) 0.98
css/visitor/compare/fold_span 3067590 ns/iter (± 17185) 3142650 ns/iter (± 21516) 0.98
css/visitor/compare/fold_span_panic 3223110 ns/iter (± 21639) 3313361 ns/iter (± 33273) 0.97
css/lexer/bootstrap_5_1_3 5085373 ns/iter (± 31470) 5116388 ns/iter (± 1961) 0.99
css/lexer/foundation_6_7_4 4236599 ns/iter (± 22308) 4307018 ns/iter (± 1522) 0.98
css/lexer/tailwind_3_1_1 810486 ns/iter (± 2632) 818802 ns/iter (± 246) 0.99
css/parser/bootstrap_5_1_3 20884401 ns/iter (± 194966) 21863627 ns/iter (± 66905) 0.96
css/parser/foundation_6_7_4 16735660 ns/iter (± 109962) 17332352 ns/iter (± 67410) 0.97
css/parser/tailwind_3_1_1 3257623 ns/iter (± 11785) 3235317 ns/iter (± 2150) 1.01
es/codegen/colors 705240 ns/iter (± 409311) 315817 ns/iter (± 178953) 2.23
es/codegen/large 1154564 ns/iter (± 594798) 1113516 ns/iter (± 567993) 1.04
es/codegen/with-parser/colors 47080 ns/iter (± 364) 47201 ns/iter (± 401) 1.00
es/codegen/with-parser/large 508046 ns/iter (± 2795) 515217 ns/iter (± 2295) 0.99
es/minify/libraries/antd 1389500330 ns/iter (± 23164633) 1420747663 ns/iter (± 22154429) 0.98
es/minify/libraries/d3 246656337 ns/iter (± 2616939) 268031086 ns/iter (± 5150946) 0.92
es/minify/libraries/echarts 1052875022 ns/iter (± 21919989) 1093172030 ns/iter (± 9049126) 0.96
es/minify/libraries/jquery 78290289 ns/iter (± 2284787) 82471140 ns/iter (± 1612534) 0.95
es/minify/libraries/lodash 93405630 ns/iter (± 1235206) 99189182 ns/iter (± 2351082) 0.94
es/minify/libraries/moment 45013234 ns/iter (± 647121) 46676970 ns/iter (± 402621) 0.96
es/minify/libraries/react 16875952 ns/iter (± 145221) 17396357 ns/iter (± 261753) 0.97
es/minify/libraries/terser 206152441 ns/iter (± 4195729) 223287864 ns/iter (± 2582660) 0.92
es/minify/libraries/three 352906126 ns/iter (± 9570954) 383954680 ns/iter (± 12405512) 0.92
es/minify/libraries/typescript 2576376763 ns/iter (± 23178671) 2556681827 ns/iter (± 17393178) 1.01
es/minify/libraries/victory 566242260 ns/iter (± 13989560) 598875676 ns/iter (± 5226064) 0.95
es/minify/libraries/vue 115915455 ns/iter (± 1706840) 121771138 ns/iter (± 880228) 0.95
es/visitor/compare/clone 2330430 ns/iter (± 23317) 2328801 ns/iter (± 9989) 1.00
es/visitor/compare/visit_mut_span 2734238 ns/iter (± 12590) 2705531 ns/iter (± 7139) 1.01
es/visitor/compare/visit_mut_span_panic 2757526 ns/iter (± 8371) 2755283 ns/iter (± 11604) 1.00
es/visitor/compare/fold_span 3813288 ns/iter (± 16753) 3835773 ns/iter (± 38371) 0.99
es/visitor/compare/fold_span_panic 3968939 ns/iter (± 12222) 3966478 ns/iter (± 25465) 1.00
es/lexer/colors 13078 ns/iter (± 75) 13376 ns/iter (± 7) 0.98
es/lexer/angular 6364377 ns/iter (± 3579) 6440411 ns/iter (± 5360) 0.99
es/lexer/backbone 787387 ns/iter (± 619) 796414 ns/iter (± 484) 0.99
es/lexer/jquery 4400121 ns/iter (± 5021) 4444012 ns/iter (± 2847) 0.99
es/lexer/jquery mobile 6861330 ns/iter (± 16878) 6920997 ns/iter (± 3163) 0.99
es/lexer/mootools 3415498 ns/iter (± 21952) 3510996 ns/iter (± 1439) 0.97
es/lexer/underscore 647551 ns/iter (± 6471) 658476 ns/iter (± 912) 0.98
es/lexer/three 20652250 ns/iter (± 104527) 21072410 ns/iter (± 33363) 0.98
es/lexer/yui 3864864 ns/iter (± 10617) 3908606 ns/iter (± 1675) 0.99
es/parser/colors 28587 ns/iter (± 131) 28838 ns/iter (± 71) 0.99
es/parser/angular 14792274 ns/iter (± 126100) 15598531 ns/iter (± 210550) 0.95
es/parser/backbone 2145890 ns/iter (± 14956) 2137475 ns/iter (± 11607) 1.00
es/parser/jquery 11732241 ns/iter (± 133203) 11904783 ns/iter (± 276788) 0.99
es/parser/jquery mobile 18090272 ns/iter (± 234850) 19746584 ns/iter (± 236203) 0.92
es/parser/mootools 8764621 ns/iter (± 57866) 8976610 ns/iter (± 75037) 0.98
es/parser/underscore 1809223 ns/iter (± 15691) 1800545 ns/iter (± 9030) 1.00
es/parser/three 52754680 ns/iter (± 1248451) 54815869 ns/iter (± 205240) 0.96
es/parser/yui 8891077 ns/iter (± 65233) 9200413 ns/iter (± 92172) 0.97
es/preset-env/usage/builtin_type 145083 ns/iter (± 34760) 142610 ns/iter (± 33464) 1.02
es/preset-env/usage/property 21335 ns/iter (± 165) 20530 ns/iter (± 166) 1.04
es/resolver/typescript 124924089 ns/iter (± 3122475) 109387521 ns/iter (± 1946562) 1.14
es/fixer/typescript 85666969 ns/iter (± 1400457) 76795136 ns/iter (± 504358) 1.12
es/hygiene/typescript 183647905 ns/iter (± 2177032) 164987637 ns/iter (± 1271990) 1.11
es/resolver_with_hygiene/typescript 334415360 ns/iter (± 4620513) 296183306 ns/iter (± 3158706) 1.13
es/visitor/base-perf/module_clone 80710 ns/iter (± 370) 80503 ns/iter (± 336) 1.00
es/visitor/base-perf/fold_empty 90208 ns/iter (± 343) 90338 ns/iter (± 382) 1.00
es/visitor/base-perf/fold_noop_impl_all 89662 ns/iter (± 1108) 90975 ns/iter (± 322) 0.99
es/visitor/base-perf/fold_noop_impl_vec 89932 ns/iter (± 721) 90493 ns/iter (± 713) 0.99
es/visitor/base-perf/boxing_boxed_clone 61 ns/iter (± 0) 58 ns/iter (± 0) 1.05
es/visitor/base-perf/boxing_unboxed_clone 41 ns/iter (± 0) 42 ns/iter (± 0) 0.98
es/visitor/base-perf/boxing_boxed 106 ns/iter (± 0) 103 ns/iter (± 0) 1.03
es/visitor/base-perf/boxing_unboxed 90 ns/iter (± 0) 80 ns/iter (± 0) 1.13
es/visitor/base-perf/visit_contains_this 3530 ns/iter (± 79) 3387 ns/iter (± 67) 1.04
es/base/parallel/resolver/typescript 6420041886 ns/iter (± 579899614) 6166602036 ns/iter (± 471514514) 1.04
es/base/parallel/hygiene/typescript 2169233766 ns/iter (± 31387359) 1994715787 ns/iter (± 21445058) 1.09
misc/visitors/time-complexity/time 5 103 ns/iter (± 0) 105 ns/iter (± 0) 0.98
misc/visitors/time-complexity/time 10 339 ns/iter (± 4) 325 ns/iter (± 0) 1.04
misc/visitors/time-complexity/time 15 670 ns/iter (± 7) 677 ns/iter (± 16) 0.99
misc/visitors/time-complexity/time 20 1210 ns/iter (± 6) 1243 ns/iter (± 0) 0.97
misc/visitors/time-complexity/time 40 6142 ns/iter (± 26) 6212 ns/iter (± 26) 0.99
misc/visitors/time-complexity/time 60 15557 ns/iter (± 81) 15578 ns/iter (± 2) 1.00
es/full-target/es2016 254534 ns/iter (± 456) 253247 ns/iter (± 1288) 1.01
es/full-target/es2017 246221 ns/iter (± 1467) 246689 ns/iter (± 500) 1.00
es/full-target/es2018 235642 ns/iter (± 849) 236127 ns/iter (± 306) 1.00
es2020_nullish_coalescing 92344 ns/iter (± 526) 92881 ns/iter (± 438) 0.99
es2020_optional_chaining 123817 ns/iter (± 746) 123774 ns/iter (± 261) 1.00
es2022_class_properties 148167 ns/iter (± 718) 149797 ns/iter (± 228) 0.99
es2018_object_rest_spread 95220 ns/iter (± 591) 96229 ns/iter (± 114) 0.99
es2019_optional_catch_binding 85183 ns/iter (± 344) 85717 ns/iter (± 126) 0.99
es2017_async_to_generator 85896 ns/iter (± 495) 85728 ns/iter (± 183) 1.00
es2016_exponentiation 89518 ns/iter (± 278) 90549 ns/iter (± 183) 0.99
es2015_arrow 93576 ns/iter (± 254) 94295 ns/iter (± 176) 0.99
es2015_block_scoped_fn 92120 ns/iter (± 372) 92139 ns/iter (± 178) 1.00
es2015_block_scoping 169672 ns/iter (± 847) 169783 ns/iter (± 195) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: c665918 Previous: b1c40a4 Ratio
es/codegen/colors 705240 ns/iter (± 409311) 315817 ns/iter (± 178953) 2.23

This comment was automatically generated by workflow using github-action-benchmark.

CC: @kdy1

Please sign in to comment.