fix(es/codegen): Fix codegen of string literals with \x000 (#6838)

**Related issue:**

 - Closes #6836.

Author: kdy1

crates/swc/tests/fixture/issues-6xxx/6836/1/input/.swcrc

@@ -0,0 +1,10 @@
+{
+    "jsc": {
+        "parser": {
+            "syntax": "ecmascript",
+            "jsx": false
+        },
+        "target": "es5"
+    },
+    "isModule": true
+}

crates/swc/tests/fixture/issues-6xxx/6836/1/input/index.js

@@ -0,0 +1 @@
+console.log("\x000")

crates/swc/tests/fixture/issues-6xxx/6836/1/output/index.js

@@ -0,0 +1 @@
+console.log("\x000");

crates/swc/tests/fixture/next.js/slack-1/es3/output/index.js

@@ -1 +1 @@
-var USTAR = "ustar\000";
+var USTAR = "ustar\x0000";

crates/swc/tests/fixture/next.js/slack-1/es5/output/index.js

@@ -1 +1 @@
-var USTAR = "ustar\000";
+var USTAR = "ustar\x0000";

crates/swc/tests/tsc-references/scannerStringLiteralWithContainingNullCharacter1.1.normal.js

@@ -1,2 +1,2 @@
 //// [scannerStringLiteralWithContainingNullCharacter1.ts]
-" \0 ";
+" \x00 ";

crates/swc/tests/tsc-references/templateStringControlCharacterEscapes01.1.normal.js

@@ -1,2 +1,2 @@
 //// [templateStringControlCharacterEscapes01.ts]
-var x = "\0\0\0 0 00 0000";
+var x = "\x00\x00\x00 0 00 0000";

crates/swc/tests/tsc-references/unicodeExtendedEscapesInStrings01_ES5.1.normal.js

@@ -1,2 +1,2 @@
 //// [unicodeExtendedEscapesInStrings01_ES5.ts]
-var x = "\0";
+var x = "\x00";

crates/swc/tests/tsc-references/unicodeExtendedEscapesInStrings02_ES5.1.normal.js

@@ -1,2 +1,2 @@
 //// [unicodeExtendedEscapesInStrings02_ES5.ts]
-var x = "\0";
+var x = "\x00";

crates/swc/tests/tsc-references/unicodeExtendedEscapesInStrings03_ES5.1.normal.js

@@ -1,2 +1,2 @@
 //// [unicodeExtendedEscapesInStrings03_ES5.ts]
-var x = "\0";
+var x = "\x00";

crates/swc/tests/tsc-references/unicodeExtendedEscapesInStrings04_ES5.1.normal.js

@@ -1,2 +1,2 @@
 //// [unicodeExtendedEscapesInStrings04_ES5.ts]
-var x = "\0";
+var x = "\x00";

crates/swc/tests/tsc-references/unicodeExtendedEscapesInTemplates01_ES5.1.normal.js

@@ -1,2 +1,2 @@
 //// [unicodeExtendedEscapesInTemplates01_ES5.ts]
-var x = "\0";
+var x = "\x00";

crates/swc/tests/tsc-references/unicodeExtendedEscapesInTemplates02_ES5.1.normal.js

@@ -1,2 +1,2 @@
 //// [unicodeExtendedEscapesInTemplates02_ES5.ts]
-var x = "\0";
+var x = "\x00";

crates/swc/tests/tsc-references/unicodeExtendedEscapesInTemplates03_ES5.1.normal.js

@@ -1,2 +1,2 @@
 //// [unicodeExtendedEscapesInTemplates03_ES5.ts]
-var x = "\0";
+var x = "\x00";

crates/swc/tests/tsc-references/unicodeExtendedEscapesInTemplates04_ES5.1.normal.js

@@ -1,2 +1,2 @@
 //// [unicodeExtendedEscapesInTemplates04_ES5.ts]
-var x = "\0";
+var x = "\x00";

crates/swc_ecma_codegen/src/lib.rs

@@ -3477,12 +3477,7 @@ fn get_quoted_utf16(v: &str, ascii_only: bool, target: EsVersion) -> String {
     while let Some(c) = iter.next() {
         match c {
             '\x00' => {
-                let next = iter.peek();
-
-                match next {
-                    Some('1'..='9') => buf.push_str("\\x00"),
-                    _ => buf.push_str("\\0"),
-                }
+                buf.push_str("\\x00");
             }
             '\u{0008}' => buf.push_str("\\b"),
             '\u{000c}' => buf.push_str("\\f"),

crates/swc_ecma_codegen/src/tests.rs

@@ -591,36 +591,39 @@ CONTENT\r
 
 #[test]
 fn test_get_quoted_utf16() {
+    #[track_caller]
     fn es2020(src: &str, expected: &str) {
         assert_eq!(
             super::get_quoted_utf16(src, true, EsVersion::Es2020),
             expected
         )
     }
 
+    #[track_caller]
     fn es2020_nonascii(src: &str, expected: &str) {
         assert_eq!(
             super::get_quoted_utf16(src, true, EsVersion::Es2020),
             expected
         )
     }
 
+    #[track_caller]
     fn es5(src: &str, expected: &str) {
         assert_eq!(super::get_quoted_utf16(src, true, EsVersion::Es5), expected)
     }
 
     es2020("abcde", "\"abcde\"");
     es2020(
         "\x00\r\n\u{85}\u{2028}\u{2029};",
-        "\"\\0\\r\\n\\x85\\u2028\\u2029;\"",
+        "\"\\x00\\r\\n\\x85\\u2028\\u2029;\"",
     );
 
     es2020("\n", "\"\\n\"");
     es2020("\t", "\"\t\"");
 
     es2020("'string'", "\"'string'\"");
 
-    es2020("\u{0}", "\"\\0\"");
+    es2020("\u{0}", "\"\\x00\"");
     es2020("\u{1}", "\"\\x01\"");
 
     es2020("\u{1000}", "\"\\u1000\"");
@@ -656,7 +659,7 @@ fn issue_1452_1() {
 fn issue_1619_1() {
     assert_min_target(
         "\"\\x00\" + \"\\x31\"",
-        "\"\\0\"+\"1\"",
+        "\"\\x00\"+\"1\"",
         EsVersion::latest(),
     );
 }
@@ -665,7 +668,7 @@ fn issue_1619_1() {
 fn issue_1619_2() {
     assert_min_target(
         "\"\\x00\" + \"\\x31\"",
-        "\"\\0\"+\"1\"",
+        "\"\\x00\"+\"1\"",
         EsVersion::latest(),
     );
 }

crates/swc_ecma_codegen/tests/fixture/string/output.min.js

@@ -1 +1 @@
-"use strict";("\0");
+"use strict";("\x00");

crates/swc_ecma_codegen/tests/test262-min/0b1fc7208759253b.js

@@ -1 +1 @@
-"use strict";("\0x");
+"use strict";("\x00x");

crates/swc_ecma_codegen/tests/test262-min/3ae4f46daa688c58.js

@@ -1 +1 @@
-"\n\r	\v\b\f\\'\"\0";
+"\n\r	\v\b\f\\'\"\x00";

crates/swc_ecma_codegen/tests/test262-min/3d2ab39608730a47.js

@@ -1 +1 @@
-"Hello\0World";
+"Hello\x00World";

crates/swc_ecma_codegen/tests/test262-min/4672c2ef688237c9.js

@@ -1 +1 @@
-function a(){"use strict";"\0"}
+function a(){"use strict";"\x00"}

crates/swc_ecma_codegen/tests/test262-min/4fee4ac53bdfd7f7.js

@@ -1 +1 @@
-("\0");
+("\x00");

crates/swc_ecma_codegen/tests/test262-min/7c03e5eb6a9f6f1a.js

@@ -1 +1 @@
-(function(){"use strict";"\0"}());
+(function(){"use strict";"\x00"}());

crates/swc_ecma_codegen/tests/test262-min/84f901eb37273117.js

@@ -1 +1 @@
-("\0");
+("\x00");

crates/swc_ecma_codegen/tests/test262-min/c7e5fba8bf3854cd.js

@@ -1,2 +1,2 @@
 "use strict";
-("\0");
+("\x00");

crates/swc_ecma_codegen/tests/test262-min/d81d71f4121e3193.js

@@ -1,2 +1,2 @@
 "use strict";
-("\0x");
+("\x00x");

crates/swc_ecma_codegen/tests/test262/0b1fc7208759253b.js

@@ -1 +1 @@
-"\n\r	\v\b\f\\'\"\0";
+"\n\r	\v\b\f\\'\"\x00";

crates/swc_ecma_codegen/tests/test262/3ae4f46daa688c58.js

@@ -1 +1 @@
-"Hello\0World";
+"Hello\x00World";

crates/swc_ecma_codegen/tests/test262/3d2ab39608730a47.js

@@ -1,4 +1,4 @@
 function a() {
     "use strict";
-    "\0";
+    "\x00";
 }

crates/swc_ecma_codegen/tests/test262/4672c2ef688237c9.js

@@ -1 +1 @@
-("\0");
+("\x00");

crates/swc_ecma_codegen/tests/test262/4fee4ac53bdfd7f7.js

@@ -1,4 +1,4 @@
 (function() {
     "use strict";
-    "\0";
+    "\x00";
 }());

crates/swc_ecma_codegen/tests/test262/7c03e5eb6a9f6f1a.js

@@ -1 +1 @@
-("\0");
+("\x00");

crates/swc_ecma_codegen/tests/test262/84f901eb37273117.js

@@ -2097,7 +2097,7 @@
                                     }
                                 })
                             }) : t.push({
-                                string: s.replace(i, "\0"),
+                                string: s.replace(i, "\x00"),
                                 attributes: n.attributes
                             }), o = a + u.length;
                         }

crates/swc_ecma_codegen/tests/test262/c7e5fba8bf3854cd.js

@@ -1,4 +1,4 @@
-var r = {
+var x = {
     "\0
": "foo",
     get "\0
" () {
         return "bar";
@@ -10,12 +10,12 @@ var r = {
         return "foobar";
     }
 };
-class e {
+class r {
     get "\0
"() {
         return "bar";
     }
-    set "\0"(r) {
-        save(r);
+    set "\0"(x) {
+        save(x);
     }
     *"\0
"() {
         return "foobar";

crates/swc_ecma_codegen/tests/test262/d81d71f4121e3193.js

@@ -1,4 +1,4 @@
-var r = {
+var x = {
     "\0\x01": "foo",
     get "\0\x01" () {
         return "bar";
@@ -10,12 +10,12 @@ var r = {
         return "foobar";
     }
 };
-class e {
+class r {
     get "\0\x01"() {
         return "bar";
     }
-    set "\0\x01"(r) {
-        save(r);
+    set "\0\x01"(x) {
+        save(x);
     }
     *"\0\x01"() {
         return "foobar";