Skip to content

Commit

Permalink
refactor(es): Remove needless build scripts to reduce compile time (#…
Browse files Browse the repository at this point in the history 
…7129)
  • Loading branch information
@kdy1
kdy1 committed Mar 23, 2023
1 parent e77bc0a commit dfe1a3f
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 10 deletions.
2 changes: 1 addition & 1 deletion crates/ast_node/src/spanned.rs
View file
Expand Up @@ -5,7 +5,7 @@ use pmutil::{smart_quote, Quote, ToTokensExt};
use swc_macros_common::prelude::*;
use syn::*;

#[derive(Debug, FromField)]
#[derive(FromField)]
#[darling(attributes(span))]
struct MyField {
/// Name of the field.
Expand Down
4 changes: 0 additions & 4 deletions crates/swc_ecma_ast/build.rs
View file

This file was deleted.

3 changes: 2 additions & 1 deletion crates/swc_ecma_ast/src/lib.rs
View file
Expand Up @@ -9,7 +9,8 @@
#![allow(clippy::clone_on_copy)]
#![recursion_limit = "1024"]

// #![deny(variant_size_differences)]
#[cfg(all(feature = "rkyv-impl", feature = "rkyv-bytecheck-impl"))]
compile_error!("Cannot enable bytechcked, non-bytechecked rkyv both");

use serde::{Deserialize, Serialize};
use swc_common::{ast_node, EqIgnoreSpan, Span};
Expand Down
4 changes: 0 additions & 4 deletions crates/swc_plugin_proxy/build.rs
View file

This file was deleted.

3 changes: 3 additions & 0 deletions crates/swc_plugin_proxy/src/lib.rs
View file
@@ -1,5 +1,8 @@
#![cfg_attr(not(feature = "__rkyv"), allow(warnings))]

#[cfg(all(feature = "rkyv-impl", feature = "rkyv-bytecheck-impl"))]
compile_error!("Cannot enable bytechcked, non-bytechecked rkyv both");

mod comments;
mod memory_interop;
mod metadata;
Expand Down

1 comment on commit dfe1a3f

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: dfe1a3f Previous: 08fa94f Ratio
es/full/bugs-1 299338 ns/iter (± 12160) 311059 ns/iter (± 10657) 0.96
es/full/minify/libraries/antd 1530115211 ns/iter (± 22055664) 1593383832 ns/iter (± 29820083) 0.96
es/full/minify/libraries/d3 286425213 ns/iter (± 5395147) 297478503 ns/iter (± 8473265) 0.96
es/full/minify/libraries/echarts 1158154835 ns/iter (± 18380567) 1212751041 ns/iter (± 13895572) 0.95
es/full/minify/libraries/jquery 88933628 ns/iter (± 832663) 92847969 ns/iter (± 602430) 0.96
es/full/minify/libraries/lodash 103476316 ns/iter (± 963530) 106639319 ns/iter (± 994387) 0.97
es/full/minify/libraries/moment 51822978 ns/iter (± 390190) 52693383 ns/iter (± 413459) 0.98
es/full/minify/libraries/react 18860386 ns/iter (± 133921) 19215505 ns/iter (± 157440) 0.98
es/full/minify/libraries/terser 236310603 ns/iter (± 3340804) 248183134 ns/iter (± 2356983) 0.95
es/full/minify/libraries/three 418281429 ns/iter (± 6421719) 444052559 ns/iter (± 4238177) 0.94
es/full/minify/libraries/typescript 2867710124 ns/iter (± 23607323) 2958069271 ns/iter (± 21154051) 0.97
es/full/minify/libraries/victory 635776845 ns/iter (± 7474258) 665354078 ns/iter (± 6431398) 0.96
es/full/minify/libraries/vue 128648918 ns/iter (± 1868562) 131607015 ns/iter (± 953845) 0.98
es/full/codegen/es3 29011 ns/iter (± 37) 27967 ns/iter (± 61) 1.04
es/full/codegen/es5 29071 ns/iter (± 108) 28052 ns/iter (± 69) 1.04
es/full/codegen/es2015 28721 ns/iter (± 285) 28099 ns/iter (± 82) 1.02
es/full/codegen/es2016 28874 ns/iter (± 277) 28103 ns/iter (± 43) 1.03
es/full/codegen/es2017 28677 ns/iter (± 287) 28061 ns/iter (± 47) 1.02
es/full/codegen/es2018 28770 ns/iter (± 289) 28063 ns/iter (± 42) 1.03
es/full/codegen/es2019 29032 ns/iter (± 258) 28046 ns/iter (± 45) 1.04
es/full/codegen/es2020 29012 ns/iter (± 199) 28060 ns/iter (± 44) 1.03
es/full/all/es3 181516665 ns/iter (± 2436416) 180038510 ns/iter (± 4505038) 1.01
es/full/all/es5 173602577 ns/iter (± 3464624) 171609554 ns/iter (± 3062935) 1.01
es/full/all/es2015 137590364 ns/iter (± 1567222) 139533236 ns/iter (± 1616476) 0.99
es/full/all/es2016 134337214 ns/iter (± 1447116) 138169390 ns/iter (± 974393) 0.97
es/full/all/es2017 132406237 ns/iter (± 1994064) 135219894 ns/iter (± 1589806) 0.98
es/full/all/es2018 127966435 ns/iter (± 1983365) 131917203 ns/iter (± 1780547) 0.97
es/full/all/es2019 126490191 ns/iter (± 1786442) 130463636 ns/iter (± 1602063) 0.97
es/full/all/es2020 118710883 ns/iter (± 397802) 120640665 ns/iter (± 669376) 0.98
es/full/parser 524403 ns/iter (± 9090) 536454 ns/iter (± 8855) 0.98
es/full/base/fixer 21978 ns/iter (± 160) 22601 ns/iter (± 31) 0.97
es/full/base/resolver_and_hygiene 82210 ns/iter (± 579) 84935 ns/iter (± 111) 0.97
serialization of ast node 123 ns/iter (± 0) 124 ns/iter (± 0) 0.99
serialization of serde 126 ns/iter (± 1) 126 ns/iter (± 0) 1
css/minify/libraries/bootstrap 27980381 ns/iter (± 107003) 28775594 ns/iter (± 184296) 0.97
css/visitor/compare/clone 2054204 ns/iter (± 27558) 2060275 ns/iter (± 14250) 1.00
css/visitor/compare/visit_mut_span 2246346 ns/iter (± 9641) 2276333 ns/iter (± 6605) 0.99
css/visitor/compare/visit_mut_span_panic 2289427 ns/iter (± 16979) 2331719 ns/iter (± 6957) 0.98
css/visitor/compare/fold_span 3038809 ns/iter (± 30977) 3074920 ns/iter (± 21323) 0.99
css/visitor/compare/fold_span_panic 3135893 ns/iter (± 16670) 3174084 ns/iter (± 18593) 0.99
css/lexer/bootstrap_5_1_3 5050544 ns/iter (± 38395) 5115197 ns/iter (± 2927) 0.99
css/lexer/foundation_6_7_4 4264020 ns/iter (± 35343) 4311284 ns/iter (± 4220) 0.99
css/lexer/tailwind_3_1_1 804012 ns/iter (± 6722) 819526 ns/iter (± 490) 0.98
css/parser/bootstrap_5_1_3 21353661 ns/iter (± 103150) 22040821 ns/iter (± 62903) 0.97
css/parser/foundation_6_7_4 17258018 ns/iter (± 153604) 17485330 ns/iter (± 37185) 0.99
css/parser/tailwind_3_1_1 3307935 ns/iter (± 23661) 3363677 ns/iter (± 7519) 0.98
es/codegen/colors 325653 ns/iter (± 183528) 329358 ns/iter (± 184474) 0.99
es/codegen/large 1186953 ns/iter (± 606530) 1298240 ns/iter (± 662933) 0.91
es/codegen/with-parser/colors 47724 ns/iter (± 210) 48185 ns/iter (± 278) 0.99
es/codegen/with-parser/large 519214 ns/iter (± 2890) 523956 ns/iter (± 1697) 0.99
es/minify/libraries/antd 1313201326 ns/iter (± 13370580) 1380663544 ns/iter (± 13279702) 0.95
es/minify/libraries/d3 244929442 ns/iter (± 1775034) 261335157 ns/iter (± 2316763) 0.94
es/minify/libraries/echarts 979353645 ns/iter (± 9432930) 1066236575 ns/iter (± 10282413) 0.92
es/minify/libraries/jquery 76709294 ns/iter (± 637465) 80177803 ns/iter (± 767536) 0.96
es/minify/libraries/lodash 91731419 ns/iter (± 815951) 95302953 ns/iter (± 775028) 0.96
es/minify/libraries/moment 44708116 ns/iter (± 203309) 46243117 ns/iter (± 220847) 0.97
es/minify/libraries/react 16764520 ns/iter (± 114239) 17305860 ns/iter (± 97101) 0.97
es/minify/libraries/terser 200114929 ns/iter (± 941911) 213239505 ns/iter (± 667322) 0.94
es/minify/libraries/three 337938084 ns/iter (± 4402559) 374540641 ns/iter (± 4475872) 0.90
es/minify/libraries/typescript 2400982735 ns/iter (± 14377269) 2517022411 ns/iter (± 9007226) 0.95
es/minify/libraries/victory 507667367 ns/iter (± 5053215) 564324694 ns/iter (± 8920309) 0.90
es/minify/libraries/vue 111340534 ns/iter (± 743384) 116795694 ns/iter (± 671453) 0.95
es/visitor/compare/clone 2276307 ns/iter (± 19092) 2311388 ns/iter (± 12994) 0.98
es/visitor/compare/visit_mut_span 2634171 ns/iter (± 8989) 2665174 ns/iter (± 5962) 0.99
es/visitor/compare/visit_mut_span_panic 2639557 ns/iter (± 13613) 2713462 ns/iter (± 3371) 0.97
es/visitor/compare/fold_span 3708498 ns/iter (± 23530) 3783170 ns/iter (± 6913) 0.98
es/visitor/compare/fold_span_panic 3864488 ns/iter (± 21378) 3955367 ns/iter (± 13688) 0.98
es/lexer/colors 14958 ns/iter (± 160) 15307 ns/iter (± 16) 0.98
es/lexer/angular 7204283 ns/iter (± 57825) 7376956 ns/iter (± 9722) 0.98
es/lexer/backbone 962677 ns/iter (± 6907) 983773 ns/iter (± 999) 0.98
es/lexer/jquery 5532024 ns/iter (± 10802) 5520205 ns/iter (± 3885) 1.00
es/lexer/jquery mobile 8515450 ns/iter (± 32218) 8495848 ns/iter (± 4723) 1.00
es/lexer/mootools 4371988 ns/iter (± 21527) 4386833 ns/iter (± 2008) 1.00
es/lexer/underscore 827526 ns/iter (± 5228) 831663 ns/iter (± 286) 1.00
es/lexer/three 26094930 ns/iter (± 39349) 25903887 ns/iter (± 21277) 1.01
es/lexer/yui 4653500 ns/iter (± 40661) 4627237 ns/iter (± 2957) 1.01
es/parser/colors 29909 ns/iter (± 213) 29678 ns/iter (± 143) 1.01
es/parser/angular 15329675 ns/iter (± 111139) 15472430 ns/iter (± 199907) 0.99
es/parser/backbone 2230130 ns/iter (± 15381) 2243204 ns/iter (± 12563) 0.99
es/parser/jquery 12167794 ns/iter (± 148246) 12392889 ns/iter (± 113374) 0.98
es/parser/jquery mobile 18793347 ns/iter (± 127951) 19964806 ns/iter (± 263715) 0.94
es/parser/mootools 9251594 ns/iter (± 62386) 9559305 ns/iter (± 74261) 0.97
es/parser/underscore 1897340 ns/iter (± 27860) 1895085 ns/iter (± 10197) 1.00
es/parser/three 53733442 ns/iter (± 998298) 57368433 ns/iter (± 147532) 0.94
es/parser/yui 9312505 ns/iter (± 61649) 9355906 ns/iter (± 59852) 1.00
es/preset-env/usage/builtin_type 143319 ns/iter (± 34393) 144580 ns/iter (± 35141) 0.99
es/preset-env/usage/property 21297 ns/iter (± 89) 21481 ns/iter (± 114) 0.99
es/resolver/typescript 112709102 ns/iter (± 2124692) 112226099 ns/iter (± 2236895) 1.00
es/fixer/typescript 75937954 ns/iter (± 1266193) 78281481 ns/iter (± 1127875) 0.97
es/hygiene/typescript 161456485 ns/iter (± 1616487) 167246993 ns/iter (± 857792) 0.97
es/resolver_with_hygiene/typescript 303116370 ns/iter (± 3519440) 305137511 ns/iter (± 2500813) 0.99
es/visitor/base-perf/module_clone 80482 ns/iter (± 1580) 78346 ns/iter (± 1320) 1.03
es/visitor/base-perf/fold_empty 89906 ns/iter (± 1165) 90395 ns/iter (± 1543) 0.99
es/visitor/base-perf/fold_noop_impl_all 90372 ns/iter (± 1557) 91266 ns/iter (± 712) 0.99
es/visitor/base-perf/fold_noop_impl_vec 90005 ns/iter (± 1321) 91758 ns/iter (± 1624) 0.98
es/visitor/base-perf/boxing_boxed_clone 57 ns/iter (± 0) 56 ns/iter (± 0) 1.02
es/visitor/base-perf/boxing_unboxed_clone 54 ns/iter (± 0) 56 ns/iter (± 0) 0.96
es/visitor/base-perf/boxing_boxed 103 ns/iter (± 0) 103 ns/iter (± 0) 1
es/visitor/base-perf/boxing_unboxed 97 ns/iter (± 0) 100 ns/iter (± 0) 0.97
es/visitor/base-perf/visit_contains_this 3211 ns/iter (± 101) 3609 ns/iter (± 55) 0.89
es/base/parallel/resolver/typescript 5996723366 ns/iter (± 323289861) 7051393604 ns/iter (± 441270566) 0.85
es/base/parallel/hygiene/typescript 1955402935 ns/iter (± 24068907) 1974286980 ns/iter (± 38742936) 0.99
misc/visitors/time-complexity/time 5 98 ns/iter (± 0) 100 ns/iter (± 0) 0.98
misc/visitors/time-complexity/time 10 335 ns/iter (± 3) 335 ns/iter (± 1) 1
misc/visitors/time-complexity/time 15 671 ns/iter (± 14) 695 ns/iter (± 0) 0.97
misc/visitors/time-complexity/time 20 1239 ns/iter (± 11) 1327 ns/iter (± 10) 0.93
misc/visitors/time-complexity/time 40 6393 ns/iter (± 19) 6659 ns/iter (± 18) 0.96
misc/visitors/time-complexity/time 60 14187 ns/iter (± 59) 14925 ns/iter (± 33) 0.95
es/full-target/es2016 243908 ns/iter (± 1523) 250671 ns/iter (± 382) 0.97
es/full-target/es2017 240228 ns/iter (± 1099) 243029 ns/iter (± 274) 0.99
es/full-target/es2018 230531 ns/iter (± 1573) 231974 ns/iter (± 273) 0.99
es2020_nullish_coalescing 88908 ns/iter (± 968) 91250 ns/iter (± 233) 0.97
es2020_optional_chaining 120920 ns/iter (± 1264) 123741 ns/iter (± 541) 0.98
es2022_class_properties 141468 ns/iter (± 1776) 146806 ns/iter (± 149) 0.96
es2018_object_rest_spread 90677 ns/iter (± 661) 94740 ns/iter (± 227) 0.96
es2019_optional_catch_binding 81302 ns/iter (± 1000) 84206 ns/iter (± 154) 0.97
es2017_async_to_generator 82523 ns/iter (± 1212) 84589 ns/iter (± 246) 0.98
es2016_exponentiation 84931 ns/iter (± 532) 88882 ns/iter (± 181) 0.96
es2015_arrow 89959 ns/iter (± 952) 92859 ns/iter (± 203) 0.97
es2015_block_scoped_fn 87126 ns/iter (± 575) 90825 ns/iter (± 252) 0.96
es2015_block_scoping 161717 ns/iter (± 1849) 168841 ns/iter (± 342) 0.96

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.