-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(es/codegen): Skip space if jsx attrs is empty (#6823)
- Loading branch information
Showing
5 changed files
with
17 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
crates/swc_ecma_transforms_base/tests/resolver/issues/2854/1/output.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e9fdac2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
es/full/bugs-1
299954
ns/iter (± 6758
)304824
ns/iter (± 17137
)0.98
es/full/minify/libraries/antd
1643625779
ns/iter (± 20614379
)1671786358
ns/iter (± 26233988
)0.98
es/full/minify/libraries/d3
310650052
ns/iter (± 4425277
)312132210
ns/iter (± 8921425
)1.00
es/full/minify/libraries/echarts
1269915102
ns/iter (± 15721866
)1272514803
ns/iter (± 21304223
)1.00
es/full/minify/libraries/jquery
91303046
ns/iter (± 571155
)94704657
ns/iter (± 1700048
)0.96
es/full/minify/libraries/lodash
107474603
ns/iter (± 1622172
)111498775
ns/iter (± 2506590
)0.96
es/full/minify/libraries/moment
51967877
ns/iter (± 1000303
)53998514
ns/iter (± 802692
)0.96
es/full/minify/libraries/react
19230719
ns/iter (± 137217
)19878186
ns/iter (± 315304
)0.97
es/full/minify/libraries/terser
247272006
ns/iter (± 2978557
)257491066
ns/iter (± 5177381
)0.96
es/full/minify/libraries/three
448227977
ns/iter (± 5868801
)459634666
ns/iter (± 7966117
)0.98
es/full/minify/libraries/typescript
3019409584
ns/iter (± 19439000
)3126787064
ns/iter (± 15401985
)0.97
es/full/minify/libraries/victory
619414022
ns/iter (± 8795029
)730140735
ns/iter (± 14022495
)0.85
es/full/minify/libraries/vue
126965181
ns/iter (± 1357414
)135877541
ns/iter (± 2385199
)0.93
es/full/codegen/es3
25469
ns/iter (± 819
)25644
ns/iter (± 63
)0.99
es/full/codegen/es5
25538
ns/iter (± 93
)25683
ns/iter (± 53
)0.99
es/full/codegen/es2015
24961
ns/iter (± 251
)25584
ns/iter (± 35
)0.98
es/full/codegen/es2016
25049
ns/iter (± 273
)25613
ns/iter (± 61
)0.98
es/full/codegen/es2017
25006
ns/iter (± 136
)25632
ns/iter (± 81
)0.98
es/full/codegen/es2018
25165
ns/iter (± 276
)25642
ns/iter (± 72
)0.98
es/full/codegen/es2019
25093
ns/iter (± 111
)25611
ns/iter (± 59
)0.98
es/full/codegen/es2020
25160
ns/iter (± 231
)25629
ns/iter (± 54
)0.98
es/full/all/es3
172346924
ns/iter (± 3107852
)175130473
ns/iter (± 4795528
)0.98
es/full/all/es5
164232483
ns/iter (± 2522361
)166377968
ns/iter (± 6028401
)0.99
es/full/all/es2015
124714719
ns/iter (± 2163284
)128581967
ns/iter (± 2363123
)0.97
es/full/all/es2016
122374937
ns/iter (± 1590569
)128339470
ns/iter (± 1916900
)0.95
es/full/all/es2017
121529312
ns/iter (± 1621237
)126152612
ns/iter (± 2027771
)0.96
es/full/all/es2018
119858293
ns/iter (± 1004343
)125607788
ns/iter (± 2391921
)0.95
es/full/all/es2019
118021245
ns/iter (± 904395
)122956960
ns/iter (± 2178771
)0.96
es/full/all/es2020
115239939
ns/iter (± 1265535
)119438580
ns/iter (± 2816432
)0.96
es/full/parser
531962
ns/iter (± 6929
)538693
ns/iter (± 7835
)0.99
es/full/base/fixer
21574
ns/iter (± 172
)21918
ns/iter (± 40
)0.98
es/full/base/resolver_and_hygiene
77736
ns/iter (± 488
)79095
ns/iter (± 82
)0.98
serialization of ast node
141
ns/iter (± 0
)145
ns/iter (± 1
)0.97
serialization of serde
126
ns/iter (± 0
)130
ns/iter (± 0
)0.97
css/minify/libraries/bootstrap
27573869
ns/iter (± 356554
)28061860
ns/iter (± 92962
)0.98
css/visitor/compare/clone
2025870
ns/iter (± 20622
)2061658
ns/iter (± 18919
)0.98
css/visitor/compare/visit_mut_span
2208544
ns/iter (± 13842
)2261713
ns/iter (± 8007
)0.98
css/visitor/compare/visit_mut_span_panic
2258269
ns/iter (± 16665
)2324204
ns/iter (± 10996
)0.97
css/visitor/compare/fold_span
2986204
ns/iter (± 23743
)3040731
ns/iter (± 37229
)0.98
css/visitor/compare/fold_span_panic
3126331
ns/iter (± 24680
)3165803
ns/iter (± 12247
)0.99
css/lexer/bootstrap_5_1_3
5120018
ns/iter (± 48276
)5157137
ns/iter (± 1339
)0.99
css/lexer/foundation_6_7_4
4224585
ns/iter (± 43081
)4335943
ns/iter (± 4437
)0.97
css/lexer/tailwind_3_1_1
801852
ns/iter (± 3711
)826398
ns/iter (± 1849
)0.97
css/parser/bootstrap_5_1_3
21462492
ns/iter (± 233505
)21864052
ns/iter (± 127974
)0.98
css/parser/foundation_6_7_4
16760797
ns/iter (± 183681
)17375799
ns/iter (± 89405
)0.96
css/parser/tailwind_3_1_1
3253324
ns/iter (± 17738
)3315858
ns/iter (± 2241
)0.98
es/codegen/colors
340839
ns/iter (± 187092
)329857
ns/iter (± 184749
)1.03
es/codegen/large
1120154
ns/iter (± 578233
)1192363
ns/iter (± 609417
)0.94
es/codegen/with-parser/colors
48318
ns/iter (± 581
)48450
ns/iter (± 339
)1.00
es/codegen/with-parser/large
521727
ns/iter (± 4295
)536817
ns/iter (± 2353
)0.97
es/minify/libraries/antd
1352903093
ns/iter (± 19815496
)1464234589
ns/iter (± 18554281
)0.92
es/minify/libraries/d3
242022859
ns/iter (± 3005704
)264890160
ns/iter (± 9372730
)0.91
es/minify/libraries/echarts
1002691155
ns/iter (± 14292338
)1115878354
ns/iter (± 25059237
)0.90
es/minify/libraries/jquery
76512864
ns/iter (± 547092
)80459958
ns/iter (± 905069
)0.95
es/minify/libraries/lodash
93306385
ns/iter (± 642872
)96930134
ns/iter (± 1638556
)0.96
es/minify/libraries/moment
44866390
ns/iter (± 329436
)46710259
ns/iter (± 1075542
)0.96
es/minify/libraries/react
16710536
ns/iter (± 117017
)17406616
ns/iter (± 338125
)0.96
es/minify/libraries/terser
202047331
ns/iter (± 2078416
)223492251
ns/iter (± 5785699
)0.90
es/minify/libraries/three
346717784
ns/iter (± 5601331
)400731266
ns/iter (± 14599261
)0.87
es/minify/libraries/typescript
2519604865
ns/iter (± 21427844
)2688768006
ns/iter (± 25655696
)0.94
es/minify/libraries/victory
524058961
ns/iter (± 5353861
)604219226
ns/iter (± 22133713
)0.87
es/minify/libraries/vue
113155952
ns/iter (± 1341924
)119481059
ns/iter (± 2123257
)0.95
es/visitor/compare/clone
2380830
ns/iter (± 15877
)2428875
ns/iter (± 13154
)0.98
es/visitor/compare/visit_mut_span
2775225
ns/iter (± 18805
)2816672
ns/iter (± 29592
)0.99
es/visitor/compare/visit_mut_span_panic
2853805
ns/iter (± 18992
)2843806
ns/iter (± 29988
)1.00
es/visitor/compare/fold_span
3979827
ns/iter (± 40214
)3994071
ns/iter (± 24399
)1.00
es/visitor/compare/fold_span_panic
4049227
ns/iter (± 32656
)4089319
ns/iter (± 17965
)0.99
es/lexer/colors
16987
ns/iter (± 79
)17173
ns/iter (± 14
)0.99
es/lexer/angular
8163413
ns/iter (± 41573
)8256626
ns/iter (± 3162
)0.99
es/lexer/backbone
1072587
ns/iter (± 5616
)1078022
ns/iter (± 1357
)0.99
es/lexer/jquery
5941010
ns/iter (± 33359
)5959136
ns/iter (± 1872
)1.00
es/lexer/jquery mobile
9170920
ns/iter (± 51636
)9187350
ns/iter (± 3581
)1.00
es/lexer/mootools
4607103
ns/iter (± 43529
)4676690
ns/iter (± 10858
)0.99
es/lexer/underscore
895047
ns/iter (± 4348
)900132
ns/iter (± 1140
)0.99
es/lexer/three
27890601
ns/iter (± 157713
)27899578
ns/iter (± 19324
)1.00
es/lexer/yui
5048366
ns/iter (± 21702
)5054381
ns/iter (± 8154
)1.00
es/parser/colors
30566
ns/iter (± 188
)30745
ns/iter (± 110
)0.99
es/parser/angular
15437986
ns/iter (± 220956
)15648782
ns/iter (± 182492
)0.99
es/parser/backbone
2328143
ns/iter (± 10592
)2340780
ns/iter (± 12926
)0.99
es/parser/jquery
12520055
ns/iter (± 129575
)12701909
ns/iter (± 80641
)0.99
es/parser/jquery mobile
19405743
ns/iter (± 108938
)20339852
ns/iter (± 259542
)0.95
es/parser/mootools
9406799
ns/iter (± 45719
)9752872
ns/iter (± 27287
)0.96
es/parser/underscore
1918301
ns/iter (± 18163
)1992775
ns/iter (± 12620
)0.96
es/parser/three
55195452
ns/iter (± 800629
)60513468
ns/iter (± 379017
)0.91
es/parser/yui
9375279
ns/iter (± 109062
)9713487
ns/iter (± 42978
)0.97
es/preset-env/usage/builtin_type
141988
ns/iter (± 32964
)142798
ns/iter (± 32917
)0.99
es/preset-env/usage/property
20868
ns/iter (± 163
)21215
ns/iter (± 64
)0.98
es/resolver/typescript
106790913
ns/iter (± 1811300
)111677355
ns/iter (± 2219303
)0.96
es/fixer/typescript
84515026
ns/iter (± 2813954
)85907361
ns/iter (± 500667
)0.98
es/hygiene/typescript
172344867
ns/iter (± 953526
)182787583
ns/iter (± 1081686
)0.94
es/resolver_with_hygiene/typescript
294297733
ns/iter (± 2775070
)328124543
ns/iter (± 4606613
)0.90
es/visitor/base-perf/module_clone
73715
ns/iter (± 1517
)74624
ns/iter (± 2109
)0.99
es/visitor/base-perf/fold_empty
85356
ns/iter (± 2305
)84985
ns/iter (± 1764
)1.00
es/visitor/base-perf/fold_noop_impl_all
83311
ns/iter (± 1266
)85285
ns/iter (± 1604
)0.98
es/visitor/base-perf/fold_noop_impl_vec
83808
ns/iter (± 1093
)85525
ns/iter (± 1362
)0.98
es/visitor/base-perf/boxing_boxed_clone
54
ns/iter (± 0
)56
ns/iter (± 0
)0.96
es/visitor/base-perf/boxing_unboxed_clone
58
ns/iter (± 0
)59
ns/iter (± 0
)0.98
es/visitor/base-perf/boxing_boxed
100
ns/iter (± 0
)105
ns/iter (± 0
)0.95
es/visitor/base-perf/boxing_unboxed
101
ns/iter (± 0
)103
ns/iter (± 0
)0.98
es/visitor/base-perf/visit_contains_this
3343
ns/iter (± 59
)3566
ns/iter (± 101
)0.94
es/base/parallel/resolver/typescript
5182026834
ns/iter (± 501973737
)5733069217
ns/iter (± 434599667
)0.90
es/base/parallel/hygiene/typescript
2108454044
ns/iter (± 34099857
)2116272039
ns/iter (± 30967896
)1.00
misc/visitors/time-complexity/time 5
97
ns/iter (± 0
)92
ns/iter (± 0
)1.05
misc/visitors/time-complexity/time 10
306
ns/iter (± 1
)312
ns/iter (± 0
)0.98
misc/visitors/time-complexity/time 15
632
ns/iter (± 6
)600
ns/iter (± 1
)1.05
misc/visitors/time-complexity/time 20
1205
ns/iter (± 18
)1122
ns/iter (± 3
)1.07
misc/visitors/time-complexity/time 40
6581
ns/iter (± 37
)5912
ns/iter (± 32
)1.11
misc/visitors/time-complexity/time 60
16702
ns/iter (± 180
)15339
ns/iter (± 46
)1.09
es/full-target/es2016
184521
ns/iter (± 1171
)187538
ns/iter (± 571
)0.98
es/full-target/es2017
179480
ns/iter (± 1275
)182177
ns/iter (± 521
)0.99
es/full-target/es2018
167269
ns/iter (± 1510
)172020
ns/iter (± 642
)0.97
es2020_nullish_coalescing
65424
ns/iter (± 609
)66907
ns/iter (± 7795
)0.98
es2020_optional_chaining
94063
ns/iter (± 7642
)95423
ns/iter (± 3108
)0.99
es2022_class_properties
92890
ns/iter (± 539
)94013
ns/iter (± 247
)0.99
es2018_object_rest_spread
70789
ns/iter (± 477
)71179
ns/iter (± 194
)0.99
es2019_optional_catch_binding
60598
ns/iter (± 416
)61449
ns/iter (± 123
)0.99
es2017_async_to_generator
60838
ns/iter (± 337
)61777
ns/iter (± 56
)0.98
es2016_exponentiation
64421
ns/iter (± 211
)64994
ns/iter (± 131
)0.99
es2015_arrow
68647
ns/iter (± 606
)70216
ns/iter (± 181
)0.98
es2015_block_scoped_fn
65709
ns/iter (± 461
)66119
ns/iter (± 193
)0.99
es2015_block_scoping
154505
ns/iter (± 6632
)157365
ns/iter (± 10118
)0.98
es2015_classes
114596
ns/iter (± 585
)116481
ns/iter (± 455
)0.98
es2015_computed_props
60615
ns/iter (± 402
)61434
ns/iter (± 117
)0.99
es2015_destructuring
115075
ns/iter (± 710
)117028
ns/iter (± 188
)0.98
es2015_duplicate_keys
64073
ns/iter (± 178
)64138
ns/iter (± 61
)1.00
es2015_parameters
78400
ns/iter (± 489
)79370
ns/iter (± 149
)0.99
es2015_fn_name
66087
ns/iter (± 278
)66465
ns/iter (± 596
)0.99
es2015_for_of
64331
ns/iter (± 423
)64440
ns/iter (± 92
)1.00
es2015_instanceof
62624
ns/iter (± 292
)63191
ns/iter (± 121
)0.99
es2015_shorthand_property
60900
ns/iter (± 502
)61195
ns/iter (± 87
)1.00
es2015_spread
60422
ns/iter (± 331
)61167
ns/iter (± 158
)0.99
es2015_sticky_regex
62574
ns/iter (± 696
)62452
ns/iter (± 176
)1.00
es2015_typeof_symbol
62337
ns/iter (± 357
)62561
ns/iter (± 112
)1.00
es/transform/baseline/base
52314
ns/iter (± 249
)52031
ns/iter (± 111
)1.01
es/transform/baseline/common_reserved_word
62650
ns/iter (± 400
)62813
ns/iter (± 127
)1.00
es/transform/baseline/common_typescript
140781
ns/iter (± 877
)146508
ns/iter (± 3204
)0.96
es/target/es3
168636
ns/iter (± 859
)169449
ns/iter (± 874
)1.00
es/target/es2015
630338
ns/iter (± 2607
)631565
ns/iter (± 989
)1.00
es/target/es2016
64752
ns/iter (± 388
)65251
ns/iter (± 167
)0.99
es/target/es2017
61933
ns/iter (± 131
)61709
ns/iter (± 104
)1.00
es/target/es2018
81061
ns/iter (± 479
)81299
ns/iter (± 199
)1.00
es/target/es2020
131383
ns/iter (± 662
)132893
ns/iter (± 212
)0.99
babelify-only
669995
ns/iter (± 3394
)675692
ns/iter (± 426
)0.99
parse_and_babelify_angular
44384983
ns/iter (± 682489
)42585612
ns/iter (± 1647328
)1.04
parse_and_babelify_backbone
5511381
ns/iter (± 94292
)5517295
ns/iter (± 27594
)1.00
parse_and_babelify_jquery
32275386
ns/iter (± 438741
)32169067
ns/iter (± 336812
)1.00
parse_and_babelify_jquery_mobile
54730087
ns/iter (± 451654
)55116087
ns/iter (± 535615
)0.99
parse_and_babelify_mootools
32732485
ns/iter (± 452829
)33334192
ns/iter (± 211117
)0.98
parse_and_babelify_underscore
4478971
ns/iter (± 43211
)4399509
ns/iter (± 20425
)1.02
parse_and_babelify_yui
32211000
ns/iter (± 659804
)32294726
ns/iter (± 465338
)1.00
html/minify/document/css_spec
41842712
ns/iter (± 226509
)42995682
ns/iter (± 221551
)0.97
html/minify/document/github
17546447
ns/iter (± 138103
)17695641
ns/iter (± 49718
)0.99
html/minify/document/stackoverflow
15603193
ns/iter (± 96709
)15917577
ns/iter (± 90756
)0.98
html/minify/document_fragment/css_spec
40185310
ns/iter (± 332719
)40893666
ns/iter (± 238122
)0.98
html/minify/document_fragment/github
16778820
ns/iter (± 78486
)16832225
ns/iter (± 69165
)1.00
html/minify/document_fragment/stackoverflow
15256643
ns/iter (± 123222
)15221975
ns/iter (± 39813
)1.00
html/document/visitor/compare/clone
338089
ns/iter (± 3191
)341915
ns/iter (± 2436
)0.99
html/document/visitor/compare/visit_mut_span
369167
ns/iter (± 2056
)366765
ns/iter (± 2454
)1.01
html/document/visitor/compare/visit_mut_span_panic
368176
ns/iter (± 4116
)375650
ns/iter (± 2040
)0.98
html/document/visitor/compare/fold_span
404732
ns/iter (± 3734
)404954
ns/iter (± 2022
)1.00
html/document/visitor/compare/fold_span_panic
449512
ns/iter (± 1668
)461218
ns/iter (± 1079
)0.97
html/document_fragment/visitor/compare/clone
337898
ns/iter (± 3837
)337601
ns/iter (± 1957
)1.00
html/document_fragment/visitor/compare/visit_mut_span
362181
ns/iter (± 3618
)363817
ns/iter (± 1581
)1.00
html/document_fragment/visitor/compare/visit_mut_span_panic
372556
ns/iter (± 2343
)377297
ns/iter (± 1922
)0.99
html/document_fragment/visitor/compare/fold_span
400532
ns/iter (± 2370
)407084
ns/iter (± 1627
)0.98
html/document_fragment/visitor/compare/fold_span_panic
454928
ns/iter (± 2310
)460705
ns/iter (± 1768
)0.99
html/lexer/css_2021_spec
15337405
ns/iter (± 138425
)15632490
ns/iter (± 13745
)0.98
html/lexer/github_com_17_05_2022
5943574
ns/iter (± 47505
)6037066
ns/iter (± 1834
)0.98
html/lexer/stackoverflow_com_17_05_2022
5482938
ns/iter (± 42292
)5652062
ns/iter (± 7136
)0.97
html/parser/parser_document/css_2021_spec
24997204
ns/iter (± 496794
)25321289
ns/iter (± 74872
)0.99
html/parser/parser_document/github_com_17_05_2022
8548730
ns/iter (± 64668
)8730962
ns/iter (± 14612
)0.98
html/parser/parser_document/stackoverflow_com_17_05_2022
7591734
ns/iter (± 45671
)7697658
ns/iter (± 23054
)0.99
html/parser/parser_document_fragment/css_2021_spec
25365799
ns/iter (± 358082
)25584372
ns/iter (± 127952
)0.99
html/parser/parser_document_fragment/github_com_17_05_2022
8735156
ns/iter (± 39999
)8764979
ns/iter (± 22436
)1.00
html/parser/parser_document_fragment/stackoverflow_com_17_05_2022
7621016
ns/iter (± 46349
)7762678
ns/iter (± 13508
)0.98
This comment was automatically generated by workflow using github-action-benchmark.