Skip to content

Commit ee75756

Browse files
kdy1kdy1
authoredSep 5, 2023
feat(es/codegen): Add an option to print assert for import attributes (#7914)
**Description:** - `jsc.experimental.keepImportAssertions` is renamed to `jsc.experimental.keepImportAttributes`. - `jsc.experimental.emitAssertForImportAttributes` is added. **Related issue:** - Closes #7908
·
v1.11.13swc_core@v0.106.1
1 parent 92d08c3 commit ee75756

File tree

43 files changed

+221
-193
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+221
-193
lines changed
 

‎bindings/binding_core_node/Cargo.toml

+1
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ tracing-subscriber = { version = "0.3.9", features = ["env-filter"] }
5454
swc_core = { version = "0.82.10", features = [
5555
"allocator_node",
5656
"ecma_ast",
57+
"ecma_codegen",
5758
"ecma_ast_serde",
5859
"common_concurrent",
5960
"bundler",

‎bindings/binding_core_node/src/bundle.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -129,16 +129,16 @@ impl Task for BundleTask {
129129
None,
130130
None,
131131
true,
132-
codegen_target,
133132
SourceMapsConfig::Bool(true),
134133
// TODO
135134
&Default::default(),
136135
None,
137-
minify,
138136
None,
139137
true,
140-
false,
141138
Default::default(),
139+
swc_core::ecma::codegen::Config::default()
140+
.with_target(codegen_target)
141+
.with_minify(minify),
142142
)?;
143143

144144
Ok((k, output))

1 commit comments

Comments
 (1)

github-actions[bot] commented on Sep 5, 2023

@github-actions[bot]
github-actions[bot]
on Sep 5, 2023

Benchmark

Benchmark suite Current: ee75756 Previous: 85d6e9b Ratio
es/full/bugs-1 285076 ns/iter (± 5626) 283033 ns/iter (± 5467) 1.01
es/full/minify/libraries/antd 1316641651 ns/iter (± 10873867) 1335264000 ns/iter (± 13559921) 0.99
es/full/minify/libraries/d3 277667143 ns/iter (± 4891363) 280355522 ns/iter (± 6638995) 0.99
es/full/minify/libraries/echarts 1059806008 ns/iter (± 7580703) 1063321369 ns/iter (± 11193471) 1.00
es/full/minify/libraries/jquery 84604455 ns/iter (± 191505) 84018119 ns/iter (± 581700) 1.01
es/full/minify/libraries/lodash 97973419 ns/iter (± 260025) 97009616 ns/iter (± 410638) 1.01
es/full/minify/libraries/moment 50276488 ns/iter (± 144054) 49622622 ns/iter (± 144554) 1.01
es/full/minify/libraries/react 18081787 ns/iter (± 111610) 17884288 ns/iter (± 42623) 1.01
es/full/minify/libraries/terser 219684119 ns/iter (± 4878331) 217277824 ns/iter (± 3073211) 1.01
es/full/minify/libraries/three 390758645 ns/iter (± 570717) 389508115 ns/iter (± 6870755) 1.00
es/full/minify/libraries/typescript 2647775723 ns/iter (± 6066885) 2646593410 ns/iter (± 27835604) 1.00
es/full/minify/libraries/victory 570363342 ns/iter (± 18833565) 576163193 ns/iter (± 7881833) 0.99
es/full/minify/libraries/vue 120142817 ns/iter (± 365894) 119710247 ns/iter (± 309679) 1.00
es/full/codegen/es3 35341 ns/iter (± 305) 34912 ns/iter (± 125) 1.01
es/full/codegen/es5 35306 ns/iter (± 109) 34575 ns/iter (± 68) 1.02
es/full/codegen/es2015 35290 ns/iter (± 173) 34528 ns/iter (± 138) 1.02
es/full/codegen/es2016 35332 ns/iter (± 88) 34544 ns/iter (± 96) 1.02
es/full/codegen/es2017 35390 ns/iter (± 153) 34461 ns/iter (± 129) 1.03
es/full/codegen/es2018 35311 ns/iter (± 140) 34477 ns/iter (± 70) 1.02
es/full/codegen/es2019 35307 ns/iter (± 1263) 34537 ns/iter (± 76) 1.02
es/full/codegen/es2020 35345 ns/iter (± 145) 34486 ns/iter (± 130) 1.02
es/full/all/es3 167948427 ns/iter (± 1256953) 169109701 ns/iter (± 591640) 0.99
es/full/all/es5 159179256 ns/iter (± 1212654) 161068730 ns/iter (± 813033) 0.99
es/full/all/es2015 119570134 ns/iter (± 650928) 119781030 ns/iter (± 580442) 1.00
es/full/all/es2016 118618211 ns/iter (± 1776547) 119368458 ns/iter (± 365486) 0.99
es/full/all/es2017 118076678 ns/iter (± 1195831) 118208061 ns/iter (± 433504) 1.00
es/full/all/es2018 116282710 ns/iter (± 398683) 116638240 ns/iter (± 952899) 1.00
es/full/all/es2019 115723186 ns/iter (± 914250) 115833091 ns/iter (± 419147) 1.00
es/full/all/es2020 110742209 ns/iter (± 630533) 111314100 ns/iter (± 792140) 0.99
es/full/parser 481947 ns/iter (± 5517) 489813 ns/iter (± 6081) 0.98
es/full/base/fixer 20267 ns/iter (± 122) 18903 ns/iter (± 67) 1.07
es/full/base/resolver_and_hygiene 80528 ns/iter (± 243) 81167 ns/iter (± 610) 0.99
serialization of serde 292 ns/iter (± 12) 286 ns/iter (± 0) 1.02
css/minify/libraries/bootstrap 28723807 ns/iter (± 133216) 28739286 ns/iter (± 146047) 1.00
css/visitor/compare/clone 1653759 ns/iter (± 7429) 1669958 ns/iter (± 6747) 0.99
css/visitor/compare/visit_mut_span 1809582 ns/iter (± 11624) 1804396 ns/iter (± 3517) 1.00
css/visitor/compare/visit_mut_span_panic 1845708 ns/iter (± 10546) 1881029 ns/iter (± 6232) 0.98
css/visitor/compare/fold_span 2585692 ns/iter (± 10045) 2603664 ns/iter (± 6917) 0.99
css/visitor/compare/fold_span_panic 2768838 ns/iter (± 8657) 2769640 ns/iter (± 10480) 1.00
css/lexer/bootstrap_5_1_3 4430242 ns/iter (± 5634) 4490446 ns/iter (± 4899) 0.99
css/lexer/foundation_6_7_4 3715592 ns/iter (± 3694) 3778104 ns/iter (± 3302) 0.98
css/lexer/tailwind_3_1_1 704053 ns/iter (± 350) 722682 ns/iter (± 819) 0.97
css/parser/bootstrap_5_1_3 19227318 ns/iter (± 45456) 19358599 ns/iter (± 27991) 0.99
css/parser/foundation_6_7_4 15272215 ns/iter (± 13846) 15508469 ns/iter (± 34162) 0.98
css/parser/tailwind_3_1_1 2921846 ns/iter (± 2358) 2976185 ns/iter (± 9144) 0.98
es/codegen/colors 759987 ns/iter (± 405308) 736534 ns/iter (± 402412) 1.03
es/codegen/large 2922074 ns/iter (± 1552590) 3150942 ns/iter (± 1684907) 0.93
es/codegen/with-parser/colors 45551 ns/iter (± 563) 45292 ns/iter (± 176) 1.01
es/codegen/with-parser/large 490319 ns/iter (± 1063) 491211 ns/iter (± 961) 1.00
es/minify/libraries/antd 1125094254 ns/iter (± 11360273) 1169272945 ns/iter (± 10497030) 0.96
es/minify/libraries/d3 237286026 ns/iter (± 545905) 240961402 ns/iter (± 1620762) 0.98
es/minify/libraries/echarts 894836750 ns/iter (± 4374688) 931222919 ns/iter (± 27171260) 0.96
es/minify/libraries/jquery 72828247 ns/iter (± 261502) 74474045 ns/iter (± 500497) 0.98
es/minify/libraries/lodash 86473733 ns/iter (± 317735) 87327854 ns/iter (± 350956) 0.99
es/minify/libraries/moment 43253353 ns/iter (± 122155) 43514093 ns/iter (± 88552) 0.99
es/minify/libraries/react 15951546 ns/iter (± 142296) 16036078 ns/iter (± 70671) 0.99
es/minify/libraries/terser 184104420 ns/iter (± 376468) 187303388 ns/iter (± 664260) 0.98
es/minify/libraries/three 319776230 ns/iter (± 1529726) 328474161 ns/iter (± 2068585) 0.97
es/minify/libraries/typescript 2217847912 ns/iter (± 36679658) 2278061495 ns/iter (± 10308705) 0.97
es/minify/libraries/victory 474550920 ns/iter (± 1638077) 486686793 ns/iter (± 3565389) 0.98
es/minify/libraries/vue 105356335 ns/iter (± 213309) 107037696 ns/iter (± 2137403) 0.98
es/visitor/compare/clone 1948253 ns/iter (± 17339) 1958855 ns/iter (± 5827) 0.99
es/visitor/compare/visit_mut_span 2287788 ns/iter (± 2998) 2311988 ns/iter (± 4238) 0.99
es/visitor/compare/visit_mut_span_panic 2332466 ns/iter (± 4525) 2349307 ns/iter (± 4473) 0.99
es/visitor/compare/fold_span 3324449 ns/iter (± 9372) 3365138 ns/iter (± 12138) 0.99
es/visitor/compare/fold_span_panic 3477111 ns/iter (± 8842) 3476294 ns/iter (± 5570) 1.00
es/lexer/colors 13042 ns/iter (± 28) 13412 ns/iter (± 17) 0.97
es/lexer/angular 6067538 ns/iter (± 22261) 6250011 ns/iter (± 1894) 0.97
es/lexer/backbone 790676 ns/iter (± 772) 803351 ns/iter (± 616) 0.98
es/lexer/jquery 4472529 ns/iter (± 2915) 4583990 ns/iter (± 7330) 0.98
es/lexer/jquery mobile 6836822 ns/iter (± 6779) 7002492 ns/iter (± 6090) 0.98
es/lexer/mootools 3542721 ns/iter (± 2060) 3663840 ns/iter (± 14320) 0.97
es/lexer/underscore 659715 ns/iter (± 6622) 678477 ns/iter (± 1244) 0.97
es/lexer/three 21508142 ns/iter (± 65890) 21877803 ns/iter (± 10734) 0.98
es/lexer/yui 3818682 ns/iter (± 18723) 3910496 ns/iter (± 7077) 0.98
es/parser/colors 26989 ns/iter (± 81) 28050 ns/iter (± 33) 0.96
es/parser/angular 13370769 ns/iter (± 167106) 13440270 ns/iter (± 57452) 0.99
es/parser/backbone 1991346 ns/iter (± 9196) 1991726 ns/iter (± 9276) 1.00
es/parser/jquery 10842820 ns/iter (± 36854) 10887996 ns/iter (± 43392) 1.00
es/parser/jquery mobile 16560542 ns/iter (± 150457) 16705314 ns/iter (± 50964) 0.99
es/parser/mootools 8366586 ns/iter (± 15429) 8358743 ns/iter (± 18217) 1.00
es/parser/underscore 1719445 ns/iter (± 18337) 1713117 ns/iter (± 10530) 1.00
es/parser/three 46683410 ns/iter (± 2608180) 47304373 ns/iter (± 331385) 0.99
es/parser/yui 8213079 ns/iter (± 29869) 8242898 ns/iter (± 38725) 1.00
es/preset-env/usage/builtin_type 135327 ns/iter (± 32153) 137933 ns/iter (± 33329) 0.98
es/preset-env/usage/property 16441 ns/iter (± 45) 16657 ns/iter (± 54) 0.99
es/resolver/typescript 91099278 ns/iter (± 2298618) 91123619 ns/iter (± 1416943) 1.00
es/fixer/typescript 63663616 ns/iter (± 1018705) 62938032 ns/iter (± 241414) 1.01
es/hygiene/typescript 131353704 ns/iter (± 858937) 130539910 ns/iter (± 864132) 1.01
es/resolver_with_hygiene/typescript 246563752 ns/iter (± 2764870) 244683720 ns/iter (± 2570144) 1.01
es/visitor/base-perf/module_clone 60041 ns/iter (± 249) 60434 ns/iter (± 227) 0.99
es/visitor/base-perf/fold_empty 64074 ns/iter (± 267) 64097 ns/iter (± 364) 1.00
es/visitor/base-perf/fold_noop_impl_all 64156 ns/iter (± 625) 63959 ns/iter (± 337) 1.00
es/visitor/base-perf/fold_noop_impl_vec 64951 ns/iter (± 257) 63754 ns/iter (± 712) 1.02
es/visitor/base-perf/boxing_boxed_clone 59 ns/iter (± 0) 56 ns/iter (± 0) 1.05
es/visitor/base-perf/boxing_unboxed_clone 38 ns/iter (± 0) 40 ns/iter (± 0) 0.95
es/visitor/base-perf/boxing_boxed 110 ns/iter (± 0) 109 ns/iter (± 0) 1.01
es/visitor/base-perf/boxing_unboxed 78 ns/iter (± 0) 77 ns/iter (± 0) 1.01
es/visitor/base-perf/visit_empty 0 ns/iter (± 0) 0 ns/iter (± 0) NaN
es/visitor/base-perf/visit_contains_this 2488 ns/iter (± 15) 2541 ns/iter (± 26) 0.98
es/base/parallel/resolver/typescript 4537476671 ns/iter (± 261455986) 4221688644 ns/iter (± 175862327) 1.07
es/base/parallel/hygiene/typescript 1447571071 ns/iter (± 16861288) 1442947567 ns/iter (± 15048725) 1.00
misc/visitors/time-complexity/time 5 132 ns/iter (± 2) 134 ns/iter (± 0) 0.99
misc/visitors/time-complexity/time 10 291 ns/iter (± 0) 259 ns/iter (± 0) 1.12
misc/visitors/time-complexity/time 15 692 ns/iter (± 3) 677 ns/iter (± 6) 1.02
misc/visitors/time-complexity/time 20 1036 ns/iter (± 24) 1063 ns/iter (± 20) 0.97
misc/visitors/time-complexity/time 40 3863 ns/iter (± 164) 3890 ns/iter (± 4) 0.99
misc/visitors/time-complexity/time 60 7338 ns/iter (± 36) 7446 ns/iter (± 20) 0.99
es/full-target/es2016 228443 ns/iter (± 1606) 226349 ns/iter (± 1554) 1.01
es/full-target/es2017 215505 ns/iter (± 2116) 215126 ns/iter (± 422) 1.00
es/full-target/es2018 205403 ns/iter (± 6353) 204197 ns/iter (± 662) 1.01
es2020_nullish_coalescing 70300 ns/iter (± 394) 69230 ns/iter (± 286) 1.02
es2020_optional_chaining 78784 ns/iter (± 278) 78591 ns/iter (± 383) 1.00
es2022_class_properties 114884 ns/iter (± 260) 113956 ns/iter (± 386) 1.01
es2018_object_rest_spread 75609 ns/iter (± 225) 73576 ns/iter (± 161) 1.03
es2019_optional_catch_binding 63865 ns/iter (± 205) 63309 ns/iter (± 331) 1.01
es2017_async_to_generator 64191 ns/iter (± 251) 63467 ns/iter (± 288) 1.01
es2016_exponentiation 67981 ns/iter (± 198) 67910 ns/iter (± 287) 1.00
es2015_arrow 71595 ns/iter (± 236) 70766 ns/iter (± 367) 1.01
es2015_block_scoped_fn 68648 ns/iter (± 144) 68038 ns/iter (± 285) 1.01
es2015_block_scoping 124024 ns/iter (± 720) 122181 ns/iter (± 652) 1.02

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.