feat(es/minifier): Ignore return value if a param of IIFE is not used #6115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
jridgewell
previously approved these changes
Oct 11, 2022
There was a problem hiding this comment.
Is it possible to start adding test cases for the explicit feature under test? It seems we're testing indirectly, by updating the outputs to (extremely large) built projects. Particularly for negative cases (eg, I wanted to see that arguments[0] usage inside an arrow would deoptimize), but because a test outputs are already committed, I would need to scan through every file in the project to see the case.
|
I'll add small tests starting from the next PR |
swc-bot
reviewed
Oct 11, 2022
jridgewell
previously approved these changes
Oct 14, 2022
swc-bot
reviewed
Oct 14, 2022
swc-bot
reviewed
Oct 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue: