fix(css/parser): math functions in at-rules #6140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
changed the title
alexander-akait
changed the title
kdy1
reviewed
Oct 14, 2022
| @@ -2328,6 +2328,9 @@ where | |||
| value: vec![], | |||
| }; | |||
|
|
|||
| println!("FUCK {:?}", function); | |||
| println!("FUCK {:?}", self.ctx.block_contents_grammar); | |||
There was a problem hiding this comment.
Oh, sorry 😄
yisibl
reviewed
Oct 14, 2022
crates/swc_css_minifier/tests/fixture/compress-calc/container/output.min.css
Show resolved
Hide resolved
|
@kdy1 Fixed |
kdy1
approved these changes
Oct 14, 2022
swc-bot
reviewed
Oct 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix handle math function in
@mediaand@containerat-rules + better minificatio them.There are potential case to improve
width: calc(calc(calc(100px + 100px))), I will improve it late, because no one write code in this style + fix keepcalcinside@supports, beucase it can be used to checkcalcexists or notBREAKING CHANGE:
No
Related issue (if exists):
No