Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(es/minifier): Skip function declarations in sequential inliner #6147

Merged
merged 7 commits into from Oct 18, 2022
Merged

feat(es/minifier): Skip function declarations in sequential inliner #6147

merged 7 commits into from Oct 18, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 14, 2022

Description:

A function declaration does not have a side-effect so it's fine to skip it.

Related issue:

@kdy1 kdy1 added this to the Planned milestone Oct 14, 2022
@kdy1 kdy1 self-assigned this Oct 14, 2022
@kdy1 kdy1 mentioned this pull request Oct 14, 2022
Merged
kdy1
kdy1 commented Oct 14, 2022
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

@kdy1 kdy1 requested a review from jridgewell October 14, 2022 04:50
@kdy1 kdy1 marked this pull request as ready for review October 14, 2022 04:50
@kdy1
Copy link
Member Author

kdy1 commented Oct 18, 2022 •
edited

@jridgewell Can you review this, too?

Oh my bad

@kdy1 kdy1 enabled auto-merge (squash) October 18, 2022 01:46
swc-bot
swc-bot reviewed Oct 18, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment •
edited by kdy1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

ss

@kdy1 kdy1 merged commit f2e8f98 into swc-project:main Oct 18, 2022
@kdy1 kdy1 deleted the skip-fn branch October 18, 2022 02:51
@kdy1 kdy1 modified the milestones: Planned, v1.3.10 Oct 21, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@jridgewell jridgewell jridgewell approved these changes

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.10
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kdy1 @jridgewell @swc-bot