fix(es/minifier): Fix ordering issue of analyzer #6150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Austaras Do you think this analyzer patch is correct? |
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
kdy1
commented
Oct 14, 2022
|
|
||
| v.var_initialized |= has_init; | ||
| }) | ||
| .or_insert_with(|| VarUsageInfo { |
There was a problem hiding this comment.
This is problematic because this closure is not called if the analyzer called .var_or_default() for the infection analysis
|
Looks fine to me, but why tests changed? |
|
Because See #6150 (comment) |
Austaras
reviewed
Oct 14, 2022
| "use strict"; | ||
| _class_call_check(this, C), this.prop = i; | ||
| }; | ||
| arr.push(C); | ||
| }); |
There was a problem hiding this comment.
I see. In this case arr used to be marked as var_kind None.
There was a problem hiding this comment.
Yeah and that's why it was not inlined I guess
jridgewell
approved these changes
Oct 15, 2022
swc-bot
reviewed
Oct 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is the groundwork for a parallel analyzer. This PR fixes the ordering issue of the analyzer so that the analyzer works identically regardless of visit order. This patch contains some improvements because previously, we mixed
.and_modify()and.or_default().Related issue: