Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(quote_macros/expr): fix quote macro with template string struct #6157

Merged
merged 1 commit into from
Oct 15, 2022

Conversation

JSerFeng
Copy link
Contributor

@JSerFeng JSerFeng commented Oct 14, 2022

Just find out that there is a missing field span in Tpl when I'm using quote macro, when I use quote!("`Hello`" as Box) macro expansion failed because missing field span here.

It seems that there are no tests for this macro right ? If there are, please let me know so I can add test about it.

@CLAassistant
Copy link

CLAassistant commented Oct 14, 2022

CLA assistant check
All committers have signed the CLA.

@JSerFeng JSerFeng changed the title fix(quote_macros/expr): fix Tpl struct fix(quote_macros/expr): fix quote macro with template string struct Oct 14, 2022
@kdy1 kdy1 added this to the Planned milestone Oct 15, 2022
@kdy1 kdy1 self-assigned this Oct 15, 2022
@kdy1
Copy link
Member

kdy1 commented Oct 15, 2022

Can you sign the CLA?

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_quote_macros

@JSerFeng
Copy link
Contributor Author

Can you sign the CLA?

Done

@kdy1 kdy1 merged commit 6502979 into swc-project:main Oct 15, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.3.9 Oct 17, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants