Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/minifier): Preserve this of tagged template literals #6165

Merged
merged 12 commits into from Oct 15, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 15, 2022

Description:

Related issue:

@kdy1 kdy1 added this to the Planned milestone Oct 15, 2022
@kdy1 kdy1 self-assigned this Oct 15, 2022
@kdy1 kdy1 marked this pull request as ready for review October 15, 2022 07:07
@kdy1 kdy1 enabled auto-merge (squash) October 15, 2022 07:07
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 15, 2022
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_transforms_optimization

kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 15, 2022
@kdy1 kdy1 changed the title fix(es/fixer): Wrap member in a tagged tpl with a paren fix(es/minifier): Preserve this of tagged template literals Oct 15, 2022
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 15, 2022
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 15, 2022
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 15, 2022
@kdy1 kdy1 disabled auto-merge October 15, 2022 08:07
@kdy1 kdy1 marked this pull request as draft October 15, 2022 08:08
@kdy1 kdy1 marked this pull request as ready for review October 15, 2022 08:14
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 15, 2022
@kdy1 kdy1 enabled auto-merge (squash) October 15, 2022 08:14
@kdy1 kdy1 merged commit aec5cda into swc-project:main Oct 15, 2022
@kdy1 kdy1 deleted the issue-6146 branch October 15, 2022 09:11
@hyf0
Copy link
Contributor

hyf0 commented Oct 17, 2022

@kdy1 The fix seems not complete. After the fix,

let o = {
    f() {
        assert.ok(this !== o);
    }
};
(1, o.f)``;
(true ? o.f : false)``;
(true && o.f)``;

is still transformed to

let o = {
    f () {
        assert.ok(this !== o);
    }
};
(0, o.f)``, o.f``, o.f``;

The last two tagged templates were still transformed wrong.

@kdy1 kdy1 modified the milestones: Planned, v1.3.9 Oct 17, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Wrong simplified expression in tagged template
2 participants