Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Don't create a numeric literal with NaN value #6166

Merged
merged 2 commits into from Oct 15, 2022
Merged

fix(es/minifier): Don't create a numeric literal with NaN value #6166

merged 2 commits into from Oct 15, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 15, 2022

Description:

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Oct 15, 2022
@kdy1 kdy1 self-assigned this Oct 15, 2022
@kdy1 kdy1 marked this pull request as ready for review October 15, 2022 12:25
@kdy1 kdy1 enabled auto-merge (squash) October 15, 2022 12:25
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 15, 2022
View reviewed changes
kdy1
kdy1 commented Oct 15, 2022
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_transforms_optimization

@kdy1 kdy1 merged commit 2e153e5 into swc-project:main Oct 15, 2022
@kdy1 kdy1 deleted the minifier-nan branch October 15, 2022 12:52
@kdy1 kdy1 modified the milestones: Planned, v1.3.9 Oct 17, 2022
@Austaras
Copy link
Member

Why not? IIRC NaN hasn't been a modifierable ident since es5

@kdy1
Copy link
Member Author

kdy1 commented Oct 17, 2022 •
edited

It should be Ident, not Number. It's what the parser does

@Austaras
Copy link
Member

Maybe it's better to let NaN be a Number since we do lots of complex work around Ident. But that's a very minor problem.

@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.9
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kdy1 @Austaras