feat(es/minfiier): Compute more with sequential inliner #6169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdy1
commented
Oct 17, 2022
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
kdy1
commented
Oct 17, 2022
| @@ -1 +1,5 @@ | |||
| var a = [ | |||
There was a problem hiding this comment.
This seems like a regression
jridgewell
previously approved these changes
Oct 17, 2022
jridgewell
previously approved these changes
Oct 18, 2022
kdy1
commented
Oct 21, 2022
| /// This assumes `a.left.to_id() == b.left.to_id()` | ||
| fn can_drop_op_for(a: AssignOp, b: AssignOp) -> bool { | ||
| if a == b { | ||
| return matches!(a, op!("+=") | op!("-=") | op!("*=")); |
There was a problem hiding this comment.
I'll improve this function with another PR
swc-bot
reviewed
Oct 26, 2022
swc-bot
reviewed
Oct 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue: