Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/typescript): Don't generate class field for abstract props #6174

Merged
merged 1 commit into from
Oct 16, 2022
Merged

fix(es/typescript): Don't generate class field for abstract props #6174

merged 1 commit into from
Oct 16, 2022

Conversation

Austaras
Copy link
Member

Description:

BREAKING CHANGE:

Related issue (if exists):
closes #6023

kdy1
kdy1 approved these changes Oct 16, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_ecma_transforms_typescript

@kdy1 kdy1 added this to the Planned milestone Oct 16, 2022
@kdy1 kdy1 self-assigned this Oct 16, 2022
@kdy1 kdy1 merged commit 9d93b6c into swc-project:main Oct 16, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.3.9 Oct 17, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.9
Development

Successfully merging this pull request may close these issues.

useDefineForClassFields should not define abstract properties
2 participants
@Austaras @kdy1