Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(es/compat): Readonly and writeonly private field #6182

Merged
merged 2 commits into from Oct 18, 2022

Conversation

Austaras
Copy link
Member

@Austaras Austaras commented Oct 17, 2022

Description:

This is the most useless feature I've ever wrote.

BREAKING CHANGE:

Related issue (if exists):
closes #5599

Copy link
Contributor

@jridgewell jridgewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test case for the writing to a private method?

class Foo {
  #method() {
  }

  test() {
    // methods are always read-only.
    this.#method = 1;
  }
}

@kdy1 kdy1 added this to the Planned milestone Oct 18, 2022
@kdy1 kdy1 self-assigned this Oct 18, 2022
@Austaras
Copy link
Member Author

Can you add a test case for the writing to a private method?

class Foo {
  #method() {
  }

  test() {
    // methods are always read-only.
    this.#method = 1;
  }
}

I prefer not to, as there's already tsc test privateNameReadonly

jridgewell
jridgewell previously approved these changes Oct 18, 2022
Copy link
Contributor

@jridgewell jridgewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I didn't realize privateNameReadonly.1.normal.js was testing a private method. There doesn't seem to be a source file in our repo?

@kdy1
Copy link
Member

kdy1 commented Oct 18, 2022

@jridgewell It's in crates/swc_ecma_parser/tests/tsc

kdy1
kdy1 previously approved these changes Oct 18, 2022
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_transforms_compat

@kdy1 kdy1 enabled auto-merge (squash) October 18, 2022 03:20
auto-merge was automatically disabled October 18, 2022 03:24

Head branch was pushed to by a user without write access

@kdy1 kdy1 enabled auto-merge (squash) October 18, 2022 03:38
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script


@kdy1 kdy1 merged commit aefc11b into swc-project:main Oct 18, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.3.10 Oct 21, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Class properties pass should handle readonly on write-only fields
4 participants