Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(html/minifier): merge the same metadata elements #6183

Merged
merged 6 commits into from Oct 18, 2022

Conversation

alexander-akait
Copy link
Collaborator

@alexander-akait alexander-akait commented Oct 17, 2022

Description:

Merge the same style elements into one:

<style>a { color: red; }</style><style>b { color: red; }</style>

->

<style>a { color: red; }b { color: red; }</style>

The same possible with script tags, but need more complex logic and will be implemented in future

  • extra tests

Ref: kangax/html-minifier#1126

BREAKING CHANGE:

Yes

Related issue (if exists):

No

@alexander-akait alexander-akait marked this pull request as draft October 17, 2022 18:31
@alexander-akait alexander-akait marked this pull request as ready for review October 17, 2022 19:00
@ghostd
Copy link
Contributor

ghostd commented Oct 17, 2022

We should not merge tags ("style" or other) having some attributes like "id"; but maybe this is a very rare use case.

@alexander-akait
Copy link
Collaborator Author

alexander-akait commented Oct 17, 2022

@kdy1 kdy1 added this to the Planned milestone Oct 18, 2022
@kdy1 kdy1 self-assigned this Oct 18, 2022
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_html_minifier

@kdy1 kdy1 enabled auto-merge (squash) October 18, 2022 00:54
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a merge conflict

@alexander-akait
Copy link
Collaborator Author

@kdy1 Fixed

@kdy1 kdy1 merged commit 41093b0 into swc-project:main Oct 18, 2022
@alexander-akait alexander-akait deleted the improve-html-minifier branch October 18, 2022 13:42
@kdy1 kdy1 modified the milestones: Planned, v1.3.10 Oct 21, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants