feat(html/minifier): improve the remove_redundant_attributes option
#6197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
changed the title
remove_redundant_attributes option
kdy1
requested changes
Oct 19, 2022
| #[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)] | ||
| #[serde(deny_unknown_fields)] | ||
| #[serde(rename_all = "kebab-case")] | ||
| pub enum RemoveRedundantAttributes { |
There was a problem hiding this comment.
Let's implement Default for this type instead of using #[serde(default = "")].
There was a problem hiding this comment.
You can then change #[serde(default = "...")] to #[serde(default)]
|
@kdy1 Done, for another enum too 👍 |
alexander-akait
force-pushed
the
refactor-html-minifier-reducant-attributes
branch
from
9f7f76e
to
c176d5b
Compare
|
@kdy1 Fixed again 😄 |
kdy1
approved these changes
Oct 20, 2022
kdy1
approved these changes
Oct 20, 2022
swc-bot
reviewed
Oct 20, 2022
alexander-akait
deleted the
refactor-html-minifier-reducant-attributes
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Due kangax/html-minifier#1075
A lot of CSS frameworks use (and not only):
So it is not safe to remove them by default, anyway I implemented the
safemode - it will remove:BREAKING CHANGE:
Yes
Related issue (if exists):
No