Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(html/parser): raw ast for comment token #6202

Merged
merged 3 commits into from Oct 19, 2022
Merged

fix(html/parser): raw ast for comment token #6202

merged 3 commits into from Oct 19, 2022

Conversation

alexander-akait
Copy link
Collaborator

Description:

raw should be always Option<...>

BREAKING CHANGE:

Yes

Related issue (if exists):

No

@kdy1 kdy1 added this to the Planned milestone Oct 19, 2022
@kdy1 kdy1 self-assigned this Oct 19, 2022
kdy1
kdy1 approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_html_ast --breaking

kdy1
kdy1 requested changes Oct 19, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci failed

@alexander-akait
Copy link
Collaborator Author

@kdy1 Fixed

kdy1
kdy1 approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_html_ast --breaking

@kdy1 kdy1 enabled auto-merge (squash) October 19, 2022 14:39
swc-bot
swc-bot reviewed Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 99ea286 into swc-project:main Oct 19, 2022
@alexander-akait alexander-akait deleted the fix-raw-token-ast branch October 19, 2022 18:16
@kdy1 kdy1 modified the milestones: Planned, v1.3.10 Oct 21, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.10
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexander-akait @kdy1 @swc-bot