feat(es/minifier): Mark more expressions as pure #6204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0096b40ba775c2a85a059242dc32c7c6ad07c1ac.
kdy1
changed the title
kdy1
changed the title
kdy1
commented
Oct 19, 2022
| @@ -301,7 +301,7 @@ where | |||
| /// If a parameter is not used, we can ignore return value of the | |||
| /// corresponding argument. | |||
| pub(super) fn ignore_unused_args_of_iife(&mut self, e: &mut CallExpr) { | |||
| if !self.options.unused { | |||
| if !self.options.unused && !self.options.reduce_vars { | |||
There was a problem hiding this comment.
I changed this because of
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
jridgewell
previously approved these changes
Oct 20, 2022
| @@ -1,2 +1,2 @@ | |||
| //// [templateStringWithEmbeddedNewOperator.ts] | |||
| "abc".concat(new String("Hi"), "def"); | |||
| new String("Hi"); | |||
There was a problem hiding this comment.
Probably isn't important with String, but it's common for Map/WeakMap to be used. Are we eliminating built in constructors?
There was a problem hiding this comment.
Yes, but we are not dropping String. I think we should, though.
swc/crates/swc_ecma_minifier/src/compress/pure/misc.rs
Lines 1096 to 1100 in 7d5b544
swc-bot
reviewed
Oct 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue: