Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/compat): Super method call in loose mode #6207

Merged
merged 2 commits into from Oct 20, 2022
Merged

fix(es/compat): Super method call in loose mode #6207

merged 2 commits into from Oct 20, 2022

Conversation

Austaras
Copy link
Member

@Austaras Austaras commented Oct 19, 2022 •
edited

Description:

Seems like to be caused by #5576 cc @magic-akari

BREAKING CHANGE:

Related issue (if exists):
closes #5936

@kdy1 kdy1 self-assigned this Oct 19, 2022
@kdy1 kdy1 added this to the Planned milestone Oct 19, 2022
@kdy1
Copy link
Member

kdy1 commented Oct 19, 2022

Can you add a fixture test for this case?

kdy1
kdy1 approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_node_base
  • swc_ecma_transforms_compat

@kdy1 kdy1 enabled auto-merge (squash) October 19, 2022 23:33
@kdy1 kdy1 disabled auto-merge October 19, 2022 23:34
@kdy1 kdy1 enabled auto-merge (squash) October 19, 2022 23:43
swc-bot
swc-bot reviewed Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 0e2de30 into swc-project:main Oct 20, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.3.10 Oct 21, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.10
Development

Successfully merging this pull request may close these issues.

super.method() in extended class in loose mode generates code with infinite recursive loop
3 participants
@Austaras @kdy1 @swc-bot