Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(html/parser): atom + perf #6210

Merged
merged 7 commits into from Oct 19, 2022
Merged

Conversation

alexander-akait
Copy link
Collaborator

@alexander-akait alexander-akait commented Oct 19, 2022

Description:

Before using swc_html_minify to bench:

html/minify/document/css_spec                                                                           
                        time:   [48.143 ms 48.257 ms 48.390 ms]
                        change: [-3.1896% -0.9565% +0.6793%] (p = 0.46 > 0.05)
                        Performance has improved.
Found 1 outliers among 10 measurements (10.00%)
  1 (10.00%) high severe
html/minify/document/github                                                                           
                        time:   [19.532 ms 19.569 ms 19.618 ms]
                        change: [-3.1896% -0.9565% +0.6793%] (p = 0.46 > 0.05)
                        No change in performance detected.
Found 1 outliers among 10 measurements (10.00%)
  1 (10.00%) high severe
html/minify/document/stackoverflow                                                                           
                        time:   [16.958 ms 17.008 ms 17.081 ms]
                        change: [-1.1692% -0.3571% +0.3620%] (p = 0.43 > 0.05)
                        No change in performance detected.
Found 1 outliers among 10 measurements (10.00%)
  1 (10.00%) high mild

html/minify/document_fragment/css_spec                                                                           
                        time:   [46.740 ms 46.826 ms 47.056 ms]
                        change: [-0.7255% +0.1777% +1.0953%] (p = 0.73 > 0.05)
                        No change in performance detected.
Found 2 outliers among 10 measurements (20.00%)
  2 (20.00%) high severe
html/minify/document_fragment/github                                                                           
                        time:   [19.069 ms 19.221 ms 19.418 ms]
                        change: [-1.1241% -0.1140% +0.8650%] (p = 0.84 > 0.05)
                        No change in performance detected.
Found 2 outliers among 10 measurements (20.00%)
  2 (20.00%) high severe
html/minify/document_fragment/stackoverflow                                                                           
                        time:   [16.899 ms 16.921 ms 16.946 ms]
                        change: [-0.7586% -0.0360% +0.8779%] (p = 0.94 > 0.05)
                        No change in performance detected.
Found 1 outliers among 10 measurements (10.00%)
  1 (10.00%) high severe

After using swc_html_minify to bench:

html/minify/document/css_spec                                                                           
                        time:   [41.873 ms 41.977 ms 42.118 ms]
                        change: [-11.739% -7.5798% -3.4009%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 1 outliers among 10 measurements (10.00%)
  1 (10.00%) high severe
html/minify/document/github                                                                           
                        time:   [18.446 ms 18.492 ms 18.531 ms]
                        change: [-5.4652% -4.4001% -3.1595%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 1 outliers among 10 measurements (10.00%)
  1 (10.00%) high severe
html/minify/document/stackoverflow                                                                           
                        time:   [14.923 ms 14.947 ms 14.971 ms]
                        change: [-8.9518% -7.9947% -6.9481%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 1 outliers among 10 measurements (10.00%)
  1 (10.00%) high severe

html/minify/document_fragment/css_spec                                                                           
                        time:   [40.270 ms 40.437 ms 40.610 ms]
                        change: [-10.855% -9.3940% -8.0995%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 1 outliers among 10 measurements (10.00%)
  1 (10.00%) high mild
html/minify/document_fragment/github                                                                           
                        time:   [17.962 ms 17.991 ms 18.038 ms]
                        change: [-5.2539% -4.4223% -3.7342%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 1 outliers among 10 measurements (10.00%)
  1 (10.00%) high mild
html/minify/document_fragment/stackoverflow                                                                           
                        time:   [14.734 ms 14.760 ms 14.796 ms]
                        change: [-9.1301% -8.4154% -7.6186%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 1 outliers among 10 measurements (10.00%)
  1 (10.00%) high severe

BREAKING CHANGE:

Yes

Related issue (if exists):

No

@alexander-akait alexander-akait marked this pull request as draft October 19, 2022 22:33
@alexander-akait alexander-akait marked this pull request as ready for review October 19, 2022 22:50
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_html_ast --breaking

@kdy1 kdy1 enabled auto-merge (squash) October 19, 2022 23:32
@kdy1 kdy1 merged commit 420ba32 into swc-project:main Oct 19, 2022
@alexander-akait alexander-akait deleted the html-parser-perf branch October 19, 2022 23:32
@kdy1 kdy1 added this to the Planned milestone Oct 19, 2022
@kdy1 kdy1 self-assigned this Oct 19, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.3.10 Oct 21, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants