Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(css/minifier): merge rules #6220

Merged
merged 27 commits into from Oct 21, 2022
Merged

feat(css/minifier): merge rules #6220

merged 27 commits into from Oct 21, 2022

Conversation

alexander-akait
Copy link
Collaborator

@alexander-akait alexander-akait commented Oct 20, 2022 •
edited

Description:

Merge the same rules + all tests from https://github.com/cssnano/cssnano/tree/master/packages/postcss-merge-rules

BREAKING CHANGE:

No

Related issue (if exists):

partial #5880, there are two todos to solve all cases:

  • future browserslist support
  • partial merging rules (will be iin near future)

@alexander-akait alexander-akait marked this pull request as ready for review October 20, 2022 19:10
@kdy1 kdy1 added this to the Planned milestone Oct 20, 2022
@kdy1 kdy1 self-assigned this Oct 20, 2022
kdy1
kdy1 approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_css_minifier

@kdy1 kdy1 enabled auto-merge (squash) October 21, 2022 02:47
@kdy1 kdy1 disabled auto-merge October 21, 2022 03:03
kdy1
kdy1 requested changes Oct 21, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed

kdy1
kdy1 requested changes Oct 21, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase again to exclude unrelated commits?

@alexander-akait
Copy link
Collaborator Author

@kdy1 Yeah, WIP on this, my mistake

@alexander-akait
Copy link
Collaborator Author

@kdy1 Fixed

@kdy1 kdy1 merged commit 8b6b9c0 into swc-project:main Oct 21, 2022
@alexander-akait alexander-akait deleted the feat-merge-rules branch October 21, 2022 13:05
@ludofischer
Copy link

Does the method in this PR also solve the various issues with the merge-rules implementation in cssnano (https://github.com/cssnano/cssnano/projects/5)?

@alexander-akait
Copy link
Collaborator Author

@ludofischer we don't implement the partial merging and browserslist based, so we don't have these problems right now (but yes, we will need to solve them in future)

@kdy1 kdy1 modified the milestones: Planned, v1.3.11 Oct 26, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.11
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexander-akait @ludofischer @kdy1