test(css/minifier): catch error in minifier #6222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
force-pushed
the
test-fix
branch
from
b3d53b4
to
1175899
Compare
alexander-akait
force-pushed
the
test-fix
branch
from
e06d860
to
514bcf2
Compare
alexander-akait
commented
Oct 27, 2022
| @@ -1,5 +1,3 @@ | |||
| div[data-size="calc(3*3)"] { | |||
| } | |||
|
|
|||
| div:nth-child(2n + calc(3*3)) { | |||
There was a problem hiding this comment.
calc can't be used here, it is not allowed by spec here, so I remove this tests, because it is list of component values and we even parser this as Calc
alexander-akait
commented
Oct 27, 2022
| color: hwb(90 50% 50%); | ||
| color: hwb(90 50% 50% 0.2); | ||
| color: hwb(90 50% 50% / 0.2); |
There was a problem hiding this comment.
Invalid color syntax, I fix them
|
@kdy1 Ready to review |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Catch errors to avoid crate broken tests cases
BREAKING CHANGE:
No
Related issue (if exists):
No