Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(es/minifier): Inline lazy inited vars used once #6237

Merged
merged 3 commits into from Oct 26, 2022

Conversation

Austaras
Copy link
Member

Description:
Mainly for inline var inited with functions, basically a followup for #5404

BREAKING CHANGE:

Related issue (if exists):

@kdy1 kdy1 self-assigned this Oct 24, 2022
@kdy1 kdy1 added this to the Planned milestone Oct 24, 2022
kdy1
kdy1 previously approved these changes Oct 25, 2022
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

jridgewell
jridgewell previously approved these changes Oct 26, 2022
};
Point.Origin = Origin;
}(Point || (Point = {})), function(A) {
(Point || (Point = {})).Origin = function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we want to maintain the function's name

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends on the configuration

@kdy1 kdy1 dismissed stale reviews from jridgewell and themself via 31584ec October 26, 2022 04:45
@kdy1 kdy1 enabled auto-merge (squash) October 26, 2022 04:45
@kdy1 kdy1 merged commit 1cd7f61 into swc-project:main Oct 26, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.3.11 Oct 26, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants