Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(es/minifier): Implement trivial optimizations #6256

Merged
merged 19 commits into from Nov 2, 2022
Merged

feat(es/minifier): Implement trivial optimizations #6256

merged 19 commits into from Nov 2, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 26, 2022 •
edited

Description:

  1. Evaluate Number.toString().
  2. Mark some terser tests as passing where our output is better.

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Oct 26, 2022
@kdy1 kdy1 self-assigned this Oct 26, 2022
@kdy1 kdy1 marked this pull request as ready for review October 31, 2022 07:49
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 31, 2022
View reviewed changes
@kdy1 kdy1 requested a review from jridgewell October 31, 2022 07:49
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 31, 2022
View reviewed changes
kdy1
kdy1 commented Oct 31, 2022
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

jridgewell
jridgewell previously approved these changes Nov 1, 2022
View reviewed changes
crates/swc_ecma_minifier/src/compress/pure/evaluate.rs Outdated Show resolved Hide resolved
@kdy1 kdy1 enabled auto-merge (squash) November 2, 2022 00:51
@kdy1 kdy1 dismissed stale reviews from jridgewell and kodiakhq via a0d7041 November 2, 2022 00:51
swc-bot
swc-bot reviewed Nov 2, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 5d52ae9 into swc-project:main Nov 2, 2022
@kdy1 kdy1 deleted the m-trivial branch November 2, 2022 01:21
@kdy1 kdy1 modified the milestones: Planned, v1.3.12, v1.3.13 Nov 2, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

@jridgewell jridgewell jridgewell left review comments

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.13
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kdy1 @jridgewell @swc-bot