Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Don't ignore nullish coalescing #6272

Merged
merged 3 commits into from Oct 28, 2022
Merged

fix(es/minifier): Don't ignore nullish coalescing #6272

merged 3 commits into from Oct 28, 2022

Conversation

Austaras
Copy link
Member

Description:

BREAKING CHANGE:

Related issue (if exists):

kdy1
kdy1 previously approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

@kdy1 kdy1 added this to the Planned milestone Oct 27, 2022
@kdy1 kdy1 requested a review from jridgewell October 27, 2022 11:58
@kdy1
Copy link
Member

kdy1 commented Oct 27, 2022

CI failed

@kdy1 kdy1 self-assigned this Oct 28, 2022
@kdy1 kdy1 enabled auto-merge (squash) October 28, 2022 01:01
swc-bot
swc-bot reviewed Oct 28, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Oct 28, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 8c1ac68 into swc-project:main Oct 28, 2022
@Austaras Austaras mentioned this pull request Oct 28, 2022
Merged
@kdy1 kdy1 mentioned this pull request Nov 2, 2022
Merged
@kdy1 kdy1 modified the milestones: Planned, v1.3.12, v1.3.13 Nov 2, 2022
huozhi pushed a commit to vercel/next.js that referenced this pull request Nov 4, 2022
@kdy1
chore: Update swc_core to v0.40.40 (#42326)
670f2a8 
This PR updates swc crates to
swc-project/swc@5784ae2



Applies

 - swc-project/swc#6300

Closes #42171.

 - swc-project/swc#6293
 
 - swc-project/swc#6272

Closes #41992.
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@jridgewell jridgewell jridgewell approved these changes

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.13
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Austaras @kdy1 @jridgewell @swc-bot