Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(css/parser): many fixes #6281

Merged
merged 13 commits into from Oct 28, 2022
Merged

refactor(css/parser): many fixes #6281

merged 13 commits into from Oct 28, 2022

Conversation

alexander-akait
Copy link
Collaborator

@alexander-akait alexander-akait commented Oct 28, 2022 •
edited

Description:

Big refactor:

  1. Refactor logic according spec https://www.w3.org/TR/css-syntax-3/#parser-algorithms
  2. Don't try to parse value in declaration which previously has error, in this case we will output only one error (on the porblem places) and store the list of component values (that is why we reduced number of useless errors)
  3. Better AST for custom properties
  4. Fix bug with span when it contains spaces after !important
  5. Fix parsing !important
  6. A lot of small fixes
  7. Better recovery mode

BREAKING CHANGE:

No

Related issue (if exists):

No

@kdy1 kdy1 self-assigned this Oct 28, 2022
@kdy1 kdy1 added this to the Planned milestone Oct 28, 2022
kdy1
kdy1 approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_css_parser

kdy1
kdy1 requested changes Oct 28, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy failed

@alexander-akait
Copy link
Collaborator Author

Yeah WIP on small regressions 👍

@kdy1 kdy1 enabled auto-merge (squash) October 28, 2022 04:00
swc-bot
swc-bot reviewed Oct 28, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 2813acc into swc-project:main Oct 28, 2022
@alexander-akait alexander-akait deleted the refactor-parser branch October 28, 2022 11:58
@kdy1 kdy1 modified the milestones: Planned, v1.3.12, v1.3.13 Nov 2, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.3.13 Nov 3, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.13
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexander-akait @kdy1 @swc-bot