test(es/minifier): Add a test for `??` operator #6282

kdy1 · 2022-10-28T01:26:49Z

Description:

I'm still investigating.

Related issue:

swcMinify causes production builds to generate incorrect swagger documentation using next-swagger-doc vercel/next.js#41992.

Investigation

                        &JsMinifyOptions {
                            compress: BoolOrDataConfig::from_bool(false),
                            mangle: BoolOrDataConfig::from_bool(false),
                            ..self.opts.clone()
                        }

works, while

                        &JsMinifyOptions {
                            compress: TerserCompressorOptions {
                                defaults: false,
                                ..Default::default()
                            }
                            .into(),
                            mangle: BoolOrDataConfig::from_bool(false),
                            ..self.opts.clone()
                        },

does not

I found the cause.

is compiled as

so we should preserve ??

kdy1 · 2022-10-28T02:57:55Z

crates/swc_ecma_minifier/tests/fixture/next/41992/output.js

+                    let { onTryoutClick: t , parameters: r , allowTryItOut: a , tryItOutEnabled: n , specPath: l , fn: s , getComponent: o , getConfigs: i , specSelectors: u , specActions: d , pathMethod: g , oas3Actions: v , oas3Selectors: E , operation: b  } = this.props;
+                    const S = o("parameterRow"), _ = o("TryItOutButton"), w = o("contentType"), C = o("Callbacks", !0), x = o("RequestBody", !0), A = n && a, I = u.isOAS3(), R = b.get("requestBody"), N = (0, p.default)(e = (0, ft.default)((0, p.default)(r).call(r, (e, t)=>{
+                        const r = t.get("in");
+                        return e[r] ?? (e[r] = []), e[r].push(t), e;


This was previously e[r], e[r] = []

kdy1

swc-bump:

swc_ecma_minifier

jridgewell · 2022-10-28T05:00:24Z

Is it possible to add a reduced test case?

kdy1 · 2022-10-28T05:07:36Z

crates/swc_ecma_minifier/tests/fixture/next/41992/1/output.js

+                tryItOutEnabled: !1,
+                allowTryItOut: !0,
+                onChangeKey: [],
+                specPath: []


@jridgewell Do you think it's better to remove this file?

Yes. If this file changes in the future, there's very little chance I'll spot the previously buggy code again.

Good point, I'll do it for other patches too

Austaras · 2022-10-28T07:05:58Z

Has this already been fixed by #6272?

kdy1 · 2022-10-28T07:06:50Z

@Austaras No, as we have removing logic in more places

Austaras · 2022-10-28T07:15:38Z

No, there's alreay a may_short_circuit in L668, and I've testes the input on main branch which generates identical output.

Austaras · 2022-10-28T07:16:10Z

The ignore_return_value is really too long to parse for human...

kdy1 · 2022-10-28T07:16:37Z

Oh, if then it's possible that I was using a old base branch.

kdy1 · 2022-10-28T07:23:44Z

You are right, this was fixed already and I was using an old base

kdy1 added this to the Planned milestone Oct 28, 2022

kdy1 self-assigned this Oct 28, 2022

kdy1 changed the title ~~fix(es/minifier): Fix a bug~~ fix(es/minifier): Don't drop ?? Oct 28, 2022

kdy1 marked this pull request as ready for review October 28, 2022 02:56

kodiakhq bot previously approved these changes Oct 28, 2022

View reviewed changes

kdy1 dismissed kodiakhq[bot]’s stale review via b9a599b October 28, 2022 02:56

kodiakhq bot previously approved these changes Oct 28, 2022

View reviewed changes

kdy1 commented Oct 28, 2022

View reviewed changes

kdy1 requested a review from jridgewell October 28, 2022 02:58

kdy1 dismissed kodiakhq[bot]’s stale review via 0fef414 October 28, 2022 03:23

kodiakhq bot previously approved these changes Oct 28, 2022

View reviewed changes

kdy1 dismissed kodiakhq[bot]’s stale review via 886be13 October 28, 2022 03:25

kdy1 force-pushed the next-41992 branch from 0fef414 to 886be13 Compare October 28, 2022 03:25

kodiakhq bot previously approved these changes Oct 28, 2022

View reviewed changes

kdy1 commented Oct 28, 2022

View reviewed changes

jridgewell previously approved these changes Oct 28, 2022

View reviewed changes

kdy1 dismissed stale reviews from jridgewell and kodiakhq[bot] via 6e77c13 October 28, 2022 05:07

kdy1 commented Oct 28, 2022

View reviewed changes

kodiakhq bot previously approved these changes Oct 28, 2022

View reviewed changes

kdy1 dismissed kodiakhq[bot]’s stale review via 6639e45 October 28, 2022 05:11

kodiakhq bot previously approved these changes Oct 28, 2022

View reviewed changes

kdy1 mentioned this pull request Oct 28, 2022

Issue with parameters and swcMinify jellydn/next-swagger-doc#515

Closed

kdy1 requested a review from jridgewell October 28, 2022 07:07

kdy1 added 10 commits October 28, 2022 16:17

Typo

5270bb2

Reduce

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

bd1b107

config.json

aac7c5e

version

9d11c89

Fix

3221c5d

Update test refs

Verified

This commit was signed with the committer’s verified signature.

MichaReiser Micha Reiser

SSH Key Fingerprint: ecGsN1ElBc6rDn4Ge3zV90y0fffKRH+1PNbJCxfpPEs
Verified
Learn about vigilant mode

4869894

lint

Verified

This commit was signed with the committer’s verified signature.

MichaReiser Micha Reiser

SSH Key Fingerprint: ecGsN1ElBc6rDn4Ge3zV90y0fffKRH+1PNbJCxfpPEs
Verified
Learn about vigilant mode

73d3ee2

Add a test

534243d

Update test refs

6ebeb2e

Only reduced

fe9eaf8

kdy1 dismissed kodiakhq[bot]’s stale review via fe9eaf8 October 28, 2022 07:19

kdy1 force-pushed the next-41992 branch from 6639e45 to fe9eaf8 Compare October 28, 2022 07:19

kodiakhq bot previously approved these changes Oct 28, 2022

View reviewed changes

It was useless

ec1ac37

kdy1 dismissed kodiakhq[bot]’s stale review via ec1ac37 October 28, 2022 07:23

kodiakhq bot approved these changes Oct 28, 2022

View reviewed changes

kdy1 changed the title ~~fix(es/minifier): Don't drop ??~~ test(es/minifier): Add a test for ?? operator Oct 28, 2022

kdy1 enabled auto-merge (squash) October 28, 2022 07:24

kdy1 merged commit 0376da7 into swc-project:main Oct 28, 2022

kdy1 deleted the next-41992 branch October 28, 2022 08:00

kdy1 modified the milestones: Planned, v1.3.12, v1.3.13 Nov 2, 2022

swc-project locked as resolved and limited conversation to collaborators Dec 3, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GitHub Sponsors

test(es/minifier): Add a test for `??` operator #6282

test(es/minifier): Add a test for `??` operator #6282

kdy1 commented Oct 28, 2022 •

edited

Loading

kdy1 Oct 28, 2022

kdy1 left a comment

jridgewell commented Oct 28, 2022

kdy1 Oct 28, 2022

jridgewell Oct 28, 2022

kdy1 Oct 28, 2022 •

edited

Loading

Austaras commented Oct 28, 2022

kdy1 commented Oct 28, 2022

Austaras commented Oct 28, 2022

Austaras commented Oct 28, 2022

kdy1 commented Oct 28, 2022

kdy1 commented Oct 28, 2022

test(es/minifier): Add a test for ?? operator #6282

test(es/minifier): Add a test for ?? operator #6282

Conversation

kdy1 commented Oct 28, 2022 • edited Loading

Investigation

kdy1 Oct 28, 2022

Choose a reason for hiding this comment

kdy1 left a comment

Choose a reason for hiding this comment

jridgewell commented Oct 28, 2022

kdy1 Oct 28, 2022

Choose a reason for hiding this comment

jridgewell Oct 28, 2022

Choose a reason for hiding this comment

kdy1 Oct 28, 2022 • edited Loading

Choose a reason for hiding this comment

Austaras commented Oct 28, 2022

kdy1 commented Oct 28, 2022

Austaras commented Oct 28, 2022

Austaras commented Oct 28, 2022

kdy1 commented Oct 28, 2022

kdy1 commented Oct 28, 2022

test(es/minifier): Add a test for `??` operator #6282

test(es/minifier): Add a test for `??` operator #6282

kdy1 commented Oct 28, 2022 •

edited

Loading

kdy1 Oct 28, 2022 •

edited

Loading