Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Don't inline regex for IIFEs #6283

Merged
merged 15 commits into from Oct 29, 2022
Merged

fix(es/minifier): Don't inline regex for IIFEs #6283

merged 15 commits into from Oct 29, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 28, 2022

Description:

Related issue:

@kdy1 kdy1 added this to the Planned milestone Oct 28, 2022
@kdy1 kdy1 self-assigned this Oct 28, 2022
@kdy1 kdy1 requested a review from jridgewell October 28, 2022 03:26
@kdy1 kdy1 marked this pull request as ready for review October 28, 2022 03:26
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 28, 2022
View reviewed changes
kdy1
kdy1 commented Oct 28, 2022
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 28, 2022
View reviewed changes
@kdy1 kdy1 dismissed stale reviews from jridgewell and kodiakhq via d08cb4b October 28, 2022 05:19
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 28, 2022
View reviewed changes
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 28, 2022
View reviewed changes
@kdy1 kdy1 requested a review from jridgewell October 28, 2022 07:07
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 28, 2022
View reviewed changes
@kdy1 @jridgewell
Update crates/swc_ecma_minifier/tests/fixture/issues/6279/2/input.js
53322f1 
Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
@kdy1 kdy1 dismissed stale reviews from jridgewell and kodiakhq via 53322f1 October 28, 2022 22:33
@kdy1 @jridgewell
Update crates/swc_ecma_minifier/tests/fixture/issues/6279/2/output.js
557decb 
Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
@kdy1 kdy1 enabled auto-merge (squash) October 28, 2022 22:34
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 28, 2022
View reviewed changes
swc-bot
swc-bot reviewed Oct 28, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Oct 28, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 4eab2ed into swc-project:main Oct 29, 2022
@kdy1 kdy1 deleted the issue-6279 branch October 29, 2022 00:02
@kdy1 kdy1 modified the milestones: Planned, v1.3.12, v1.3.13 Nov 2, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

@jridgewell jridgewell jridgewell left review comments

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.13
Development

Successfully merging this pull request may close these issues.

Avoid inlining regex in loop conditional
3 participants
@kdy1 @jridgewell @swc-bot