Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(css/parser): more #6288

Merged
merged 8 commits into from Oct 29, 2022
Merged

Conversation

alexander-akait
Copy link
Collaborator

Description:

Here:

  • fix span for declaration
  • refactor parsing function
  • fix small bugs
  • simplify code

BREAKING CHANGE:

No

Related issue (if exists):

No

@alexander-akait alexander-akait changed the title Refactor parser more refactor(css/parser): more Oct 28, 2022
@@ -1,4 +1,10 @@

x Unexpected duplicate '@import' rule 'a.css'.
,-[$DIR/tests/rules/fail/no-duplicate-at-import-rules/11/input.css:2:1]
2 | @import 'a.css' layer();
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to better recovery mode

@import url("./test.css") layer() supports(display: flex) screen and (min-width: 400px);
@import url("./test.css") layer();
@import url("./test.css") layer supports(display: flex) screen and (min-width: 400px);
@import url("./test.css") layer;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to better recovery mode

@kdy1 kdy1 self-assigned this Oct 28, 2022
@kdy1 kdy1 added this to the Planned milestone Oct 28, 2022
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_css_parser

@kdy1 kdy1 enabled auto-merge (squash) October 29, 2022 07:49
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 6cafeb2 into swc-project:main Oct 29, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.3.12, v1.3.13 Nov 2, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants