Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support trailing commas in swcrc #6289

Merged
merged 1 commit into from Oct 28, 2022
Merged

Support trailing commas in swcrc #6289

merged 1 commit into from Oct 28, 2022

Conversation

johanholmerin
Copy link
Contributor

@johanholmerin johanholmerin commented Oct 28, 2022

Description:

As request in vercel/turbo#2429, switches from json_comments to jsonc-parser to align dependencies with Turbopack. Used the same options as in Turbopack, which adds support for trailing commas but still requires properties to be quoted.

BREAKING CHANGE:

No

Related issue (if exists):

No

@CLAassistant
Copy link

CLAassistant commented Oct 28, 2022

CLA assistant check
All committers have signed the CLA.

@kdy1 kdy1 self-assigned this Oct 28, 2022
@kdy1 kdy1 added this to the Planned milestone Oct 28, 2022
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc

@kdy1 kdy1 enabled auto-merge (squash) October 28, 2022 22:35
@kdy1 kdy1 merged commit 244b0af into swc-project:main Oct 28, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.3.12, v1.3.13 Nov 2, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants