refactor: process_js_with_custom_pass should accept comments as paramter #6290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSerFeng
force-pushed
the
refactor/change-process-js-with-custom-pass
branch
2 times, most recently
from
c47496a
to
764ae4d
Compare
kdy1
reviewed
Oct 29, 2022
crates/swc/src/lib.rs
Outdated
| @@ -851,24 +851,24 @@ impl Compiler { | |||
| program: Option<Program>, | |||
| handler: &Handler, | |||
| opts: &Options, | |||
| custom_before_pass: impl FnOnce(&Program, &SingleThreadedComments) -> P1, | |||
| custom_after_pass: impl FnOnce(&Program, &SingleThreadedComments) -> P2, | |||
| comments: Option<&SingleThreadedComments>, | |||
There was a problem hiding this comment.
Please make this non-optional, and take ownership
JSerFeng
force-pushed
the
refactor/change-process-js-with-custom-pass
branch
from
764ae4d
to
1986c80
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
process_js_with_custom_pass()should acceptcommentsas parameter instead of using it internally, as user may pass an already parsed AST, and parse also needcommentsas parameter, so thosecommentsshould be the same.Breaking Change
It's a breaking change, and I remember that next.js is using this API.
Also bindings/binding_core_wasm is using too.
Do I need to edit CHANGELOG, or if it can be done by
swc-bot