Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix const-assign in function expressions #6294

Merged
merged 1 commit into from Oct 30, 2022
Merged

Fix const-assign in function expressions #6294

merged 1 commit into from Oct 30, 2022

Conversation

johanholmerin
Copy link
Contributor

Description:

is_pat_decl was previously set to true while visiting all children of a variable declaration, meaning function expressions would not be checked. Fixed by only setting is_pat_decl while visiting the initialization of the variable declarator.

BREAKING CHANGE:

No

Related issue (if exists):

Fixes #6252

@kdy1 kdy1 self-assigned this Oct 30, 2022
@kdy1 kdy1 added this to the Planned milestone Oct 30, 2022
kdy1
kdy1 approved these changes Oct 30, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_lints

@kdy1 kdy1 enabled auto-merge (squash) October 30, 2022 11:57
@kdy1 kdy1 merged commit a27392a into swc-project:main Oct 30, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.3.12, v1.3.13 Nov 2, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.13
Development

Successfully merging this pull request may close these issues.

const reassignment works in arrow function
2 participants
@johanholmerin @kdy1