Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ecma/parser): fix parsing await as ident #6316

Merged
merged 6 commits into from Nov 3, 2022
Merged

fix(ecma/parser): fix parsing await as ident #6316

merged 6 commits into from Nov 3, 2022

Conversation

alexander-akait
Copy link
Collaborator

Description:

Fix bug in parser with await ident

BREAKING CHANGE:

No

Related issue (if exists):

Fixes #6301

kdy1
kdy1 previously approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_parser

@kdy1 kdy1 added this to the Planned milestone Nov 2, 2022
@kdy1 kdy1 self-assigned this Nov 2, 2022
@alexander-akait
Copy link
Collaborator Author

Found more bugs and fixed

@alexander-akait
Copy link
Collaborator Author

@kdy1 Ready for review

@kdy1 kdy1 enabled auto-merge (squash) November 3, 2022 00:45
swc-bot
swc-bot reviewed Nov 3, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment •
edited by kdy1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reset ci

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Nov 3, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 28af15e into swc-project:main Nov 3, 2022
@alexander-akait alexander-akait deleted the issue-6301 branch November 3, 2022 05:03
@kdy1 kdy1 modified the milestones: Planned, v1.3.15 Nov 12, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.15
Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to use await as an identifier in ExprStmt
3 participants
@alexander-akait @kdy1 @swc-bot