Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css/parser): fix supports() parsing #6333

Merged
merged 8 commits into from Nov 8, 2022
Merged

fix(css/parser): fix supports() parsing #6333

merged 8 commits into from Nov 8, 2022

Conversation

alexander-akait
Copy link
Collaborator

Description:

supports() can be empty + tests

BREAKING CHANGE:

No

Related issue (if exists):

No

@kdy1 kdy1 added this to the Planned milestone Nov 3, 2022
@kdy1 kdy1 self-assigned this Nov 3, 2022
kdy1
kdy1 approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_css_ast

@kdy1 kdy1 enabled auto-merge (squash) November 3, 2022 00:47
@alexander-akait
Copy link
Collaborator Author

Need more work, found more bugs, will fix in near future

@kdy1 kdy1 disabled auto-merge November 3, 2022 02:53
kdy1
kdy1 requested changes Nov 3, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed

@alexander-akait
Copy link
Collaborator Author

@kdy1 Ready to review

@kdy1
Copy link
Member

kdy1 commented Nov 4, 2022

Seems like ci is still failing?

@alexander-akait
Copy link
Collaborator Author

alexander-akait commented Nov 7, 2022 •
edited

@kdy1 Should be fixed, my fail

@kdy1 kdy1 enabled auto-merge (squash) November 8, 2022 01:08
swc-bot
swc-bot reviewed Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit f483224 into swc-project:main Nov 8, 2022
@alexander-akait alexander-akait deleted the css-fix-supports-parsing branch November 8, 2022 01:38
@kdy1 kdy1 modified the milestones: Planned, v1.3.15 Nov 12, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.15
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexander-akait @kdy1 @swc-bot