Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/compat): Fix span hygiene of function naming pass #6345

Merged
merged 22 commits into from Nov 14, 2022
Merged

fix(es/compat): Fix span hygiene of function naming pass #6345

merged 22 commits into from Nov 14, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Nov 3, 2022 •
edited

Description:

Related issue:

Investigation


  DEBUG  mangle: `init#0` -> t
    at crates/swc_ecma_transforms_base/src/rename/analyzer/scope.rs:295
    in mangle names
    in minify
    in process_js_inner
    in process_js_with_custom_pass

this is the problem. The context of function expression should not be #0

@kdy1 kdy1 added this to the Planned milestone Nov 3, 2022
@kdy1 kdy1 self-assigned this Nov 3, 2022
@kdy1 kdy1 closed this Nov 13, 2022
@kdy1 kdy1 deleted the issue-6344 branch November 13, 2022 00:21
@kdy1 kdy1 modified the milestones: Planned, v1.3.16 Nov 13, 2022
@kdy1 kdy1 restored the issue-6344 branch November 14, 2022 02:14
@kdy1 kdy1 deleted the issue-6344 branch November 14, 2022 02:14
@kdy1 kdy1 restored the issue-6344 branch November 14, 2022 02:14
@kdy1 kdy1 reopened this Nov 14, 2022
@kdy1 kdy1 changed the title fix(es/compat): Fix span hygiene of block scoping pass fix(es/compat): Fix span hygiene of function naming pass Nov 14, 2022
@kdy1 kdy1 marked this pull request as ready for review November 14, 2022 04:31
kodiakhq[bot]
kodiakhq bot previously approved these changes Nov 14, 2022
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) November 14, 2022 04:31
kdy1
kdy1 commented Nov 14, 2022
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_transforms_compat

swc-bot
swc-bot reviewed Nov 14, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

kodiakhq[bot]
kodiakhq bot previously approved these changes Nov 14, 2022
View reviewed changes
swc-bot
swc-bot reviewed Nov 14, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 81a4bb3 into swc-project:main Nov 14, 2022
@kdy1 kdy1 deleted the issue-6344 branch November 14, 2022 06:03
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.16
Development

Successfully merging this pull request may close these issues.

Mangler inserts wrong function name on anonymous function declaration
2 participants
@kdy1 @swc-bot