Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/compat): this in computed class method name #6364

Merged
merged 2 commits into from Nov 6, 2022
Merged

fix(es/compat): this in computed class method name #6364

merged 2 commits into from Nov 6, 2022

Conversation

Austaras
Copy link
Member

@Austaras Austaras commented Nov 5, 2022

Description:

Some remain problem -- in_strict should always be true when in es module, but that would be too many lines of code change
BREAKING CHANGE:

Related issue (if exists):
closes #6356

kdy1
kdy1 approved these changes Nov 5, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

swc-bump:

  • swc_ecma_transforms_compat

@kdy1 kdy1 added this to the Planned milestone Nov 5, 2022
@kdy1 kdy1 enabled auto-merge (squash) November 5, 2022 23:49
swc-bot
swc-bot reviewed Nov 5, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 9820122 into swc-project:main Nov 6, 2022
@Austaras Austaras deleted the this branch November 6, 2022 07:10
@kdy1 kdy1 modified the milestones: Planned, v1.3.15 Nov 12, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.15
Development

Successfully merging this pull request may close these issues.

[Bug]: this inside class computed function throws TypeError
3 participants
@Austaras @kdy1 @swc-bot