fix(css/parser): <general-enclosed> parsing + fix todo
#6380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
commented
Nov 8, 2022
| @@ -45,7 +45,7 @@ div { | |||
| background: url('\"foo\"'); | |||
| } | |||
| .bar { | |||
| background: url(http://example.com/image.svg param(--color var(--primary-color); | |||
| background: url(http://example.com/image.svg param(--color var(--primary-color))); | |||
There was a problem hiding this comment.
Now we don't lose ) in declarations when we have BadUrl or BadStr
alexander-akait
commented
Nov 8, 2022
| @@ -1,5 +1,5 @@ | |||
|
|
|||
| x Expected function or '(' token | |||
There was a problem hiding this comment.
I think we should avoid using token in error messages, because developers can don't know what is token
alexander-akait
force-pushed
the
fix-todo
branch
from
30954a5
to
f11e03f
Compare
|
@kdy1 Rebased 👍 |
kdy1
approved these changes
Nov 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix
<general-enclosed>parsing with whitespaces + fix TODOBREAKING CHANGE:
No
Related issue (if exists):
No