New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(css/parser): refactor code #6395
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
force-pushed
the
test-more
branch
from
November 10, 2022 03:02
8870d35
to
de86283
Compare
kdy1
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
swc-bump:
- swc_css_ast --breaking
kdy1
requested changes
Nov 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a merge conflict
alexander-akait
force-pushed
the
test-more
branch
from
November 10, 2022 17:04
de86283
to
a933f38
Compare
@kdy1 Rebased 👍 |
Can you rebase again? |
Yes, WIP |
alexander-akait
force-pushed
the
test-more
branch
from
November 11, 2022 03:22
2f4ed0b
to
48d00d9
Compare
@kdy1 Fixed 👍 |
kdy1
approved these changes
Nov 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
use more box + refactor code according spec + tests for new nesting parsing
BREAKING CHANGE:
Yes
Related issue (if exists):
No