Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(css/parser): refactor code #6395

Merged
merged 7 commits into from Nov 11, 2022
Merged

Conversation

alexander-akait
Copy link
Collaborator

@alexander-akait alexander-akait commented Nov 10, 2022

Description:

use more box + refactor code according spec + tests for new nesting parsing

BREAKING CHANGE:

Yes

Related issue (if exists):

No

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_css_ast --breaking

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a merge conflict

@alexander-akait
Copy link
Collaborator Author

@kdy1 Rebased 👍

@kdy1
Copy link
Member

kdy1 commented Nov 11, 2022

Can you rebase again?

@alexander-akait
Copy link
Collaborator Author

Yes, WIP

@alexander-akait
Copy link
Collaborator Author

@kdy1 Fixed 👍

@kdy1 kdy1 enabled auto-merge (squash) November 11, 2022 07:26
@kdy1 kdy1 merged commit 983ab91 into swc-project:main Nov 11, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.3.15 Nov 12, 2022
@alexander-akait alexander-akait deleted the test-more branch November 13, 2022 15:41
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants