Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css/parser): use Atom for raw values #6401

Merged
merged 11 commits into from Nov 11, 2022

Conversation

alexander-akait
Copy link
Collaborator

@alexander-akait alexander-akait commented Nov 10, 2022

Description:

Migrate to Atom for raw

Perf(lexer):

css/lexer/bootstrap_5_1_3                                                                            
                        time:   [5.6220 ms 5.6315 ms 5.6413 ms]
                        change: [-3.9771% -2.9640% -2.0043%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild

css/lexer/foundation_6_7_4                                                                             
                        time:   [4.7299 ms 4.7514 ms 4.7772 ms]
                        change: [-19.648% -16.912% -14.210%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 9 outliers among 100 measurements (9.00%)
  4 (4.00%) high mild
  5 (5.00%) high severe

css/lexer/tailwind_3_1_1                                                                            
                        time:   [899.81 us 902.14 us 904.57 us]
                        change: [-6.3067% -5.8979% -5.4580%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 9 outliers among 100 measurements (9.00%)
  1 (1.00%) low mild
  2 (2.00%) high mild
  6 (6.00%) high severe

tailwind lexered faster than 1ms

BREAKING CHANGE:

Yes

Related issue (if exists):

No

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


swc-bump:

  • swc_css_ast --breaking

@kdy1 kdy1 enabled auto-merge (squash) November 11, 2022 01:23
@kdy1 kdy1 added this to the Planned milestone Nov 11, 2022
@kdy1 kdy1 merged commit ec2c021 into swc-project:main Nov 11, 2022
@alexander-akait alexander-akait deleted the improve-raw branch November 11, 2022 03:14
@kdy1 kdy1 modified the milestones: Planned, v1.3.15 Nov 12, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants