Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/minifier): Preserve op of the op-assignments in seq inliner #6428

Merged
merged 7 commits into from Nov 15, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Nov 14, 2022

Description:

Related issue:


Investigation

Output of Single-pass

export default class Demo {
    static encode(value) {
        const ranges = [];
        let range = [], retrString = A.encode(value), bitField = '';
        return value.forEach((curValue, i)=>{
            bitField += B.encode(curValue);
            range.push(i);
            ranges.push(range);
        }), retrString = '.' + C.encode(ranges);
    }
}
console.log(Deno.encode());

@kdy1 kdy1 added this to the Planned milestone Nov 14, 2022
@kdy1 kdy1 changed the title Issue 6407 fix(es/minifier): Fix a bug Nov 14, 2022
@kdy1 kdy1 changed the title fix(es/minifier): Fix a bug fix(es/minifier): Preserve op of the op-assignments in seq inliner Nov 14, 2022
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

@kdy1 kdy1 marked this pull request as ready for review November 14, 2022 01:20
@kdy1 kdy1 requested a review from jridgewell November 14, 2022 01:20
@kdy1 kdy1 enabled auto-merge (squash) November 14, 2022 23:43
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 5fd7ab8 into swc-project:main Nov 15, 2022
@kdy1 kdy1 deleted the issue-6407 branch November 15, 2022 00:22
@kdy1 kdy1 modified the milestones: Planned, v1.3.17 Nov 15, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Value is lost because of compression with comma operator
3 participants