Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(actions): ensure to honor pkgmgr #6437

Merged
merged 3 commits into from Nov 15, 2022
Merged

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Nov 14, 2022

Description:

We have pkgmgr constraint here:

"packageManager": "yarn@3.2.4"

but it is not really honored, i.e 13b4d31 reverts lockfile to old manifest format to yarn@1, in result if anyone uses correct pkg mgr (yarn@3) hits errors like below:

Internal Error: @swc/core@workspace:.: This package doesn't seem to be present in your lockfile; run "yarn install" to update the lockfile
    at gQ.getCandidates (/Users/ojkwon/.cache/node/corepack/yarn/3.2.4/yarn.js:435:5146)
    at Wf.getCandidates (/Users/ojkwon/.cache/node/corepack/yarn/3.2.4/yarn.js:391:1264)
    at /Users/ojkwon/.cache/node/corepack/yarn/3.2.4/yarn.js:439:7695
    at Rf (/Users/ojkwon/.cache/node/corepack/yarn/3.2.4/yarn.js:390:8965)
    at ue (/Users/ojkwon/.cache/node/corepack/yarn/3.2.4/yarn.js:439:7675)
    at async Promise.allSettled (index 0)
    at async eo (/Users/ojkwon/.cache/node/corepack/yarn/3.2.4/yarn.js:390:8293)
    at async /Users/ojkwon/.cache/node/corepack/yarn/3.2.4/yarn.js:439:8205
    at async ni.startProgressPromise (/Users/ojkwon/.cache/node/corepack/yarn/3.2.4/yarn.js:390:45507)
    at async He.resolveEverything (/Users/ojkwon/.cache/node/corepack/yarn/3.2.4/yarn.js:439:6238)

PR re-updates lockfile, and let CI honors correct pkgmgr to ensure validity of lockfile across changes.

BREAKING CHANGE:

Related issue (if exists):

@kwonoj kwonoj force-pushed the fix-lockfile branch 4 times, most recently from 2ad337c to f1a2e78 Compare November 14, 2022 18:44
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • dbg-swc

@kdy1 kdy1 enabled auto-merge (squash) November 14, 2022 23:47
@kdy1 kdy1 added this to the Planned milestone Nov 14, 2022
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 8ca3cc7 into swc-project:main Nov 15, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.3.17 Nov 15, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants